Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Jun 2018 14:06:52 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Nick Desaulniers <nick.desaulniers@gmail.com>
Cc:     mingo@redhat.com, linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] tracing: prefer strlcpy to strncpy
Message-ID: <20180604140652.34f28df7@gandalf.local.home>
In-Reply-To: <1527573818-29712-1-git-send-email-nick.desaulniers@gmail.com>
References: <1527573818-29712-1-git-send-email-nick.desaulniers@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 28 May 2018 23:03:38 -0700
Nick Desaulniers <nick.desaulniers@gmail.com> wrote:

> Fixes a stringop-truncation warning from gcc-8.
> 
> Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> ---
>  kernel/trace/trace_events_hist.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index b9061ed..b53a6c0 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -393,7 +393,7 @@ static void hist_err_event(char *str, char *system, char *event, char *var)
>  	else if (system)
>  		snprintf(err, MAX_FILTER_STR_VAL, "%s.%s", system, event);
>  	else
> -		strncpy(err, var, MAX_FILTER_STR_VAL);
> +		strlcpy(err, var, MAX_FILTER_STR_VAL);
>  
>  	hist_err(str, err);
>  }