Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 4 Jun 2018 14:10:03 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Nick Desaulniers <nick.desaulniers@gmail.com>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ebiggers@google.com
Subject: Re: [PATCH] tracing: prefer strlcpy to strncpy
Message-ID: <20180604141003.3b3d507b@gandalf.local.home>
In-Reply-To: <CAH7mPvh_T1YzfGBR+mzcwQ5r6bhz2NxrvY5r7sSY=wMeh-GK+w@mail.gmail.com>
References: <1527573818-29712-1-git-send-email-nick.desaulniers@gmail.com>
        <CAH7mPvh_T1YzfGBR+mzcwQ5r6bhz2NxrvY5r7sSY=wMeh-GK+w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, 29 May 2018 18:55:23 -0700
Nick Desaulniers <nick.desaulniers@gmail.com> wrote:

> On Mon, May 28, 2018 at 11:03 PM, Nick Desaulniers
> <nick.desaulniers@gmail.com> wrote:
> > Fixes a stringop-truncation warning from gcc-8.
> >
> > Signed-off-by: Nick Desaulniers <nick.desaulniers@gmail.com>
> > ---
> >  kernel/trace/trace_events_hist.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> > index b9061ed..b53a6c0 100644
> > --- a/kernel/trace/trace_events_hist.c
> > +++ b/kernel/trace/trace_events_hist.c
> > @@ -393,7 +393,7 @@ static void hist_err_event(char *str, char *system, char *event, char *var)
> >         else if (system)
> >                 snprintf(err, MAX_FILTER_STR_VAL, "%s.%s", system, event);
> >         else
> > -               strncpy(err, var, MAX_FILTER_STR_VAL);
> > +               strlcpy(err, var, MAX_FILTER_STR_VAL);
> >
> >         hist_err(str, err);
> >  }
> > --
> > 2.7.4
> >  
> 
> Eric points out this wont initialize the rest of err with zeros.

And why do we care?

-- Steve