Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp3907394imm; Mon, 4 Jun 2018 11:14:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJSHqWyQTd47Qj4IwQ3euZoYUxC+lu2FI5uKBn4A6XjtjV3fu3mhlGgL+IPebY2W0ztv8+D X-Received: by 2002:a62:701:: with SMTP id b1-v6mr11530986pfd.252.1528136046275; Mon, 04 Jun 2018 11:14:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528136046; cv=none; d=google.com; s=arc-20160816; b=Ufg8bDjE8ooSdWGVtRDoXqZD0OZ56mlEkBsIYEUqPYJmTd8zh51lPYTbUonEab1koG PHhZ7wYbcuzpe5oLxPCFro5oFw29uzFmQMgnq4XMDENryJGZV+QAkBCrFZBHpU9S0BTR 93TPxzpt5VQ5pQ0iREL/R3tLPGB6W55js+6YbP59qu4ETEwGB89p++806YsAdQGPcpu4 C+VGscKVgKu4kbU3qPHiyfWBq3cmlLI5PpSOFntcJ9cY+699aVg8k1iZQo281LDfw/7C 1CBE57DLXO7Pc0K++gG2Cw5A5BIggkmL30JuJ7ab4LWo79Dx3QwXPZDq5QPppWIvnFha oYGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=zVxQLOy75N9GHKTnu+X3CSIaPyFTw2fVzUnUt30eckc=; b=v1wrUmYr40nO9o84G4aCnugAlykDAp0E3EflggG2YvTcAHHfoUaFDXMqMlhT4bXRoc 1hCQ5Vb08P7j8b/SeuXaiTcrEZb6dSQhqBW1p7HhtjlgAmNN2B4B2tAjwSWq+9vXpy13 D3YkoSYiUZhbdcm+0rDh7HKYncBRNF6AgNS2fqHQBisp5BzQGb3hcT9xAhvO1LfvqJQd qK+hxaFymSPjHWMU9TWOL8196+290ZD0P9QqiNjfGDzFubcKn4NREL2YOXz/TrNbiIts XB5kGEA48CW91RRbXlADECVwlyCswx1h97SyIytnANrjC1rZ20GmleqeM5WL9dhzSiu9 bb6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=h3boRwu/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6-v6si47424107pla.12.2018.06.04.11.13.51; Mon, 04 Jun 2018 11:14:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=h3boRwu/; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751135AbeFDSNa (ORCPT + 99 others); Mon, 4 Jun 2018 14:13:30 -0400 Received: from mail-io0-f193.google.com ([209.85.223.193]:36983 "EHLO mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750985AbeFDSN2 (ORCPT ); Mon, 4 Jun 2018 14:13:28 -0400 Received: by mail-io0-f193.google.com with SMTP id s26-v6so70002ioj.4 for ; Mon, 04 Jun 2018 11:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zVxQLOy75N9GHKTnu+X3CSIaPyFTw2fVzUnUt30eckc=; b=h3boRwu/M7VV0MpuhaJe9nzd76jonGT3ivK8Zh4uvkcGJ5pBkSpu4/gpMf0BFwE5fc rN6BJ3B/pOKxAPZn4SRENmxTvQvLB3Q7GWNPbj4Zydwkv2FPW+r07DlE1XP50zZNAyhq HAs9nm6heWgN8NvyTSee+SAMIVAeIUPo9Ezxspys1hywvu6huzFCuKEV+LnotVpPXAZA KR/y8xRJO3Yb8iXv8SYmKYLge6hBpnddTQs7TrCMU0r9fvr626w3B0Ekcb1sZYYutpbk nukXU4q1hDsH5ve2I0U8xArIYQmWUxQZ3gyCJ6At5QutCoXblxwsiuEw04eOZMJYdqRQ vN7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zVxQLOy75N9GHKTnu+X3CSIaPyFTw2fVzUnUt30eckc=; b=cQ1b6d+BcdnUgpQHOgmQJ7wW6Gt5/yE0vB9spQNXQboyPAPOqKAe7qUQYYfRFF2sFU 8Zlz3PcMYBSBL4pP/vRUk3upy0yFx+fN6XE8xhpDMtPdw/5IT9RyHXyvM5g4lFMAbTD4 fUXz30/nCvnXozXTx2MCR6aplUXtZqM+8i6hKh66gtIw/BxkmZevegqiUh/538flZHR1 6u44TjStVIDIgVCnhwbpZksPJA+lQ2ii//XcbPRaPqczT3G7o3Z0SKQZzmPwuGDtBuNF ZBh/ZvtQEbXcqP3c09hXwBaOgg5EkUrpHcQaXpY6oBAYN6JDauoP3vlyTuJGpSKuBdfm /9/A== X-Gm-Message-State: ALKqPwci3QgIu0TUetb5ttOXE2HfNdqEIqFue1aPJDVlBWOe29upEFRD R5q7QLmQ/AUuPdPFTGQ++W6+OA== X-Received: by 2002:a6b:b288:: with SMTP id b130-v6mr23449701iof.153.1528136007594; Mon, 04 Jun 2018 11:13:27 -0700 (PDT) Received: from [192.168.1.167] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e92-v6sm5371629iod.29.2018.06.04.11.13.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 11:13:26 -0700 (PDT) Subject: Re: [PATCH v3] block/loop: Serialize ioctl operations. To: Tetsuo Handa Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot , syzbot References: <1527297408-4428-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> From: Jens Axboe Message-ID: <748bce03-afda-4ed2-13b3-1fcd01d57770@kernel.dk> Date: Mon, 4 Jun 2018 12:13:24 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/4/18 5:19 AM, Tetsuo Handa wrote: > This problem was already ignored for 8 months. Unless we boost priority, > this problem will be ignored for years. Jens, can we test this patch? Sorry, it's just that I _really_ hate this patch. We're making up a weird locking primitive that tracks the process, with a weird unlock helper that only unlocks if it's the process that is holding the mutex. I'll try and think about this a bit, it would be nice if we had a better alternative than the above. -- Jens Axboe