Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <d77a3fd9-ecda-1bf6-b4c9-60abdacd445a@oracle.com>
References: <CAB+yDaZAwFny2NdOZfymdpdR3Sf7pdkxahgQ6v2zBzUvSwBWTA@mail.gmail.com>
 <CAB+yDaZFZhku34wp-t_i32Vy6cYB9fnS0iboPnQZ26sQeAZ+Uw@mail.gmail.com>
 <2f2047ca-a96f-91da-c746-530c7b8d1bbf@oracle.com> <CAB+yDaZFVpRGW8X_eN=0pEeujn6VX13kxRZSf-Sse_GrjcCQKA@mail.gmail.com>
 <d77a3fd9-ecda-1bf6-b4c9-60abdacd445a@oracle.com>
From:   shankarapailoor <shankarapailoor@gmail.com>
Date:   Mon, 4 Jun 2018 13:22:37 -0700
Message-ID: <CAB+yDaYOtfZ-nfEdvkSh5Cvsw79ovTRzP8KfzcWc1E_tHn6YCA@mail.gmail.com>
Subject: Re: Slab out of bounds in setxattr
To:     Dave Kleikamp <dave.kleikamp@oracle.com>
Cc:     jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org
Content-Type: multipart/mixed; boundary="000000000000e0a8f8056dd6b146"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

--000000000000e0a8f8056dd6b146
Content-Type: text/plain; charset="UTF-8"

Hi Dave,

I've updated the patch accordingly.

Regards,
Shankara

On Mon, Jun 4, 2018 at 11:39 AM, Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
> On 06/04/2018 01:30 PM, shankarapailoor wrote:
>> Hi Dave,
>>
>> Attached is my proposed patch. It solves the problem as you suggest
>> and I don't see the KASAN complaint.
>
> That looks good to me. Add a description and a Signed-off-by: and I'll
> get it pushed upstream.
>
> Thanks for finding this.
>
> Shaggy
>
>>
>> Regards,
>> Shankara
>>
>> On Mon, Jun 4, 2018 at 11:24 AM, Dave Kleikamp <dave.kleikamp@oracle.com> wrote:
>>> On 06/01/2018 11:06 PM, shankarapailoor wrote:
>>>> Hi,
>>>>
>>>> Looking at the crash some more, it seems that if value_len > PAGE_SIZE
>>>> then e_buf->max_size is rounded up nearest page size [1]. If a new
>>>> attribute is added with value_len < e_buf->max_size - EA_SIZE(ea) then
>>>> no new space is allocated for the attiribute list [2] and this
>>>> triggers the KASAN slab out of bounds error. This is the case in the C
>>>> repro I provided.
>>>
>>> I see the problem. It looks like we should be calculating max_size
>>> earlier and using that to call kmalloc(). (xattr.c#496)
>>>
>>> Shaggy
>>>>
>>>>
>>>> 1. https://elixir.bootlin.com/linux/v4.17-rc7/source/fs/jfs/xattr.c#L501
>>>> 2. https://elixir.bootlin.com/linux/v4.17-rc7/source/fs/jfs/xattr.c#L723
>>>>
>>>> On Fri, Jun 1, 2018 at 1:52 PM, shankarapailoor
>>>> <shankarapailoor@gmail.com> wrote:
>>>>> Hi Dave et al,
>>>>>
>>>>> I have been fuzzing linux 4.17-rc4 with JFS using Syzkaller  KASAN:
>>>>> slab-out-of-bounds in jfs_xattr.
>>>>>
>>>>> Attached are my kernel configs and a C reproducer. In the first
>>>>> setxattr call it appears that length is much larger than the name. In
>>>>> __jfs_setxattr, I don't see where the length is checked against the
>>>>> actual value length.
>>>>>
>>>>> Regards,
>>>>> Shankara Pailoor


-- 
Regards,
Shankara Pailoor

--000000000000e0a8f8056dd6b146
Content-Type: application/octet-stream; name=jfspatch
Content-Disposition: attachment; filename=jfspatch
Content-Transfer-Encoding: base64
X-Attachment-Id: f_ji0pbqay0

ZGlmZiAtLWdpdCBhL2ZzL2pmcy94YXR0ci5jIGIvZnMvamZzL3hhdHRyLmMKaW5kZXggYzYwZjNk
My4uYTA5YzUyNiAxMDA2NDQKLS0tIGEvZnMvamZzL3hhdHRyLmMKKysrIGIvZnMvamZzL3hhdHRy
LmMKQEAgLTQ5MywxNCArNDkzLDE0IEBAIHN0YXRpYyBpbnQgZWFfZ2V0KHN0cnVjdCBpbm9kZSAq
aW5vZGUsIHN0cnVjdCBlYV9idWZmZXIgKmVhX2J1ZiwgaW50IG1pbl9zaXplKQogICAgICAgICAg
ICAgICAgICogVG8ga2VlcCB0aGUgcmVzdCBvZiB0aGUgY29kZSBzaW1wbGUuICBBbGxvY2F0ZSBh
CiAgICAgICAgICAgICAgICAgKiBjb250aWd1b3VzIGJ1ZmZlciB0byB3b3JrIHdpdGgKICAgICAg
ICAgICAgICAgICAqLwotICAgICAgICAgICAgICAgZWFfYnVmLT54YXR0ciA9IGttYWxsb2Moc2l6
ZSwgR0ZQX0tFUk5FTCk7CisgICAgICAgICAgICAgICBlYV9idWYtPm1heF9zaXplID0gKHNpemUg
KyBzYi0+c19ibG9ja3NpemUgLSAxKSAmCisgICAgICAgICAgICAgICAgICAgfihzYi0+c19ibG9j
a3NpemUgLSAxKTsKKworICAgICAgICAgICAgICAgZWFfYnVmLT54YXR0ciA9IGttYWxsb2MoZWFf
YnVmLT5tYXhfc2l6ZSwgR0ZQX0tFUk5FTCk7CiAgICAgICAgICAgICAgICBpZiAoZWFfYnVmLT54
YXR0ciA9PSBOVUxMKQogICAgICAgICAgICAgICAgICAgICAgICByZXR1cm4gLUVOT01FTTsKIAog
ICAgICAgICAgICAgICAgZWFfYnVmLT5mbGFnID0gRUFfTUFMTE9DOwotICAgICAgICAgICAgICAg
ZWFfYnVmLT5tYXhfc2l6ZSA9IChzaXplICsgc2ItPnNfYmxvY2tzaXplIC0gMSkgJgotICAgICAg
ICAgICAgICAgICAgIH4oc2ItPnNfYmxvY2tzaXplIC0gMSk7Ci0KICAgICAgICAgICAgICAgIGlm
IChlYV9zaXplID09IDApCiAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiAwOwo=
--000000000000e0a8f8056dd6b146--