Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp106748imm; Mon, 4 Jun 2018 13:57:52 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJpe9Wdk8/QnuaR/S0MWNma2vSDcPTNccxebA4xjT4VlxG87xd3IecJNlK0nm+g8z7PwXDs X-Received: by 2002:a17:902:b410:: with SMTP id x16-v6mr23486237plr.324.1528145872085; Mon, 04 Jun 2018 13:57:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528145872; cv=none; d=google.com; s=arc-20160816; b=ReCd38sxeY1EvRsBOsGojiXEi1c7T4agc9qjm6lYt6X1IhXPedwCvG8OqzEBBTkrx/ crewIEAGI6H04gH6gmwG2HUSJ+2vwtOlcFne2NcErZQ3EcsjufjwdsT3LuzRT3bj54qr 5mVZvWDAA8sIdhSfsJOoLB+AQ7JYFnI8KGbjZnv4DRC/tMpCJgg3c/DaOGf+4amVWYFL KowWSGa8Z8Szpa45rVZvx7XSX4qSk6tp5LWenvMXInNtyI4s3ocVG+iKkrkg2ZZgvdBr 6zs1OjZe9QWAqcnpMpDe5lrNCBmncjSZcHKMbhP5wrDrkhz24g8HZs3MD1Q4hAzxXYNV r8Tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from:arc-authentication-results; bh=8I48YqP1nic+dPb9wiXcZ4dC6Qgwla54zRYuOMmmWHA=; b=eCG+0fZVsTF7VrAY81qEugvmg0YyVmS4y+f8GBGIBwhiZGIsDeNGwp21kmkihZB6hZ RbzrEFCrxJf/bqxdjhjPQDQSutNIBWEDcdujPf9ebR6jvmtYq4o0mPUrGpfGdh6GuC/O DgJ+UfjHwTJkJyVX8wzXpTbXMhfwv3QVrNf7z7yqQC3annDZJo87Gg6UasAdVKD3bQId +PmMFv5WMsNvMPkAlK9bJw8eEfdrv5Gz5bSvrpOWdKJ5qvr/DNEta/IFiv5Op5xanXw5 CX52kLHuMo/4NLaQKNXkMP+KTSaILUP+di+YKLT9MJGb6QoClZ56GPFVRr79dkfyMAX2 zTaA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z8-v6si14739407pgp.259.2018.06.04.13.57.34; Mon, 04 Jun 2018 13:57:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751369AbeFDUzI (ORCPT + 99 others); Mon, 4 Jun 2018 16:55:08 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:49868 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751303AbeFDUzF (ORCPT ); Mon, 4 Jun 2018 16:55:05 -0400 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id w54KieM6005912 for ; Mon, 4 Jun 2018 16:55:04 -0400 Received: from e34.co.us.ibm.com (e34.co.us.ibm.com [32.97.110.152]) by mx0b-001b2d01.pphosted.com with ESMTP id 2jd89jky66-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 04 Jun 2018 16:55:04 -0400 Received: from localhost by e34.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 4 Jun 2018 14:55:03 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (9.17.130.20) by e34.co.us.ibm.com (192.168.1.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 4 Jun 2018 14:55:01 -0600 Received: from b03ledav001.gho.boulder.ibm.com (b03ledav001.gho.boulder.ibm.com [9.17.130.232]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id w54Kt0PT11731310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 4 Jun 2018 13:55:00 -0700 Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0DD726E04E; Mon, 4 Jun 2018 14:55:00 -0600 (MDT) Received: from b03ledav001.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 59CAB6E050; Mon, 4 Jun 2018 14:54:59 -0600 (MDT) Received: from sbct-3.pok.ibm.com (unknown [9.47.158.153]) by b03ledav001.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 4 Jun 2018 14:54:59 -0600 (MDT) From: Stefan Berger To: zohar@linux.vnet.ibm.com, paul@paul-moore.com, linux-integrity@vger.kernel.org, linux-audit@redhat.com Cc: sgrubb@redhat.com, linux-kernel@vger.kernel.org, Stefan Berger Subject: [PATCH v3 1/4] ima: Call audit_log_string() rather than logging it untrusted Date: Mon, 4 Jun 2018 16:54:52 -0400 X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180604205455.2325754-1-stefanb@linux.vnet.ibm.com> References: <20180604205455.2325754-1-stefanb@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 18060420-0016-0000-0000-000008E299CF X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00009129; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000265; SDB=6.01042340; UDB=6.00533730; IPR=6.00821470; MB=3.00021461; MTD=3.00000008; XFM=3.00000015; UTC=2018-06-04 20:55:02 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18060420-0017-0000-0000-00003F1933EA Message-Id: <20180604205455.2325754-2-stefanb@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-06-04_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806040238 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The parameters passed to this logging function are all provided by a privileged user and therefore we can call audit_log_string() rather than audit_log_untrustedstring(). Signed-off-by: Stefan Berger Suggested-by: Steve Grubb Acked-by: Paul Moore --- security/integrity/ima/ima_policy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/integrity/ima/ima_policy.c b/security/integrity/ima/ima_policy.c index 8bbc18eb07eb..1d00db19d167 100644 --- a/security/integrity/ima/ima_policy.c +++ b/security/integrity/ima/ima_policy.c @@ -634,7 +634,7 @@ static void ima_log_string_op(struct audit_buffer *ab, char *key, char *value, audit_log_format(ab, "%s<", key); else audit_log_format(ab, "%s=", key); - audit_log_untrustedstring(ab, value); + audit_log_string(ab, value); audit_log_format(ab, " "); } static void ima_log_string(struct audit_buffer *ab, char *key, char *value) -- 2.13.6