Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp279630imm; Mon, 4 Jun 2018 17:39:07 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJj19Q1li61zJY3ccNZOpgnfDxCSlQ07ypiaaDPvSTOUc1vVKn+a5zoGevFMfqcVL0Kq9hO X-Received: by 2002:a62:f0d:: with SMTP id x13-v6mr23377668pfi.100.1528159147083; Mon, 04 Jun 2018 17:39:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528159147; cv=none; d=google.com; s=arc-20160816; b=l9DVAzlaOej25JS99SXeEWJ5igbD+DTK3LO+mbCzhjrbap20KaEGigMZGypGOhBObN TXNR4ZRg4btL5c4QN7onqByDbZAeMfxXjmwQFiHLjNQL+6fnAdz95uvZF2h/JdVLTrA2 AkJSAfnu7o3DBLczXBtm3KSueirsqNJwR2dNFkbqkTXGQ7cHTXLOy0oYKb0c8NUDF+Ym +TUsFG5FFKLpnj5hb/bDzVuyE5TiBxl+xT/iqfEka5oZYzHy9nBTfiHMXd9AbU/lTBR2 +8UNcSi2MmkS1Ac2t9N4Cwtu1r0y/yqBVcCjNvuFjKj1wmhEYBTOHfFTIwZp2kB6/Y6Y Mcpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=KaBiKtRCQIl4GdPBXjTdZawZLqsHcLiE1JceSv8UbF4=; b=JDR9IN6FrQty1oZgM7eQgwnirfYQYaWo29/47gxPbvV6LLGXszvaPBfswZ8HkAzqhB FJzBFL3C/59XagnM1/qZisrpIlWA4DSYkRcqVdKyy2bqjSMt8QdTbWutJ5Ta3KjXCQUe KG879dwrXDG38s0Kiy1WBBUvjMkDp9p0LSI0LV4jHjJblcZkgnGCEhRN5dWXNhrDw6V5 CL+CuGILKmQUqcNNw9W4cKe7OXNBHrXirxQHKT8R/kuxpw/CDhzx0sZj5mmkxW9x36jW bbwezsZXLMC2PYiQdK/sYQtZpSNkDBl5bMGrtzJDYECNBynS7a5bAg8mRVkauOdvCfiv AQng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=JKxw2BuB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bb9-v6si8241897plb.305.2018.06.04.17.38.52; Mon, 04 Jun 2018 17:39:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=JKxw2BuB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751379AbeFEAi2 (ORCPT + 99 others); Mon, 4 Jun 2018 20:38:28 -0400 Received: from ozlabs.org ([203.11.71.1]:33699 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751046AbeFEAi0 (ORCPT ); Mon, 4 Jun 2018 20:38:26 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 410Cb36Zt0z9s1R; Tue, 5 Jun 2018 10:38:23 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1528159103; bh=GRpSCaJJKxnZT/Rd4EyD0uj72shpFp400hCasEu6PQg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=JKxw2BuBRn1weuq3g76Fnh3TjoIolK+PYXKE4ZI9Xi8SDnHInpY5HokRO8lvFiM+U MjY6eKcQkgnAUfC7jClJ7tXf8WbYIyqYilPXMkfXexBNx3xX7zUY5L04QiCGL6YwBq 82xrvbiEH65S6IudKKvteMMzlFMBDOrSkG5abFmNR5sem+sDXzpxB4TkOP0/DwyCJ5 KVX6t8SIOr4P8gZRzSHIQ69lNcq5YDItK5Y8ktqVExemYgTlaKLH9wLU2wNiADNlBr r0h1W56+gJEn2MmzhjsmL6ZKnENnAaiIXotejndgw6dOWBhIb+aGecpPYCy/1KzWyu rSAokXknLD7aw== Date: Tue, 5 Jun 2018 10:38:23 +1000 From: Stephen Rothwell To: "Darrick J. Wong" , David Chinner , linux-xfs@vger.kernel.org Cc: Linux-Next Mailing List , Linux Kernel Mailing List , Andreas Gruenbacher , Bob Peterson , Christoph Hellwig Subject: Re: linux-next: manual merge of the xfs tree with Linus' tree Message-ID: <20180605103823.2ce02805@canb.auug.org.au> In-Reply-To: <20180605103403.3e5b2c91@canb.auug.org.au> References: <20180605103403.3e5b2c91@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/X4xRD2gfPK5/0=N=lZZ8RQa"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/X4xRD2gfPK5/0=N=lZZ8RQa Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, On Tue, 5 Jun 2018 10:34:03 +1000 Stephen Rothwell w= rote: > > Today's linux-next merge of the xfs tree got a conflict in: >=20 > fs/gfs2/bmap.c >=20 > between commit: >=20 > 628e366df11c ("gfs2: Iomap cleanups and improvements") >=20 > from Linus' tree and commit: >=20 > 7ee66c03e40a ("iomap: move IOMAP_F_BOUNDARY to gfs2") >=20 > from the xfs tree. >=20 > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as far as linux-next is concerned, but any non trivial > conflicts should be mentioned to your upstream maintainer when your tree > is submitted for merging. You may also want to consider cooperating > with the maintainer of the conflicting tree to minimise any particularly > complex conflicts. Forgot the diff :-( --=20 Cheers, Stephen Rothwell diff --cc fs/gfs2/bmap.c index a7b586e02693,8efa6297e19c..000000000000 --- a/fs/gfs2/bmap.c +++ b/fs/gfs2/bmap.c @@@ -767,12 -680,13 +767,13 @@@ static void gfs2_stuffed_iomap(struct i sizeof(struct gfs2_dinode); iomap->offset =3D 0; iomap->length =3D i_size_read(inode); - iomap->type =3D IOMAP_MAPPED; - iomap->flags =3D IOMAP_F_DATA_INLINE; + iomap->type =3D IOMAP_INLINE; } =20 + #define IOMAP_F_GFS2_BOUNDARY IOMAP_F_PRIVATE +=20 /** - * gfs2_iomap_begin - Map blocks from an inode to disk blocks + * gfs2_iomap_get - Map blocks from an inode to disk blocks * @inode: The inode * @pos: Starting position in bytes * @length: Length to map, in bytes @@@ -838,20 -770,20 +839,20 @@@ static int gfs2_iomap_get(struct inode=20 if (*ptr =3D=3D 0) goto do_alloc; =20 - iomap->type =3D IOMAP_MAPPED; - iomap->addr =3D be64_to_cpu(*ptr) << inode->i_blkbits; + bh =3D mp->mp_bh[ip->i_height - 1]; + len =3D gfs2_extent_length(bh->b_data, bh->b_size, ptr, len, &eob); =20 - bh =3D mp.mp_bh[ip->i_height - 1]; - len =3D gfs2_extent_length(bh->b_data, bh->b_size, ptr, lend - lblock, &= eob); + iomap->addr =3D be64_to_cpu(*ptr) << inode->i_blkbits; + iomap->length =3D len << inode->i_blkbits; + iomap->type =3D IOMAP_MAPPED; + iomap->flags =3D IOMAP_F_MERGED; if (eob) - iomap->flags |=3D IOMAP_F_BOUNDARY; + iomap->flags |=3D IOMAP_F_GFS2_BOUNDARY; - iomap->length =3D (u64)len << inode->i_blkbits; =20 -out_release: - release_metapath(&mp); - bmap_unlock(ip, flags & IOMAP_WRITE); out: - trace_gfs2_iomap_end(ip, iomap, ret); + iomap->bdev =3D inode->i_sb->s_bdev; +unlock: + up_read(&ip->i_rw_mutex); return ret; =20 do_alloc: --Sig_/X4xRD2gfPK5/0=N=lZZ8RQa Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlsV238ACgkQAVBC80lX 0GyauwgAlVhiYB9DYApT38VM3the3KD3DvpIlv8BSa9hUCvNGWmb1AxyXVskmg55 n8gkLYVHifBor3kJ/8bJiN8ou6K1OxemowaKu6WX1vYvlt7gWIkoDHIGo7WCjbPP N7+kxv4sNjevQqyJ2fld0NOgWKJ1uC1g6yMtKRnGwyWZUWSEbzdNlxkywIlZSCd7 oTVWXYtvVxsTM7FHX3uNpmH/JPmGn4NB0WUBb3IB0orDKT520SSjVXXatVfBQN36 MG9rsCXhHHrLQ38hcZ5+mJzyy6Q2ibKuNALKXOh1plGFXDVWcSBHtp2YaOZarlsN rQQG6rllqhIDd7fEAZ6rbmWJVIYViA== =Srn3 -----END PGP SIGNATURE----- --Sig_/X4xRD2gfPK5/0=N=lZZ8RQa--