Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp338106imm; Mon, 4 Jun 2018 19:01:34 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJnFkC+SbSGLwkW/8pM2Wr0zWxIqhsRHHiT1+yhzexo5DE2IS6qRrMniwKmnCkxU/I6+Vav X-Received: by 2002:a62:cf44:: with SMTP id b65-v6mr10900086pfg.80.1528164094882; Mon, 04 Jun 2018 19:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528164094; cv=none; d=google.com; s=arc-20160816; b=mK/N8aIYegfRJK5lAgBKtwM9t48qIX514ooZQ/wRd5lsvgG3zQEfMVfxsPbNcB/F6B ltDLAzQdjkL9GXonytXpLbJIscp4UUUXQQo/fhv188vsx0m4vvn3yPaN+KR64STNevAW +JzgVJMSfOOs1Ea5YHB9G/M7W7oZ72S/20HawRLCljFKiXjKDDgQJA16kCe4C4cSLQ9k sAUYOsaIePd9vE+d6hUva1M+1c41Zkkfd7Zw3t0SMBh9fPN4iCY6fMaKOzeRT6f+K24q qzGnKlUghcGgV8C0HdlU2N3Cm+cLEeKHz7S/c6rTZ7U/I2s9n6oyjliWHWF1Iyn9VXVN vXtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:date:message-id:subject:mime-version :content-transfer-encoding:from:dkim-signature :arc-authentication-results; bh=oW8Gv5seR46hc5COrv5rk+v/WwbYWDUGLgkn4d7WRkc=; b=AzVq9gG8UnAKZmUObKQoA6y/WPepTp8Lrn2AWCSUgahmayuKUQxXJQGphUmG/rjoF5 yWdfAWLFK/q7yBX1+7AsMzONWWD2GW+P9XJrS5ZdxBYHZEr9926mTVtrfISlDIypT3cQ WCtsRoYkjVfYJN2iRY8TxsZ69dSgyLjrcAcDbUM6MoEhRVuHLknqo3mSJhtacSomeH2b 5xuxGamichKJHMRD7vbAaVHW6NK3fJsKBaKUfddEUchHLJXRUjZCchCYTS5cwlCGh82G T5MafttUdgKjjEKewq9dVmr9foUg3SVAAEkGwyMevf/ePkNm/dNjTjqu1gpX6G4z6GDD J9Mg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UNoCYDJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14-v6si23872508pls.479.2018.06.04.19.01.20; Mon, 04 Jun 2018 19:01:34 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=UNoCYDJV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbeFECAx (ORCPT + 99 others); Mon, 4 Jun 2018 22:00:53 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:41321 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751297AbeFECAv (ORCPT ); Mon, 4 Jun 2018 22:00:51 -0400 Received: by mail-wr0-f196.google.com with SMTP id h10-v6so587888wrq.8 for ; Mon, 04 Jun 2018 19:00:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:content-transfer-encoding:mime-version:subject:message-id:date :to; bh=oW8Gv5seR46hc5COrv5rk+v/WwbYWDUGLgkn4d7WRkc=; b=UNoCYDJVd1dcQqYn4mDsXNdEOp6OqHL9pbqleJycnzFo3su0d7cyqxUyZwXH2eohRf hv+yV8GWiyCNRB6BBC2xkv8bqDFSkEXbEwwUsYK/6/U7BmW0Go/PKACxArjThsVXIeZV EZg1Qgx8RwEKZWgEdbZhZ0RiJ14MQwRC9sG3lR+DBsw8D4lZN7XIYsUcavHos8JARL/k j6+fee3yIe1Gd7GrAonE8Taet1jJsR9ylQmQh+nq5PuU+PtQYuhOg0U78saVEkDPxtaB icVCIYrJ0Es77nSVxk9dk/d4kTLA2T6IT+Mvh5uNWyPqtW1OdtCppqStI/kYPRdYZ0VS qxeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:content-transfer-encoding:mime-version :subject:message-id:date:to; bh=oW8Gv5seR46hc5COrv5rk+v/WwbYWDUGLgkn4d7WRkc=; b=tGEs59RJXlNoERMuD/CFkjp4zJZbwvSfZeN5Kwk9rUpjKkux1mWZfVTSbLo0++edR8 KJChF7HLEFFPH0gDf+KbFiQQnNScWIdBdaW+LF6xSZTdnEd2FMZNi1x+9LcAk+a1C9ap pi1WbNIvVgAB1/m7FCiL/v9MYltxp8KJDaH6eKjNLviCmjgjcFLr2bkQziUaE0SYUvSX QMMWqpA1FcacgaznNZ0lVNQl75QrVtgQ+7gydv6j+Ai+1/HO+FqhP/S5aM4Xf778oOzp 5D1VZReworKrT6er5vsWINh4oizXsvyK527yASBgnrsAFNS0siMc9iPwOd42t+6ObW1+ 51fQ== X-Gm-Message-State: ALKqPwf2cobjeXcacQZ2D0ZB8cj4gB68Sj35VAq0hWvXlvgluOPneWT5 LQruvWeOZoirPVnr0vieewSSgInk X-Received: by 2002:adf:e48e:: with SMTP id i14-v6mr19503214wrm.8.1528164050526; Mon, 04 Jun 2018 19:00:50 -0700 (PDT) Received: from [192.168.1.103] ([94.207.77.202]) by smtp.gmail.com with ESMTPSA id i76-v6sm451292wmd.20.2018.06.04.19.00.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Jun 2018 19:00:49 -0700 (PDT) From: Ilya Matveychikov Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.18\)) Subject: [PATCH] ksys_mount: check for permissions before resource allocation Message-Id: Date: Tue, 5 Jun 2018 06:00:47 +0400 To: linux-kernel@vger.kernel.org X-Mailer: Apple Mail (2.3445.6.18) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Early check for mount permissions prevents possible allocation of 3 pages from kmalloc() pool by unpriveledged user which can be used for spraying the kernel heap. Signed-off-by: Ilya V. Matveychikov --- fs/namespace.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/namespace.c b/fs/namespace.c index 5f75969adff1..1ef8feb2de2a 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -3046,6 +3046,9 @@ int ksys_mount(char __user *dev_name, char __user = *dir_name, char __user *type, char *kernel_dev; void *options; + if (!may_mount()) + return -EPERM; + kernel_type =3D copy_mount_string(type); ret =3D PTR_ERR(kernel_type); if (IS_ERR(kernel_type)) -- 2.17.0