Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp583677imm; Tue, 5 Jun 2018 00:43:18 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLG1mBAEKT6EAzSkVB8QRskfk5GwzxnkCMwgHhRwFO/6T9T1/dCjLNvJlp3/g6txbjJsrlG X-Received: by 2002:a63:43c6:: with SMTP id q189-v6mr20500720pga.123.1528184598720; Tue, 05 Jun 2018 00:43:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528184598; cv=none; d=google.com; s=arc-20160816; b=hEdwQHK9dDz0SuyehHMf+YjbrbIRO+oYmxoQGFHvHJLeKCR0HAuVKZXrrxRYgdYnv+ zugJa7praPAhXcNoGlUSadVGfVZ2wzUMbgytA4zKXDctGYgfhV9WyV1eYkE7BCm11P5t I9B0qoqtjC4Qmx5A/7iwFpOnEPvSL33hZoETjJlX+ad45nBzNGfpmaqg0aMwOgY7wqVd VwsAHrTy5wmSwWxX5vGxEz8WmNh++Q1PNCo+inHfAxTFIfjbnIYUmKzTZokesSkSRgaY Qd4hpLPI+tineLxcok+FGOAlJB5KmfOPvdkomCJu6uKYLNz83v2KquwA+KbgnXWBGUDE dp+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :arc-authentication-results; bh=vDArssHS5nrhZJ7cgiYoWak8Pw2QeH2c3O050AjkbqE=; b=EMF/amj2Jdr3E6PZgJTrxNMUoB2x59QOKBS5pE5BdJ3RlS0FF2UPVHzU2UWOwOUw/5 oxo6UbfQYkSyDWTzhHKOfz47+bTRlZqCgW0poIj4/AuiZYZxb/8ve3wdaZOUjmlCQ9d7 AQQPGbWV+YTzTWEl6lddWawQOxLHGAopr0xjgUtidzQldy9fqaH0nHDqv5tQOAUpTGby D6KQT0mUjem8PG40rhGmFE7mth23eFYB61O1AkaqHuJSZVbsEWnAX1dEC+2FAp/xf67b VTj4I8gAZ155ERKPt1X+NVUHyjUkocsLQ7tCA/ZDPtbd4KZ1T3Zv3xbpEI9bQyqgobyx BpUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n10-v6si9959736pgs.485.2018.06.05.00.43.04; Tue, 05 Jun 2018 00:43:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbeFEHlF (ORCPT + 99 others); Tue, 5 Jun 2018 03:41:05 -0400 Received: from mga11.intel.com ([192.55.52.93]:14303 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751499AbeFEHlD (ORCPT ); Tue, 5 Jun 2018 03:41:03 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2018 00:41:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,478,1520924400"; d="scan'208";a="56617025" Received: from debian.sh.intel.com ([10.67.104.203]) by orsmga003.jf.intel.com with ESMTP; 05 Jun 2018 00:41:01 -0700 From: Tiwei Bie To: mst@redhat.com, jasowang@redhat.com, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Cc: wexu@redhat.com, jfreimann@redhat.com, tiwei.bie@intel.com Subject: [RFC v6 0/5] virtio: support packed ring Date: Tue, 5 Jun 2018 15:40:41 +0800 Message-Id: <20180605074046.20709-1-tiwei.bie@intel.com> X-Mailer: git-send-email 2.17.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello everyone, This RFC implements packed ring support in virtio driver. Some functional tests have been done with Jason's packed ring implementation in vhost (RFC v5): https://lwn.net/Articles/755862/ Both of ping and netperf worked as expected. TODO: - Refinements (for code and commit log); - More tests and bug fixes if any; - Send the formal patch set; RFC v5 -> RFC v6: - Avoid tracking addr/len/flags when DMA API isn't used (MST/Jason); - Define wrap counter as bool (Jason); - Use ALIGN() in vring_init_packed() (Jason); - Avoid using pointer to track `next` in detach_buf_packed() (Jason); - Add comments for barriers (Jason); - Don't enable RING_PACKED on ccw for now (noticed by Jason); - Refine the memory barrier in virtqueue_poll(); - Add a missing memory barrier in virtqueue_enable_cb_delayed_packed(); - Remove the hacks in virtqueue_enable_cb_prepare_packed(); RFC v4 -> RFC v5: - Save DMA addr, etc in desc state (Jason); - Track used wrap counter; RFC v3 -> RFC v4: - Make ID allocation support out-of-order (Jason); - Various fixes for EVENT_IDX support; RFC v2 -> RFC v3: - Split into small patches (Jason); - Add helper virtqueue_use_indirect() (Jason); - Just set id for the last descriptor of a list (Jason); - Calculate the prev in virtqueue_add_packed() (Jason); - Fix/improve desc suppression code (Jason/MST); - Refine the code layout for XXX_split/packed and wrappers (MST); - Fix the comments and API in uapi (MST); - Remove the BUG_ON() for indirect (Jason); - Some other refinements and bug fixes; RFC v1 -> RFC v2: - Add indirect descriptor support - compile test only; - Add event suppression supprt - compile test only; - Move vring_packed_init() out of uapi (Jason, MST); - Merge two loops into one in virtqueue_add_packed() (Jason); - Split vring_unmap_one() for packed ring and split ring (Jason); - Avoid using '%' operator (Jason); - Rename free_head -> next_avail_idx (Jason); - Add comments for virtio_wmb() in virtqueue_add_packed() (Jason); - Some other refinements and bug fixes; Thanks! Tiwei Bie (5): virtio: add packed ring definitions virtio_ring: support creating packed ring virtio_ring: add packed ring support virtio_ring: add event idx support in packed ring virtio_ring: enable packed ring drivers/s390/virtio/virtio_ccw.c | 8 + drivers/virtio/virtio_ring.c | 1361 ++++++++++++++++++++++------ include/linux/virtio_ring.h | 8 +- include/uapi/linux/virtio_config.h | 5 +- include/uapi/linux/virtio_ring.h | 36 + 5 files changed, 1141 insertions(+), 277 deletions(-) -- 2.17.0