Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20180605114056.1239571-1-arnd@arndb.de>
In-Reply-To: <20180605114056.1239571-1-arnd@arndb.de>
From:   =?UTF-8?B?RWNrbCwgTcOhdMOp?= <ecklm94@gmail.com>
Date:   Tue, 5 Jun 2018 16:42:27 +0200
Message-ID: <CAPFYX+KmWcO390JP_UbkyuBZWvcxZ9ym=w=T=mA+anazGPOw-A@mail.gmail.com>
Subject: Re: [PATCH] netfilter: provide udp*_lib_lookup for nf_tproxy
To:     arnd@arndb.de
Cc:     pablo@netfilter.org, davem@davemloft.net, kuznet@ms2.inr.ac.ru,
        yoshfuji@linux-ipv6.org, pabeni@redhat.com, willemb@google.com,
        edumazet@google.com, dsahern@gmail.com, kafai@fb.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Arnd Bergmann <arnd@arndb.de> ezt =C3=ADrta (id=C5=91pont: 2018. j=C3=BAn. =
5., K, 13:41):
>
> It is now possible to enable the libified nf_tproxy modules without
> also enabling NETFILTER_XT_TARGET_TPROXY, which throws off the
> ifdef logic in the udp core code:
>
> net/ipv6/netfilter/nf_tproxy_ipv6.o: In function `nf_tproxy_get_sock_v6':
> nf_tproxy_ipv6.c:(.text+0x1a8): undefined reference to `udp6_lib_lookup'
> net/ipv4/netfilter/nf_tproxy_ipv4.o: In function `nf_tproxy_get_sock_v4':
> nf_tproxy_ipv4.c:(.text+0x3d0): undefined reference to `udp4_lib_lookup'
>
> We can actually simplify the conditions now to provide the two functions
> exactly when they are needed.
>
> Fixes: 45ca4e0cf273 ("netfilter: Libify xt_TPROXY")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: M=C3=A1t=C3=A9 Eckl <ecklm94@gmail.com>