Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1050456imm; Tue, 5 Jun 2018 08:22:48 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIuHqCDq5H1gU2byIFa9uNVq52HormyDi7Thwbs4tz/vUq1YZXxhtI2mJP41vQfW3gwuRkA X-Received: by 2002:aa7:80c6:: with SMTP id a6-v6mr25900899pfn.120.1528212167992; Tue, 05 Jun 2018 08:22:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528212167; cv=none; d=google.com; s=arc-20160816; b=JKZKz4bcMshIrB0oh+aaoDvuh3hgQZGWMIu09aK4vE3dmMmL6SjTsJfmsWGoL/u3ID oWA5izoGKi93YQhgWH/GQoDr1C/x2pQ4hon5HwjWVlyfK15fl1C8NmTXk8PlwjsAD/fg 9pwSbKGmaS+ZA4EplQXrifc0+c1OmtWDc5XL862NiMS4B8WyWcDAqSCoFuz5l5xg1l7/ d8j0ruZIT0werwWqEES+7hx1/PmRBbxcLSKuzgcWojxRt10zzbqbWE8MWguAqeKXzrgn XwL2sJMIj5wi6qSmRTSRUkVyeAL/ZCFbeWNeuzBNRY6M4iJKCV5myGF+u8Hc+t9yg83f c54Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature :arc-authentication-results; bh=kZ4yXFYVWWL/pikt4EvMe2noLgYvujmogSqljNrwDuM=; b=LeAPoNPpA+S2K7ZgCCrvkT9ec7FLjoeFFnb4lf1py88aAnKeK7Pb8QvXkhK2HK92xJ TZ9PXNw2CGW8wK5BVL5cunweiJxODb80/6XeKyS8MO0qwc6FXJ3BKMVQRFXWN+7pgjab oSpuCX50oLJVp8opuwOrY9Fyj4v/I2XvpKgdR0x30rbzdklLK4oJ3NwBObu26SpjjifT m/GtqFA897s3kVZtCtlyb2jtuxqS4AuAp0PCKfbmexq98l4W0RBTUG9hczhM/fkhdbRR DpulIEY2cwbqVFjl738zfWDoU5FTvCHKX01R64nRYq6kKO+IG5+8I7qB0Q/wi8ykW1xc c0nA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VuEWuDpf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 126-v6si8076340pgi.254.2018.06.05.08.22.33; Tue, 05 Jun 2018 08:22:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=VuEWuDpf; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752164AbeFEPUV (ORCPT + 99 others); Tue, 5 Jun 2018 11:20:21 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:51580 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751726AbeFEPUS (ORCPT ); Tue, 5 Jun 2018 11:20:18 -0400 Received: by mail-it0-f47.google.com with SMTP id n7-v6so3895704itn.1 for ; Tue, 05 Jun 2018 08:20:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kZ4yXFYVWWL/pikt4EvMe2noLgYvujmogSqljNrwDuM=; b=VuEWuDpf1f2yfmbyMEfrJ4p58hNBXYfP/g0h49fXd8Hvg3hDTOJtSMzuZgiIVXnG+b vuBizxNWkWU3xwj7zdhYMgyuHIJAt4ejPmac2KqHgKlFmDdGukIBT+Ft4ONeMVSagqhy 5z4mTl7CsDvNXjVfapEpHZng1TsWNPqpK4MEd3tkUo5H/9EqK9HuxOe283NuqwwRAU4C vzgeFAUA8iY2mqDbrSeGTRmexCwHuKVN6iV8T2D8F70qXWHgFlLgl2Du7FQIT8HjqbDN MBsWl9SUpmrm9mLINZU0qIUY7nhNnC/vwi1kuZas4CAjtNF4guOGXTqL/mrjK3iLz1vF Vuxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kZ4yXFYVWWL/pikt4EvMe2noLgYvujmogSqljNrwDuM=; b=T1B95TEppFDnmnQAt0OhT35siifCZ8RcBp17WQ/S3z014xj/w2O1rGiPXSUECANXAq 85lFU31Yr/kz1M2EIofiFCsblBFabp+BOkCS6RWIpus5EMzRk2EPYtz5ArRsDRnU7gI+ hgQ/AzqSJOrRpLtB0E5tW6GCFOi+kAUJDoPgJUqXdR6SHbVKNz9tby7B5E7oXHbZoRC7 mqR4mBoPL7sdBfJQm9hoU4l5RrtXCNleXpMXWxV38QihTrDUGDZRRB50R+Gl7AbXd5+S 3MwbTAE/BYBpXZM4UgRSKYdqCPCe2E2kcGcFVl8QcMoQth5BDSCrdsH9fPVrQdjeZn0e 554w== X-Gm-Message-State: APt69E0V9eaPkG7y9oj6YTxLNzDOvz1NRebIapaaU1d6vCCeLYMH+xx6 nVSFnBuk0kOJcFS35O1AfzoqCsEziU0= X-Received: by 2002:a24:ad22:: with SMTP id c34-v6mr20497109itf.75.1528212017384; Tue, 05 Jun 2018 08:20:17 -0700 (PDT) Received: from [192.168.1.167] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id b128-v6sm878454itb.3.2018.06.05.08.20.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jun 2018 08:20:15 -0700 (PDT) Subject: Re: [PATCH][next] lightnvm: pblk: fix resource leak of invalid_bitmap To: Colin King , Matias Bjorling , linux-block@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20180605151456.20359-1-colin.king@canonical.com> From: Jens Axboe Message-ID: <5b0a3b83-5e7d-679e-f2a4-a9305da7c472@kernel.dk> Date: Tue, 5 Jun 2018 09:20:14 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: <20180605151456.20359-1-colin.king@canonical.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/5/18 9:14 AM, Colin King wrote: > From: Colin Ian King > > Currently the error exit path when the emeta could not be > interpreted is via fail_free_ws and this fails to free > invalid_bitmap. Fix this by adding another exit label and > exiting via this to kfree invalid_bitmap. > > Detected by CoverityScan, CID#1469659 ("Resource leak") Looks good, applied. -- Jens Axboe