Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1098450imm; Tue, 5 Jun 2018 09:03:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJZWx9hJlrK4pz0hSOPqQcjutSKVp2YcIZWMK8Y1MCwRL/gBUH9fPEN6+0DOtovnQnSAGgF X-Received: by 2002:a62:1855:: with SMTP id 82-v6mr12515847pfy.132.1528214636219; Tue, 05 Jun 2018 09:03:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528214636; cv=none; d=google.com; s=arc-20160816; b=o/XGGnkMBsZsUqyhvsdxhUv+U8UrJmHp02/KchhR/D5XTAyAk4VtjVBxLTI8SfkxRL jJf4zNyt2UQuEjxe/aeWzlWXH5/nQZiL1NIp2XujVA/I6gASxiPqCqdu+khnmcVTUuf9 5S2dyIbeOB0Ptk6n5OpdkXCBTefr0hQQCmlSjPwmUWSCoNejsUxowz4cK76P4uazCf5r vhHDTV+PkmW6i0h1sgaMt3I9wzKEhPFmx2sm5F3iqGaobSeaFybu9p498ZEnZBld53Sb scS2ZJXYRlQPKxqoNjenAgk9MB/1NON252rUz+zD16jlzzgNxV749aG3ohFWkkidfMw4 GtJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:arc-authentication-results; bh=6ecAZzKIQ76wGj4GyN34XiBViL7FAwCPIxxsyvXhdT0=; b=MiWcDApZ5GQkDDqG2KAh7/0aK+NgFMEtAZpUQgiq0m2rWpBB0uwZKMeM6AzOWdJVlM vZmKMNxvhSGpJEbrmQ8wUJN2Bg+N0VOXjCHLMF+NrG9YbdthaJX0JlBiRaX/g8zZlyK7 ssisTiFvbD6cXnq8EGsmGrPwEHNARXA+CyTYmcUPCrkJkOPsaZcGCjgScPyOG9MZj4Kn KxdVnl+9xPgxWIX6HteXT7nFrRN+zhrpoBNwGDG9Gpxx3V+I3FCZWpYS7DkKmqGsHRjx qUGgiy0iW6pJlxjs+YS+U3iYTme53HyYH7SceJWm/VbBLqykKqxkl6ItnBlAc8htEZra +1Gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r28-v6si21138596pgu.408.2018.06.05.09.03.29; Tue, 05 Jun 2018 09:03:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbeFEQCp (ORCPT + 99 others); Tue, 5 Jun 2018 12:02:45 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35875 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751745AbeFEQCo (ORCPT ); Tue, 5 Jun 2018 12:02:44 -0400 Received: by mail-wm0-f65.google.com with SMTP id v131-v6so6166749wma.1; Tue, 05 Jun 2018 09:02:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6ecAZzKIQ76wGj4GyN34XiBViL7FAwCPIxxsyvXhdT0=; b=r6R5hCBZLNcZ4fgkcKZSB/SgzH3N1+LhgVa23YuMGzxa43QjiBfigpZ1KMf4el46Y5 zNGqzUjh4jT+xJLuBOufBS4I3iVpB1d9MAhQA0L7n1K3EM2Fh/i7wCt5iU7ccTaWTWxd EPHCqiFAiAE3pQVpFPsdDmjbc2eKB6OqIlEpuIFwpCZAma5EWPh6YSLNyAQBgUmVzCSd kUVE8+1YCHsC9COLaaDE6KjEoRLuYWXgdRusDrQEyvfL0+3D7GEpT/Go8fCsFkOV4qWp PYhxs1RIhga8FxrcTL9jNSt3ljTOdwsig37ATOIgfz/RiVzhuCBWFt+DsY/mx3Y+p6T2 9e/g== X-Gm-Message-State: ALKqPwdmrvhEugVdcVhUYXRkpMbXXhwgmyaVdJXmYZQ+MP++9oYRdFfC T2tgwXTshnZLmo37CcONqNU2Iu1A X-Received: by 2002:a50:9007:: with SMTP id b7-v6mr29069523eda.279.1528214562817; Tue, 05 Jun 2018 09:02:42 -0700 (PDT) Received: from mail-wr0-f177.google.com (mail-wr0-f177.google.com. [209.85.128.177]) by smtp.gmail.com with ESMTPSA id a2-v6sm30340604edd.39.2018.06.05.09.02.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Jun 2018 09:02:41 -0700 (PDT) Received: by mail-wr0-f177.google.com with SMTP id l41-v6so3014497wre.7; Tue, 05 Jun 2018 09:02:41 -0700 (PDT) X-Received: by 2002:adf:8406:: with SMTP id 6-v6mr19877034wrf.105.1528214561465; Tue, 05 Jun 2018 09:02:41 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:adf:a158:0:0:0:0:0 with HTTP; Tue, 5 Jun 2018 09:02:20 -0700 (PDT) In-Reply-To: <20180605071139.osu2pgpg3ychdxln@flea> References: <20180601151701.sshwfdbflic6mybv@flea> <20180605071139.osu2pgpg3ychdxln@flea> From: Chen-Yu Tsai Date: Wed, 6 Jun 2018 00:02:20 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V2 2/2] arm: dts: sunxi: Add missing cooling device properties for CPUs To: Maxime Ripard Cc: Viresh Kumar , arm-soc , Rob Herring , Mark Rutland , Vincent Guittot , ionela.voinescu@arm.com, Daniel Lezcano , chris.redpath@arm.com, devicetree , linux-arm-kernel , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 5, 2018 at 3:11 PM, Maxime Ripard wrote: > On Tue, Jun 05, 2018 at 10:17:49AM +0530, Viresh Kumar wrote: >> The cooling device properties, like "#cooling-cells" and >> "dynamic-power-coefficient", should either be present for all the CPUs >> of a cluster or none. If these are present only for a subset of CPUs of >> a cluster then things will start falling apart as soon as the CPUs are >> brought online in a different order. For example, this will happen >> because the operating system looks for such properties in the CPU node >> it is trying to bring up, so that it can register a cooling device. >> >> Add such missing properties. >> >> Fix other missing properties (clocks, OPP, clock latency) as well to >> make it all work. >> >> Signed-off-by: Viresh Kumar > > Applied both, thanks! Please fix the "ARM" prefix when applying. :) ChenYu