Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1189311imm; Tue, 5 Jun 2018 10:23:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIepuB+t4OJVt3NOoMWfI9KW8WsSz1ZZ0JjEhQ3xyqijiYkT54BPC5pI/3IARNvAOIQ6+kK X-Received: by 2002:a65:510c:: with SMTP id f12-v6mr9657169pgq.288.1528219433789; Tue, 05 Jun 2018 10:23:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528219433; cv=none; d=google.com; s=arc-20160816; b=lzT7/cbmn1gt4UDwTiC8j76GEK8Hb+DlN1+/ZJvbQIYMMQs7BpuSIJrvOQ0bkorh+u Dd9KxKTCVO602MxrvlvI4UvNIIawlML/z7gDbQ1/2zSU3UvAQ1RtuM+B67ElELnmlPUG noHe7oWDQeDhFRGGDFezdKn+mdRbBqsIFjf9b7eTbASmzcgE0Bg21IGKiK4WgB9OypfJ dJj3lYOh+dPKCr6LLMa+9ZNwIlaTSmuzDWN6HSz+C6MxRvC2B2d0OSCeYRnuQiugLiwu G+yKXVt9rKjzVA9PzzhMXT+PV6LBRZQYsLt06FZ4sRZc3gJGOH1c61YNOLPmCMmGFHZ0 s6TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:feedback-id:mime-version:user-agent :references:message-id:in-reply-to:subject:cc:to:from:date :dkim-signature:arc-authentication-results; bh=C/ZUK7uPhV8pExZOmbA7H0yBkXFbNyjl5awvIagndms=; b=EBq9sUmIw8eB7s7jipLPSaSUB3e3DEvQsDLzjbZz1w6kncp0hqsaLborBqShfHcMNB goQ/Su7z0OSUnLLs19AZ+yGb3aJm4KTLDDV76XenLcueg9vw80HqjR9h7OVABPDDyGJa s3XGRnuYVwlEKibD8VswjrXQ5bMqO7YCAYkFPsYr+5/Lngrqv79qOgLLZrX7jNVcja/C edTsEJggUeKoPZE34R2MocO5TSXNLsvGzfiIwSPTewlxlJbbq/VPzq/E6YJQ1Aj+Y7Yb d1FsCb/FjvHfPAWKtWH4tLBezgP0V0it38RcTBhuHsXlJ2vpUoAqfgAEA2RepzYVovmP 4ZQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=QiWDbTbb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f34-v6si47401866ple.52.2018.06.05.10.23.39; Tue, 05 Jun 2018 10:23:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amazonses.com header.s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug header.b=QiWDbTbb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752934AbeFEREX (ORCPT + 99 others); Tue, 5 Jun 2018 13:04:23 -0400 Received: from a9-114.smtp-out.amazonses.com ([54.240.9.114]:59586 "EHLO a9-114.smtp-out.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752880AbeFEREU (ORCPT ); Tue, 5 Jun 2018 13:04:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ug7nbtf4gccmlpwj322ax3p6ow6yfsug; d=amazonses.com; t=1528218257; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:MIME-Version:Content-Type:Feedback-ID; bh=nl01hhvfQWFX1IE/TqAHi4LVaHeY+KozdXm7Y9d32kE=; b=QiWDbTbbcPI87hnRiOOPqIpsRCQTnUTTeJYzkmK/lEux12ON/oblkChnfmjmh5f7 poGiEw48ps0/3D9yFR2+Ww0zF/cZEzQWUmS93zAM3RMpYtCnEtN7Rtt1xBHJ0tnslki 0gd7MjX2fQHfvWgjuI3q4vGqduVrkAaL6MAm1ciI= Date: Tue, 5 Jun 2018 17:04:17 +0000 From: Christopher Lameter X-X-Sender: cl@nuc-kabylake To: Baoquan He cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org Subject: Re: [PATCH] slab: Clean up the code comment in slab kmem_cache struct In-Reply-To: <20180603032402.27526-1-bhe@redhat.com> Message-ID: <01000163d0e8083c-096b06d6-7202-4ce2-b41c-0f33784afcda-000000@email.amazonses.com> References: <20180603032402.27526-1-bhe@redhat.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-SES-Outgoing: 2018.06.05-54.240.9.114 Feedback-ID: 1.us-east-1.fQZZZ0Xtj2+TD7V5apTT/NrT6QKuPgzCT/IC7XYgDKI=:AmazonSES Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Jun 2018, Baoquan He wrote: > diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h > index d9228e4d0320..3485c58cfd1c 100644 > --- a/include/linux/slab_def.h > +++ b/include/linux/slab_def.h > @@ -67,9 +67,10 @@ struct kmem_cache { > > /* > * If debugging is enabled, then the allocator can add additional > - * fields and/or padding to every object. size contains the total > - * object size including these internal fields, the following two > - * variables contain the offset to the user object and its size. > + * fields and/or padding to every object. 'size' contains the total > + * object size including these internal fields, while 'obj_offset' > + * and 'object_size' contain the offset to the user object and its > + * size. > */ > int obj_offset; > #endif /* CONFIG_DEBUG_SLAB */ > Wish we had some more consistent naming. object_size and obj_offset??? And the fields better be as close together as possible. Acked-by: Christoph Lameter