Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1227844imm; Tue, 5 Jun 2018 11:01:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKprSDOuo+unZHIDaGIDR9mwOPOGGC1fGaO1FoFs+K3Ruep7CRPzWp7xT7rVuD1C2CfsWDQ X-Received: by 2002:a17:902:7888:: with SMTP id q8-v6mr12649741pll.79.1528221668539; Tue, 05 Jun 2018 11:01:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528221668; cv=none; d=google.com; s=arc-20160816; b=pgB1omxeCRnDSpajGiCrB9yDx7zWZDZQSDyDtUQG3pnxNMfePDFZ1lPA+25cR6jFyy 7liTJWNsJqpUwYSZKGY5QrGpoGBC9OcOn1wcTuGwLc6GiMyRpnZY907yO/TnYNRmwkcw gg9/ll4Vjp1D5B0r2NugW/+H1Rnd2vWJo4uTpCPYE9FwB1rd3iqI/nil+cV+Pkz3gVIk qQIes+RlkUOaXTJz4ws4KRjaLYm9p7mKcQB7PHHdUdD5fvEZeRLxympEPmAOW0z60F97 DhhdTFfAyUTUPXof2WUTk6Iou3sGuRtohQiNVRqSzP3GUL6f6h11IacDlNSPGJwUc4f8 DSBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=HdXrT94Y30K8NcSIY+4oD969cqY1GFPBlcuVpqlWa+c=; b=eUyRWLFLztBHatUqlsLF8+8ly8AzzYe8hWVEWi/p91indyRsSYghQzA7PeynxbIrb0 R++Mnl5uqqM1hodqPdtxpJLihyPofRI+Z6CV7PuI41cT823A5+XfDHnwZ443euNDSt63 utDNBHcCdQy9zvFiHc0tiaPdEOMKk5Hxfb8NKvzBWYlhfehPpGmWbrURjCgWRrGBO8Uo BOPFy54+n9ZvqEEB39jth5s93rxHqdDOGTD5+FhEVQKWpuLvTIRsOiyOhxGn98KmzU76 0jaVhDS4z065K2TYdonhg8gRiXq4iP6+p2BsxJ1iY8YaO+wE2SPA65QuO/EQS03LMX+o p/ew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W4WQMfBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y12-v6si48572124plt.233.2018.06.05.11.00.52; Tue, 05 Jun 2018 11:01:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W4WQMfBu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753109AbeFER7n (ORCPT + 99 others); Tue, 5 Jun 2018 13:59:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:46268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752709AbeFERwC (ORCPT ); Tue, 5 Jun 2018 13:52:02 -0400 Received: from jouet.infradead.org (unknown [179.97.41.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D7522077B; Tue, 5 Jun 2018 17:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528221121; bh=wFu9hubh6Hhs0ZU6wzL8Nj8atLgsgXnr2L0i7KRkRPc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W4WQMfBu2SB/t1PG8rEaVTWMDGrL16RvXbBgAEyGbXaiCgwFzPzGkH/WGGBxzah9o F5rz9b3xK4bXUUMQL3kJEiK7Xi+ZvUbzD00s5YMyEZUOpyd5tm08rprKdeBIyrGWQa AJQG+98irWFHDSjy7xT3Bpqel99GUUKq0ilIVMKs= From: Arnaldo Carvalho de Melo To: Ingo Molnar Cc: Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Arnaldo Carvalho de Melo , Adrian Hunter , David Ahern , Jiri Olsa , Namhyung Kim , Wang Nan Subject: [PATCH 27/46] perf report: No need to have report_callchain_help as a global Date: Tue, 5 Jun 2018 14:50:11 -0300 Message-Id: <20180605175030.32549-28-acme@kernel.org> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180605175030.32549-1-acme@kernel.org> References: <20180605175030.32549-1-acme@kernel.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnaldo Carvalho de Melo It is used in a single place, move the declaration to that function. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-p650ofrl8xike4dewxod51gg@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/builtin-report.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index bc133e7a7ac2..cdb5b6949832 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -946,12 +946,6 @@ parse_percent_limit(const struct option *opt, const char *str, return 0; } -#define CALLCHAIN_DEFAULT_OPT "graph,0.5,caller,function,percent" - -const char report_callchain_help[] = "Display call graph (stack chain/backtrace):\n\n" - CALLCHAIN_REPORT_HELP - "\n\t\t\t\tDefault: " CALLCHAIN_DEFAULT_OPT; - int cmd_report(int argc, const char **argv) { struct perf_session *session; @@ -960,6 +954,10 @@ int cmd_report(int argc, const char **argv) bool has_br_stack = false; int branch_mode = -1; bool branch_call_mode = false; +#define CALLCHAIN_DEFAULT_OPT "graph,0.5,caller,function,percent" + const char report_callchain_help[] = "Display call graph (stack chain/backtrace):\n\n" + CALLCHAIN_REPORT_HELP + "\n\t\t\t\tDefault: " CALLCHAIN_DEFAULT_OPT; char callchain_default_opt[] = CALLCHAIN_DEFAULT_OPT; const char * const report_usage[] = { "perf report []", -- 2.14.3