Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265589AbTIDV6v (ORCPT ); Thu, 4 Sep 2003 17:58:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265584AbTIDV6v (ORCPT ); Thu, 4 Sep 2003 17:58:51 -0400 Received: from mail.jlokier.co.uk ([81.29.64.88]:5517 "EHLO mail.jlokier.co.uk") by vger.kernel.org with ESMTP id S265591AbTIDV6n (ORCPT ); Thu, 4 Sep 2003 17:58:43 -0400 Date: Thu, 4 Sep 2003 22:58:14 +0100 From: Jamie Lokier To: Hugh Dickins Cc: Rusty Russell , Andrew Morton , Ingo Molnar , linux-kernel@vger.kernel.org, Linus Torvalds Subject: Re: [PATCH 2] Little fixes to previous futex patch Message-ID: <20030904215814.GH31590@mail.jlokier.co.uk> References: <20030904201133.GC31590@mail.jlokier.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 22 Hugh Dickins wrote: > You're right, the condition on clearing is fine. It's the (lack of > condition on) setting that's over-enthusiastic, should be saying: > > if (start - vma->vm_start != (pgoff - vma->vm_pgoff) << PAGE_SHIFT) > vma->vm_flags |= VM_NONLINEAR; I hadn't thought of that. I wonder if it's useful, though. The only time it's likely to not set the flag with it not already set, in real use, is when other VM code calls remap_file_pages() with the whole vma. But then the flag is cleared by the next line. So it's correct and nice, but I'm not sure it adds anything practical. -- Jamie - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/