Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1291396imm; Tue, 5 Jun 2018 12:04:17 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIMoaauP8Yo1WJQa2g4KfG6N8idGHznwuUjYc5m58SlPnAk7Jj64WmBKj4WdjmqYXaCp8Py X-Received: by 2002:a17:902:680c:: with SMTP id h12-v6mr28323085plk.113.1528225457543; Tue, 05 Jun 2018 12:04:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528225457; cv=none; d=google.com; s=arc-20160816; b=XNmHCnAiyVYRAqoGScwevSva0atFyn6kAA/Se4J2nx6XXyeDABvbTvFnm3rLaAr1eD kcCFZ+3/ZZoTjP66ITMparFl4VY3ODN9tLGPdDMFbykO5YRHEq/P+Cl4HtxcuHojIsnR cYOBoHLh/eDqRdSLL3fXAIhBo94AxUt4lw3HJ9I2jFLJrvCHO1s09FOWqbU0nN6RLyQT bSYnOVflf5HF1K95RVL7XiaXsSciq6py+wVr4KlKIxo9mq9pUT5ddJnpLWuOIxoXcHTe PoqcxCU3ZaLNuVSP8VVuDSXAGWMm3V/ERAizir9J68AT91vt7h3gHP29W16craHQ1cBW b+QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=/UhhNBf0e2ughNycXolcMFosTYQKZjWWuQ4l2ynv0lc=; b=G/Cay18bpSOIZ4JEi0MdaYpM9ecgka/h2DniYqZgzFNqRtDTc3ctl9VmXIb05ABqqr 2/Kyp1jZeqy7c7HFMiYh6hBHOPpuU33V/GzTF0SAc+oWaVBc7I1my9ajzzyU35L5Jmvf LuKbZjz+3+VSkKw7Cez8tX7q5KnBkIUCQb+lWBLfCb8M618k/70FF1mGZUt2boXFA5WF InUNobWLX8B3tLMW1XsIuLFW+bwinodZqNnsrGJ7l3bGwA8xJfddwGl0wZgopCy71L4x zYEc/Dn/515NEe6M1RgJdI8x3Ro6hqxRZZezh8U0+LOdxQA5t+7623iHqu2hAleCPCAa CW0w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b59-v6si49640914plc.335.2018.06.05.12.04.03; Tue, 05 Jun 2018 12:04:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752292AbeFETD3 (ORCPT + 99 others); Tue, 5 Jun 2018 15:03:29 -0400 Received: from anholt.net ([50.246.234.109]:40568 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752003AbeFETDH (ORCPT ); Tue, 5 Jun 2018 15:03:07 -0400 Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id D1C3510A1860; Tue, 5 Jun 2018 12:03:06 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at anholt.net Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id CQlkJ7XJThSu; Tue, 5 Jun 2018 12:03:05 -0700 (PDT) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id D287610A1642; Tue, 5 Jun 2018 12:03:03 -0700 (PDT) Received: by eliezer.anholt.net (Postfix, from userid 1000) id 0C8D32FE462E; Tue, 5 Jun 2018 12:03:03 -0700 (PDT) From: Eric Anholt To: dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org, Lucas Stach , amd-gfx@lists.freedesktop.org, Eric Anholt Subject: [PATCH 3/3] drm/v3d: Add a note about locking of v3d_fence_create(). Date: Tue, 5 Jun 2018 12:03:02 -0700 Message-Id: <20180605190302.18279-3-eric@anholt.net> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180605190302.18279-1-eric@anholt.net> References: <20180605190302.18279-1-eric@anholt.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This isn't the first time I've had to argue to myself why the '++' was safe. Signed-off-by: Eric Anholt --- drivers/gpu/drm/v3d/v3d_fence.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/v3d/v3d_fence.c b/drivers/gpu/drm/v3d/v3d_fence.c index bfe31a89668b..6265e9ab4a13 100644 --- a/drivers/gpu/drm/v3d/v3d_fence.c +++ b/drivers/gpu/drm/v3d/v3d_fence.c @@ -3,6 +3,9 @@ #include "v3d_drv.h" +/* Note that V3D fences are created during v3d_job_run(), so we're + * already implictly locked. + */ struct dma_fence *v3d_fence_create(struct v3d_dev *v3d, enum v3d_queue queue) { struct v3d_fence *fence; -- 2.17.0