Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1320944imm; Tue, 5 Jun 2018 12:36:20 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJnv1VtIM/EdeHilwrYJQ2+PkYv0JrJbzTndTcbo8dHOVY9X7cKwVB1fF7itDD7FpDN8y+C X-Received: by 2002:a17:902:7d09:: with SMTP id z9-v6mr14480971pll.233.1528227380739; Tue, 05 Jun 2018 12:36:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528227380; cv=none; d=google.com; s=arc-20160816; b=Ckd3tYwPXR0P4O06qPCqfyo8MfwpBGeKz909t2l/MN2yrQW+5piY8c/yQmHOpe8SIV 8ZoQdBxQZ+MU2sMtvDSvZuosJiFeyR4LRv0LicwFWjZcCazFRJUoas3jmuMvc3VGIY1+ aKJ5hrPmJ8cYqD5M+vSezlnTRnoF1ORBbgXH/IPMfvM/eYQ1pLQBsIMYuLaei58U+9Se or7otN8WiXB1QTllkUUPWMLLN9DkU8fdzd4xloxrew3PCSWIu9l/YoV6javRx6qhvsR7 GnI7AIPO/XYOwgWtv2h5W+OJ+nf0mL+q7wQ4PLh9UmoteiRCpeVK4smtiUXLC6aebHo8 AyJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:date:message-id :from:references:cc:to:subject:arc-authentication-results; bh=uKHe53FIJyxWSoxMML1XVHp+Eo8D4YJ64etffXDfL3k=; b=xZFgrDM5P4LCIv1cVTvr4sbcVGZJct/REP2nHjVOZ4UXzOevmtIHww8nQbr64yx13G K9Sl/va1BuZqOtSwe6rmKeKSJFax2WpZSAMRYgKPO0NmHlAHxguIGG1WzgLsv7gQP+I3 HlIU1vzN7p2F3n4kx2b4ZFol70M5G6J6pGRU2h/Ej6kpkBbNHYuZkj1wAUfc3KPPVuVX aIGVudVpFQT9qCGptPLt6ygyUr6wGpYvH+gbw7yJargSFypxoGeBhX+xJNgbM+QPE6Gj tYjQMViboJ2SIjcWgp6nqQ+UdR5L/YU7UgbpI1QbofTm+hoCXXbfkEe5Ja2nu4ibbPxO bMtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i11-v6si21472787pgc.350.2018.06.05.12.36.05; Tue, 05 Jun 2018 12:36:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751959AbeFETfc (ORCPT + 99 others); Tue, 5 Jun 2018 15:35:32 -0400 Received: from mx1.yrkesakademin.fi ([85.134.45.194]:52939 "EHLO mx1.yrkesakademin.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbeFETfb (ORCPT ); Tue, 5 Jun 2018 15:35:31 -0400 Subject: Re: building in 32bit chroot on x86_64 host broken To: Linus Torvalds , Ulf Magnusson CC: Masahiro Yamada , Linux Kernel Mailing List References: <8f46ed9a-85c0-8df4-2d1e-d268cbc9d0e9@mageia.org> <7a5458da-4222-7480-00ed-a51bed2c1e39@mageia.org> From: Thomas Backlund Message-ID: <28026f53-714a-b76d-00da-562c7612e265@mageia.org> Date: Tue, 5 Jun 2018 22:35:43 +0259 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-WatchGuard-Spam-ID: str=0001.0A0C0208.5B16E603.016C,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-WatchGuard-Spam-Score: 0, clean; 0, virus threat unknown X-WatchGuard-Mail-Client-IP: 85.134.45.194 X-WatchGuard-Mail-From: tmb@mageia.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 2018-06-05 kl. 22:13, skrev Linus Torvalds: > On Tue, Jun 5, 2018 at 11:50 AM Thomas Backlund wrote: >>> but why do you care? >> Because without it running the build in the 32bit chroot will get the >> initial reported issue: > Ahh. I can re-create that now. > > Yes, doing > > make ARCH=i386 allnoconfig > > followed by > > make oldconfig > > is broken. And doing a trivial "git bisect run" to pinpoint where > CONFIG_64BIT goes away gives us > > f467c5640c29ad258c3cd8186a776c82fc3b8057 is the first bad commit > > which does that > > "kconfig: only write '# CONFIG_FOO is not set' for visible symbols" > > and it turns out that CONFIG_64BIT is not a visible symbol on x86-32, > because that question is disabled when ARCH != "x86". > > bool "64-bit kernel" if ARCH = "x86" > > And the problem with that, is that *next* time around this config file > is used, because we don't have that > > # CONFIG_64BIT is not set > > line, we don't turn it into > > CONFIG_64BIT=n > > and then the "depends on" in X86_64 > > config X86_64 > def_bool y > depends on 64BIT > > no longer hides it. > > Hmm. Ulf, Masahiro, comments? > > Should we just revert that commit? > > Thomas, can you verify that a > > git revert f467c5640c29ad258c3cd8186a776c82fc3b8057 > > fixes the problem for you? > > Linus Yep, that fixes it so it works both  in the 32bit chroot and on the 64bit host -- Thomas