Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1321416imm; Tue, 5 Jun 2018 12:36:53 -0700 (PDT) X-Google-Smtp-Source: ADUXVKL6ivfFoFZ/+CflN/pTpTnNz+yGy6xM5uwWq1ZH/jRGXfItDrLF9dDU9qhWheH44JwBxcnt X-Received: by 2002:a17:902:b28:: with SMTP id 37-v6mr27681243plq.201.1528227413707; Tue, 05 Jun 2018 12:36:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528227413; cv=none; d=google.com; s=arc-20160816; b=azpRwkhs3E6GMlBdino0DliQzaPbtc/7BHbay8F/AnCadO62rJNpWFVX2AiEwbNMzJ sA7esmkQoKbONJG/kIG9LeC32OsvzCAQnuYx2RwcdrPBTEwwbSwlxR7ESasUBag5s1xg McXtl+TW8u2R8+LwIzv7ndkgvWcJFgXdBG7TdLpWr6+j7zsjOC1zdRzkAfnq7ep30Wr8 CzKKkSZZFQCSUl9IkDzTE+0eL5iZupj0iqoqb0OM4fly8Jqy0d/LlbDu8d4SCL9fQ60S 2UdbnWJ/0upZFgdvi0kx4uzK8eF7E8wBrKIPdWs11NLPmbdqXWmzE3d9wuKcaYDL+PKh 5Zsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:arc-authentication-results; bh=pW8fPNHhVm940TFbqDjN3e/NHYGdjC/F4WBsKukSfac=; b=iFyjPENf2fBRlVEAI11nuMfipwXA67QR0xEWUPpm7zezUmih62fBVVDx3US5X0L6ZA Gm8po+iN11dwevpYe14j8bPz6tsrejZ/VmJ4TZwO0yYUogwyKwg24bN5KyMXgC3tIhbV nPggKJFSpeaHuQH80g1PVAEeanZTC58TgQGM/jSwAOZLhtMJIvbiwhgu//xjNBnD6Utc 62y53oAbHspk15mJCCt9JZUr3wFBh6gp3LTq5GXS0W1Dm7x2eW2P7luda0QYQWF7dPqE 6Q8IevMIfiFYbLVuvddlhvdYngW/2NJO4CcosQ2fHKRTEEJJg361Y0XYSCqHDW4o3CkX UU7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si35202239pgc.300.2018.06.05.12.36.39; Tue, 05 Jun 2018 12:36:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752046AbeFETgD (ORCPT + 99 others); Tue, 5 Jun 2018 15:36:03 -0400 Received: from mga03.intel.com ([134.134.136.65]:29706 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbeFETgC (ORCPT ); Tue, 5 Jun 2018 15:36:02 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2018 12:36:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,479,1520924400"; d="scan'208";a="45502530" Received: from araccah-mobl.ger.corp.intel.com (HELO localhost) ([10.249.254.105]) by fmsmga008.fm.intel.com with ESMTP; 05 Jun 2018 12:35:58 -0700 Date: Tue, 5 Jun 2018 22:35:57 +0300 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v4 1/4] tpm: migrate tpm2_shutdown() to use struct tpm_buf Message-ID: <20180605193557.GA27994@linux.intel.com> References: <20180326121406.14548-1-jarkko.sakkinen@linux.intel.com> <20180326121406.14548-2-jarkko.sakkinen@linux.intel.com> <20180518223032.ihszdef5wesj5nie@cantor> <20180523125655.GB363@linux.intel.com> <20180527091452.azwuh5u7rjyy7z6h@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180527091452.azwuh5u7rjyy7z6h@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, May 27, 2018 at 02:14:52AM -0700, Jerry Snitselaar wrote: > On Wed May 23 18, Jarkko Sakkinen wrote: > > On Fri, May 18, 2018 at 03:30:32PM -0700, Jerry Snitselaar wrote: > > > On Mon Mar 26 18, Jarkko Sakkinen wrote: > > > > In order to make struct tpm_buf the first class object for constructing TPM > > > > commands, migrate tpm2_shutdown() to use it. In addition, removed the klog > > > > entry when tpm_transmit_cmd() fails because tpm_tansmit_cmd() already > > > > prints an error message. > > > > > > > > Signed-off-by: Jarkko Sakkinen > > > > > > Reviewed-by: Jerry Snitselaar > > > > Thanky you Jerry. I'll do one more round for this only to update kdoc. > > It does not involve code changes so are you OK if you I keep your > > reviewed-by despite this update? > > > > /Jarkko > > Sure I pushed this commit to my master branch. The only changes are: 1. Update to kdoc. 2. Removed change to tpm2_flush_context_cmd() (should not be part of the commit). Did not make sense to cycle it through ML anymore. /Jarkko