Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1334024imm; Tue, 5 Jun 2018 12:51:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLXJh52oPy8P01H3EnF7KZpLX40+qCt9dACjOUH7WagfN/cgEor+VxQ/iNiCMjkPtQfiU6n X-Received: by 2002:a63:a344:: with SMTP id v4-v6mr17856pgn.442.1528228293390; Tue, 05 Jun 2018 12:51:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528228293; cv=none; d=google.com; s=arc-20160816; b=0/ms/uRSMCU0gL3qKtz8rhSRi+15RD+aZ3Tnw74tJZxkHjcBQfaUrSyP70UxRxn7vL SGvneP13jkUui1QyJrxmx3Hncp+/Ax6VvrRfuukO0PkLH8wRJ1gj4019JaQAwBMGCkaO 6MuA/LFuFe/c/DY3PnUi440bD7GeUbtrCZiSSgZ45jWh/a+nuYikT6sY0xgw9oR4CNfI yHedpJbw8QdGc9cqHmKkBdDuKjyTIHTQSJnY4gZH31fu/j0pD2DYhUovkiSJaLUxYEwp QrItXXFJQogZGefK81VzsjMeJPDnzyfzS9qnvalkOmqIM9EHkcKu6KoCiBEdMVbZfNAn GzNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature :arc-authentication-results; bh=yOJqttQW3dGxA+ag2G6WE9SuUWfrGOBemtc4Fdk1xjw=; b=qU/FxjLQM8VKZzt0H30dUXVTdib5PtJWT9Dr3rj8q8wAi2apCowoYeVwd97UbuNq78 GRLw3LxDBu41ZRDo9KemCrONKjGkWOcjtEiUmxCkBOzeKERxlgwQtG5mFVc72pZgyPs7 yI5/TP6m70UswDqJyZ9geX1Z+WDXTtu+wd6bY3ewFJ06i1yn/EYG6XfaQOb90YOtmScf XwnCf9guIJzM7tZd2ToyysFX2YNT5XnpqDjIxc1AG2yE/XE69FdgqMAgkTMskN6l2lpb q72omb3Djrh+t/3wErMCRsflLnagA7DLmsJIDVg50y6x9UZKcQJAkEzJmY7lnliO8R3o bVag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fIARgGMt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t190-v6si2788322pgc.445.2018.06.05.12.51.19; Tue, 05 Jun 2018 12:51:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=fIARgGMt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752430AbeFETuv (ORCPT + 99 others); Tue, 5 Jun 2018 15:50:51 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:42103 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386AbeFETur (ORCPT ); Tue, 5 Jun 2018 15:50:47 -0400 Received: by mail-pl0-f65.google.com with SMTP id w17-v6so2172120pll.9 for ; Tue, 05 Jun 2018 12:50:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yOJqttQW3dGxA+ag2G6WE9SuUWfrGOBemtc4Fdk1xjw=; b=fIARgGMts3914tUoG/6X8kLhuFD2SaHzBFUl4MxJkBaVbiiMZY1HpPd1ud/YtX+kTs xfDd+d/1b/+dnzcj4kdcaC5tlloAH3A6lDPoD28UNxbp1yPQZzsHZNtrDKHs1FnzFEra e1Y2mqz2U3E0UrsHu5PGoagV0G/u0OdMooOnjg1+oNEuQB00EUiU+mTEYDXS+BeXQZ99 7VUzBGZGCElLczC0DUeBf5TCB4yb7p5MfENe8wD9F8Kn8pnVUAPcWBB5x21h+XRwh7x4 t5vZHT/WGnNcDDPWPxUHSbk0EpqhJsj/hk0YEa8DJKU4PO0G15BSmzTDYQ/Y3BRisBwi 9+vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yOJqttQW3dGxA+ag2G6WE9SuUWfrGOBemtc4Fdk1xjw=; b=lb1EWvX0i4VeyLxCYnQwXlTlzoUnHso7Ws0X9mW65V2O5K+wORAWs/cgPZ/iVIceTn oGwvs5gJlyHFpbzrnol3foOz0DcdtWiDvtKNcXnOEh3EdsgBLyYyrSfAkmM+E2O3CLeU 9orgkf1WPiXKhMuGZZtR1QFXQpqsBvC7OcuyAbi6HGxzpz3b/a5qrWJWdlas5+MEXJwL PyrU1ICxw+xz6apSv5sc4yZoBELd57iNyIoYnjInYghA+mv6S2XoXEvoNpxBS587FG2j XifFlq6Rl3bbxZZCmdbvXAAvZBaVNDP55QQVCuWEBi2T49PrKA4Zte04YfDMKworMG0+ rIgw== X-Gm-Message-State: APt69E0gMEBEWrubwhNFHsX89dtRG2An33yj0t6FcmuKxnVOUkwnhw9k XXkYZtioB88fpFMpB/AutrRCgpajH9Xt7qvphgnDfA== X-Received: by 2002:a17:902:7d09:: with SMTP id z9-v6mr5592pll.233.1528228246441; Tue, 05 Jun 2018 12:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20180605170532.170361-1-ndesaulniers@google.com> <20180605170532.170361-2-ndesaulniers@google.com> <202492204c2d5bd5ca27307cbca5e44673b739ed.camel@perches.com> <5ad1876557235a089a50e6ed6c558a7dcb0da714.camel@perches.com> In-Reply-To: <5ad1876557235a089a50e6ed6c558a7dcb0da714.camel@perches.com> From: Nick Desaulniers Date: Tue, 5 Jun 2018 12:50:34 -0700 Message-ID: Subject: Re: [PATCH v2 1/2] compiler-gcc.h: add gnu_inline to all inline declarations To: joe@perches.com Cc: Andrew Morton , Ard Biesheuvel , Andrey Ryabinin , akataria@vmware.com, boris.ostrovsky@oracle.com, brijesh.singh@amd.com, Cao jin , Greg KH , hpa@zytor.com, "J. Kiszka" , jarkko.sakkinen@linux.intel.com, jgross@suse.com, Josh Poimboeuf , kirill.shutemov@linux.intel.com, mingo@redhat.com, mjg59@google.com, Matthias Kaehlcke , Philippe Ombredanne , rostedt@goodmis.org, Thomas Gleixner , thomas.lendacky@amd.com, Thiebaud Weksteen , linux-efi@vger.kernel.org, LKML , x86@kernel.org, virtualization@lists.linux-foundation.org, Alistair Strachan , Manoj Gupta , Greg Hackmann , sedat.dilek@gmail.com, tstellar@redhat.com, Kees Cook , Masahiro Yamada , Michal Marek , Linux Kbuild mailing list , geert@linux-m68k.org, Will Deacon , mawilcox@microsoft.com, Arnd Bergmann , David Rientjes Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 5, 2018 at 12:14 PM Joe Perches wrote: > > On Tue, 2018-06-05 at 10:23 -0700, Joe Perches wrote: > > Perhaps these are simpler as > > > > #define __inline__ inline > > #define __inline inline > > Currently, there are these uses of inline variants in the kernel > > $ git grep -w inline | wc -l > 68410 > $ git grep -w __inline__ | wc -l > 503 > $ git grep -w __inline | wc -l > 57 > > So it seems it's also reasonable to sed all uses of __inline to inline > and perhaps remove __inline eventually altogether. > (perhaps there are still too many __inline__ uses) Yeah, that sounds good. Should I split that into 3 patches: > Excluding scripts and a few other files, > here's a possible patch done with: > > $ git grep -w --name-only __inline | \ > grep -vP '^(?:arch/alpha/|include/|scripts/)' | \ > xargs sed -r -i -e 's/\b__inline\b/inline/g' \ > -e 's/\binline\s+static\b/static inline/g' > --- > Documentation/trace/tracepoint-analysis.rst | 2 +- > drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 4 ++-- > drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +- > drivers/staging/rtl8723bs/include/drv_types.h | 6 +++--- > drivers/staging/rtl8723bs/include/ieee80211.h | 6 +++--- > drivers/staging/rtl8723bs/include/osdep_service.h | 10 +++++----- > drivers/staging/rtl8723bs/include/osdep_service_linux.h | 14 +++++++------- > drivers/staging/rtl8723bs/include/rtw_mlme.h | 14 +++++++------- > drivers/staging/rtl8723bs/include/rtw_recv.h | 16 ++++++++-------- > drivers/staging/rtl8723bs/include/sta_info.h | 2 +- > drivers/staging/rtl8723bs/include/wifi.h | 14 +++++++------- > drivers/staging/rtl8723bs/include/wlan_bssdef.h | 2 +- > lib/zstd/mem.h | 2 +- > 13 files changed, 47 insertions(+), 47 deletions(-) 1 for documentation, 1 for rtl8723bs, 1 for zstd? Follow up set or include in v3? -- Thanks, ~Nick Desaulniers