Date: Fri, 5 Sep 2003 00:34:36 +0200
From: Andries Brouwer <aebr@win.tue.nl>
To: Jamie Lokier <jamie@shareable.org>
Cc: Chris Heath <chris@heathens.co.nz>, aebr@win.tue.nl,
       linux-kernel@vger.kernel.org, vojtech@ucw.cz,
       Ralf Hildebrandt <Ralf.Hildebrandt@charite.de>
Subject: Re: keyboard - was: Re: Linux 2.6.0-test4
Message-ID: <20030905003436.A3105@pclin040.win.tue.nl>
References: <20030903235647.C765.CHRIS@heathens.co.nz> <20030904204816.GD31590@mail.jlokier.co.uk>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <20030904204816.GD31590@mail.jlokier.co.uk>; from jamie@shareable.org on Thu, Sep 04, 2003 at 09:48:16PM +0100
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 987
Lines: 26

On Thu, Sep 04, 2003 at 09:48:16PM +0100, Jamie Lokier wrote:

> Why so many complicated assumptions?  Just maintain a bitmap if key
> up/down states (initialised to up), and if you receive a release event
> when the key is in the up state, ignore the event.

Ha! We maintain two such bitmaps. And they get out of sync too.

You talk too easily. "If you receive a release event".
But one does not receive release events, one receives bytes.
The interpretation of those bytes belongs to the keyboard driver.

But i8042.c needs to know whether scancodes are releases
in order to do its massaging of the scancodes before giving
them to the keyboard driver.

I regard i8042.c as fundamentally broken.
On the other hand, it almost works.

Andries

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/