Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp77209imm; Tue, 5 Jun 2018 15:23:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKI3SHsitGiTWilU1zab8wfhm6EcC5VYtXRtJQtxRNqRlzDKyihMy1Na5aY8KCWXaHx2rW3I X-Received: by 2002:a62:4bc8:: with SMTP id d69-v6mr429536pfj.244.1528237403245; Tue, 05 Jun 2018 15:23:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528237403; cv=none; d=google.com; s=arc-20160816; b=rXwV3JpXaLHBnQOrp9yBcbpkdSMBVKKkaosxUozGj2qcn8jHubiLh7LJ1VbC4a4TBO e7QSkpWG6kdiCHtOu4uRBFJnGT+PLi97VqD9GsL9906aMv2X72QTv0uuydIFdtP0bgmb XIXfjApZqstTizhv0L1AJbbk2jZnXRysB822gZDgBZx0NibajX+BQHORDyl26Zmq21cJ nd2pIgGLq1FyxWDBJy8LtPPm1WD7HZ5G+US4ZxlljktAqxQ4Kk5ZdQuS61KKoUtP9MfI WuLuslIAwHzGYiZ8ri7YvDzNlZgEyFe86shudJ2AwqsJHMky1pfa8lv4zRvet4+LF/bn 8vdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=FmmyPORMSB6i1TxNibv1FDw2s9ySeA/+IWR2tF/vF9o=; b=gvNm99WPH7ltr5p8IH2P9TTR7rzpwnsUqlK2Q2pBQzmWi5NOq3Rl89Y6hoaUDpv/sI +7k16n9791uV9f+OESOKEf1hB2+vyIIMnKeGgOd9jH/73Fd2ZungS4YsWouVQqaPzDEJ YNzgHgOOPmkrk0QeMI+MSTUiLnS74G2PH57f3bMzjFcni8T05u+rpge2f3Mh4ljqGUOU DK+wG0u+Hhq6EgDOpURWDycK3XC1f/MRtxBUg5lvJdftSzxwWZG7+ZNnc5azH6zJhppV 3TgNhi852a7HI47GvbZpAHktYYcp0fFy/RPxiu03w+9mA30mKMqH7x7jnaI7cn66jp+o Prog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sF5YrazU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a10-v6si47282955pfo.121.2018.06.05.15.23.07; Tue, 05 Jun 2018 15:23:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=sF5YrazU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752541AbeFEWWm (ORCPT + 99 others); Tue, 5 Jun 2018 18:22:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:34478 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbeFEWWl (ORCPT ); Tue, 5 Jun 2018 18:22:41 -0400 Received: from localhost (unknown [69.71.5.252]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 10615204EC; Tue, 5 Jun 2018 22:22:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528237360; bh=QcpwFD2A6B50W4jlxpqeTSzh2fhfHn+tX3P7ldE5p2U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sF5YrazU+mQKJhstqwAUVl9UjG2It/mxP95KXUZaV+F9gUm2IuiBRT/MKZCxDSThV zLpPF5VMgxHnmDqGb5i0kqJuYSRbxLgiu5mkcfgcRj+mQ0THwDroJuvC7f3hw8mSrk 9RRdhjdnG5P/lLoNsmiN8lkJSfQBGAQEQWTXDY90= Date: Tue, 5 Jun 2018 17:21:59 -0500 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Oza Pawandeep , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 0/2] PCI/AER: Clean up minor logging issues Message-ID: <20180605222158.GD226399@bhelgaas-glaptop.roam.corp.google.com> References: <152770259826.80701.7360032106128917833.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152770259826.80701.7360032106128917833.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 30, 2018 at 12:54:10PM -0500, Bjorn Helgaas wrote: > AER logging printed the plain 16-bit Requester ID straight out of the TLP, > which is hard to interpret, e.g., id=00e4 corresponds to what we normally > see as 00:1c.4 in dmesg or lspci. > > Also, there's no need to print the vendor/device ID of the root port > reporting an error; we can easily find that from dmesg or lspci. > > --- > > Bjorn Helgaas (2): > PCI/AER: Decode Error Source Requester ID > PCI/AER: Stop printing vendor/device ID > > > drivers/pci/pcie/aer/aerdrv_errprint.c | 23 +++++++++++++---------- > 1 file changed, 13 insertions(+), 10 deletions(-) I applied the first but not the second to pci/aer for v4.18.