Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Daniel Rosenberg <drosen@google.com>,
        "Sumit Semwal" <sumit.semwal@linaro.org>,
        linux-kernel@vger.kernel.org
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20180605234041.246060-1-drosen@google.com>
Cc:     "Daniel Rosenberg" <drosen@google.com>,
        "Divya Ponnusamy" <pdivya@codeaurora.org>,
        "Gustavo Padovan" <gustavo@padovan.org>,
        dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
        "stable" <stable@vger.kernel.org>, kernel-team@android.com,
        linux-media@vger.kernel.org
References: <20180605234041.246060-1-drosen@google.com>
Message-ID: <152824267238.9058.16502636333550686918@mail.alporthouse.com>
User-Agent: alot/0.3.6
Subject: Re: [Linaro-mm-sig] [PATCH resend] drivers: dma-buf: Change %p to %pK in
 debug messages
Date:   Wed, 06 Jun 2018 00:51:12 +0100
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Daniel Rosenberg (2018-06-06 00:40:41)
> The format specifier %p can leak kernel addresses
> while not valuing the kptr_restrict system settings.
> Use %pK instead of %p, which also evaluates whether
> kptr_restrict is set.

This is backwards though. You never care about the actual value here and
the hashed pointer (%p) is always enough to provide an identifying token.
-Chris