Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp439622imm; Tue, 5 Jun 2018 23:36:37 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLTZRUNNdq9QdOk0aUlKHIBtty6mTCnX8f249DwGkPAxZxaOEDRoEGrmoYMTFnAhpSvGvEU X-Received: by 2002:a17:902:8b86:: with SMTP id ay6-v6mr1466365plb.295.1528266997880; Tue, 05 Jun 2018 23:36:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528266997; cv=none; d=google.com; s=arc-20160816; b=GQgI1LfrdMzA9Jb7MwA1nPKbgtXbD+aJzSYL/tio3sIwe/u3v4shPJeTzwPWAmGf4E ZKw33KR/kOn4ymIFy8gGzpTsZVwi73991eVs+7dOJ1GvCISN+AysE4TPoXQKww5yoJdO HUAEwuaF4sFdVTlzghla2VdKQD5BH5Vj02qu3EsewpVyhgTv+mhCqZZRTTyiSu/jzeNX 3xE5i48Sw0JDfOl8eoSuffqP930z0wk0Gdn1JVq2Vk6mbREP5Yny/cQeafMY/rL26xoN 4Bnk867YWy3gF11IjZ3pr2tk6zPRVMS2jUVEjV289vc8sdjF4Dy57x10DIrhKqSJkhJL qeyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :arc-authentication-results; bh=ZMqLEJ1llqJ4NmRWZWJDxa+eu2LN6MoxIkZ3IobLWqk=; b=ToMp6x3xX5yq8FaL/pYEONNM9r+10/4scKNCuTOAuTipUK3UuxcnTxElqF28H/5+ev 6mSFsG6Lihpwe/aDTcjSKoevnfOnDnmKE0YO0tABSyF5Dmb5JaNXA+GnLEpOxAvOVav9 Covf8PvgxMn1Y+2dgSUrZ4KhffvcKA//2xz695tE5yPjoRgJ16l9rO2ILqZuN/NH3Czj vBHwdZSYfqogu7E10rzu5onEnRyBnOz4/Md6h8IvYHqGzUy+SV72apEduVyMilb6oK6e aiXMu1d3Jo5Qu6vyBVltETWmD0vQ+hwXXJlhk0uEv27WceTStrhQvs4rCF6uYGlZbgk7 6OQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZEmbkxbe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e11-v6si8628881pln.161.2018.06.05.23.36.23; Tue, 05 Jun 2018 23:36:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZEmbkxbe; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932217AbeFFGf6 (ORCPT + 99 others); Wed, 6 Jun 2018 02:35:58 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:54721 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932103AbeFFGf4 (ORCPT ); Wed, 6 Jun 2018 02:35:56 -0400 Received: by mail-wm0-f67.google.com with SMTP id o13-v6so9231200wmf.4 for ; Tue, 05 Jun 2018 23:35:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=ZMqLEJ1llqJ4NmRWZWJDxa+eu2LN6MoxIkZ3IobLWqk=; b=ZEmbkxbe9oBU0It/3oUJfYQT3Et5EFmLdpu5H0k9cTSe40Mv4SwaIJgISG84zIVvaw 9Yf3mNhhOh6emjP7xqATAeBunLhYqd+2iIXonLj5s1vPMj+Zz5bQ4Fs8bTyt7buBEOu6 ncaF0npWLQ0XnV8BYYjF6I4TNO6XtN6p+4Xd4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=ZMqLEJ1llqJ4NmRWZWJDxa+eu2LN6MoxIkZ3IobLWqk=; b=bOiUxDKPrpsJrpoTF0IqYawKdrMSQShcg5yc+1R61ie+5NDL50+t1gxuuAEpwsiuW6 GUL/p1SbiUKh4XEUGJ6qgXV7OgW+pqi0D1fmzTtYaVYLW/cxJu+Yqr6mjDnK8reEO/k4 XGBWqQPmZTDhEigoGBzo0qle2z65GfIO17tOklX3oKe3dz+TIr3RGvMh7PJ7DrtaN+Ln mmkuNxTi5az23cXP8ek36Os7mrFP/+ENGi/tdvfoDpYaFcqIkZhBYP3SUCugGluipBFO b+WNVRbaJGFI1xk68gDqR7YDgEYn00uM+s5CCl1aUJJyHIRJwi9vsULB2AcI5zUesqtz p2tg== X-Gm-Message-State: APt69E1MPipuHz77ftQ5Hvq39Bdo6/iAqGccApYaPRKxJLw72fwW5W2a DrwIs7knkmXjP2zzlkgXHVGZYw== X-Received: by 2002:a1c:2dd5:: with SMTP id t204-v6mr858357wmt.94.1528266955036; Tue, 05 Jun 2018 23:35:55 -0700 (PDT) Received: from dell ([2.31.163.53]) by smtp.gmail.com with ESMTPSA id b66-v6sm4696939wma.48.2018.06.05.23.35.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 05 Jun 2018 23:35:54 -0700 (PDT) Date: Wed, 6 Jun 2018 07:35:52 +0100 From: Lee Jones To: Marek Vasut Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , Mark Brown , Steve Twiss , Wolfram Sang , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v4 01/12] mfd: da9063: Fix failpath in core Message-ID: <20180606063552.GW21163@dell> References: <20180605231013.1803-1-marek.vasut+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180605231013.1803-1-marek.vasut+renesas@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 06 Jun 2018, Marek Vasut wrote: > In case mfd_add_devices() fails, da9063_irq_exit() is not called to > undo the IRQchip setup done by da9063_irq_init(). Fix this by adding > the missing fail path. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Lee Jones > Cc: Mark Brown > Cc: Steve Twiss > Cc: Wolfram Sang > Cc: linux-renesas-soc@vger.kernel.org > --- > V3: New patch > V4: No change > --- > drivers/mfd/da9063-core.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog