Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp709891imm; Wed, 6 Jun 2018 04:57:42 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKIJB40LfeSp88Cx69k9GQpF8NG0t+O+A1+sSUVo3oxWBQ8g7aioFtYaayUfKJ3C9wqyV2E X-Received: by 2002:a17:902:563:: with SMTP id 90-v6mr2969069plf.327.1528286262220; Wed, 06 Jun 2018 04:57:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528286262; cv=none; d=google.com; s=arc-20160816; b=OZa4vgiXJvekcXcQG+WQfSmj+UTzxh59pktztKxlAJ09z1IbFyyPzarYweQbGxc0If fbnrJSpO3hJ34eFYtZH9/qJLD09tpUcYhjR/dHbkZ2z3CHcbnMmmzyloa69l4U/b70nT U/emEfAtgrmP+5Wc+AMI7hKxzUSwCCzsb+mYxTGzsj6cfCLRILIiusXN3t2PqHBhslam MM4kyW7MT72oh9ss9hv3Ujmwl08/FYk3XfQQugdPvBoyjeZUU61AuqpYKZEsroyOwu0u 5Egtv9vcpP0W+nv7wUJuHiAgTH3g3zLDJX/7c9OmAXeWwU5h/EnpJ4aPRmjdAzOA7z8e eqxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:date:cc:to:from:subject :message-id:arc-authentication-results; bh=2ATH+ooGkTzM2ogsvt3lsCd7qO6E01zXLaWglPWEpRk=; b=RDlr8UuiNrFF8X4qUxfcVoepwB63lGFRLJ6Uu4I6usB4NjGkYaHi0z2mEZw7vtCJcS lV11ZJiTZNnHR9JXJnfg7OgpNxrmKOFtxvBzJBPhB2xZZ5uwTq+clRWg/IRBdfHrqTUz tylAYgoNHmBbnJgIhmyvK0SOCXXTAC07N9SLbhYDynXdq+UTPfAnw8UYpP/DOd8F74k0 HjRWBzy5hmn5hpGbj6cM1Qgi8Kus1H6WbYXDk6doOOyeZkk6EDlpzGaJpZVlm44XxIY1 thKk5UJWHEF+16BIpYVXr3URvv0unllOX0D7eG0BwPhXhH7Hb7vqz9EPsoG0nQyfh+S8 +h4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 92-v6si49517677plw.299.2018.06.06.04.57.25; Wed, 06 Jun 2018 04:57:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbeFFL4k (ORCPT + 99 others); Wed, 6 Jun 2018 07:56:40 -0400 Received: from mga11.intel.com ([192.55.52.93]:3972 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbeFFL4i (ORCPT ); Wed, 6 Jun 2018 07:56:38 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 04:56:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,483,1520924400"; d="scan'208";a="46860440" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga007.jf.intel.com with ESMTP; 06 Jun 2018 04:56:34 -0700 Message-ID: <069f5cd3309e83d13c74929f240720b232ea7251.camel@linux.intel.com> Subject: Re: [PATCH 1/4] serial: 8250: Copy em485 from port to real port. From: Andy Shevchenko To: Giulio Benetti Cc: matwey.kornilov@gmail.com, Greg Kroah-Hartman , Jiri Slaby , Matthias Brugger , Kees Cook , Allen Pais , Sean Young , "open list:SERIAL DRIVERS" , open list Date: Wed, 06 Jun 2018 14:56:34 +0300 In-Reply-To: <20180606094942.71190-4-giulio.benetti@micronovasrl.com> References: <20180606094942.71190-1-giulio.benetti@micronovasrl.com> <20180606094942.71190-4-giulio.benetti@micronovasrl.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2018-06-06 at 11:49 +0200, Giulio Benetti wrote: > em485 gets lost during serial8250_register_8250_port(). > > Copy em485 to final uart port. > Is it needed at all? The individual driver decides either to use software emulation (and calls explicitly serial8250_em485_init() for that) or do HW assisted stuff. > Signed-off-by: Giulio Benetti > --- > drivers/tty/serial/8250/8250_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 9342fc2ee7df..c8c2b260c681 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -994,6 +994,7 @@ int serial8250_register_8250_port(struct > uart_8250_port *up) > uart->port.rs485_config = up- > >port.rs485_config; > uart->port.rs485 = up->port.rs485; > uart->dma = up->dma; > + uart->em485 = up->em485; > > /* Take tx_loadsz from fifosize if it wasn't set > separately */ > if (uart->port.fifosize && !uart->tx_loadsz) -- Andy Shevchenko Intel Finland Oy