Message-ID: <32901.4.4.25.4.1062724109.squirrel@www.osdl.org>
Date: Thu, 4 Sep 2003 18:08:29 -0700 (PDT)
Subject: Re: [PATCH] ikconfig - resolve rebuild permissions
From: "Randy.Dunlap" <rddunlap@osdl.org>
To: <sam@ravnborg.org>
In-Reply-To: <20030904191353.GA10448@mars.ravnborg.org>
References: <20030904113133.3f950a51.shemminger@osdl.org>
        <20030904191353.GA10448@mars.ravnborg.org>
Importance: Normal
Cc: <shemminger@osdl.org>, <torvalds@osdl.org>, <linux-kernel@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1366
Lines: 40

> On Thu, Sep 04, 2003 at 11:31:33AM -0700, Stephen Hemminger wrote:
>> This patch fixes it by removing the configs.o file when
>> needed.
>
> A better approach would be to remove the need for compile.h from
> configs.c. See attached patch for the makefile change.
> It just took the relevant part from mk_compile and
> used it in the Makefile.
> Example only - I expect Randy to integrate it properly.

configs.o also wants UTS_RELEASE from compile.h, and
I really dislike generating the same data in multiple places,
so I prefer to continue to use compile.h.
I'll see about other options or using Steve's patch.

Thanks,
~Randy


> ===== kernel/Makefile 1.33 vs edited =====
> --- 1.33/kernel/Makefile	Mon Sep  1 01:13:58 2003
> +++ edited/kernel/Makefile	Thu Sep  4 21:05:29 2003
> @@ -19,6 +19,7 @@
>  obj-$(CONFIG_BSD_PROCESS_ACCT) += acct.o
>  obj-$(CONFIG_COMPAT) += compat.o
>  obj-$(CONFIG_IKCONFIG) += configs.o
> +CFLAGS_configs.o = -DLINUX_COMPILER="$(shell $(CC) -v 2>&1 | tail -n 1)"
>
>  ifneq ($(CONFIG_IA64),y)
>  # According to Alan Modra <alan@linuxcare.com.au>, the
> -fno-omit-frame-pointer is
> -


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/