Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: AMD graphics performance regression in 4.15 and later
To:     Gabriel C <nix.or.die@gmail.com>
Cc:     Jean-Marc Valin <jmvalin@mozilla.com>,
        Dave Airlie <airlied@linux.ie>, alexander.deucher@amd.com,
        Felix Kuehling <Felix.Kuehling@amd.com>,
        Laura Abbott <labbott@redhat.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        michel.daenzer@amd.com, dri-devel@lists.freedesktop.org,
        LKML <linux-kernel@vger.kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
References: <c743b220-0395-eef3-4405-a21cdbe8eee1@mozilla.com>
 <9ca940f1-7f21-c420-de45-13d72e783ab6@amd.com>
 <a96df0b8-fc22-4438-646d-2f0096dfcc84@mozilla.com>
 <6cebabff-908f-5ebe-4252-760773c4cd6f@amd.com>
 <312ed341-7052-a61e-331f-d1e8fd5b477e@mozilla.com>
 <d136f940-d807-d2f7-30a7-8617f130912d@amd.com>
 <77866d66-2728-8295-d7ee-9975dbf64b99@mozilla.com>
 <55e1712b-6567-50c5-3789-53dd1ccddb94@gmail.com>
 <CAEJqkgiOR3aCGoNquVeEyC1BLMBPmXNjgrmjNeeE9UVfzcJKzg@mail.gmail.com>
 <CAEJqkgjfhmjwYo74xivsfgvoPQUFh2dFeXFwtEKoN+DXG1riMg@mail.gmail.com>
 <CAEJqkgiVdeBf9konX4OJi59dYp4y_b+J02ns=yf-D6tjtZ7P1g@mail.gmail.com>
 <52eceaff-987d-4c1d-a2cb-73b28e48c01c@amd.com>
 <CAEJqkgiBZ6G+tXWULYoGKqq3BsgvH7TrqkFbhtRL4JnGM+dLuA@mail.gmail.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Message-ID: <89d91028-c800-b6db-38de-4ece84e5effd@amd.com>
Date:   Wed, 6 Jun 2018 14:19:33 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAEJqkgiBZ6G+tXWULYoGKqq3BsgvH7TrqkFbhtRL4JnGM+dLuA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Received-SPF: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2018 12:19:44.4019 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 15f7dcf9-2ca2-46cf-05f4-08d5cba7cace
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1724
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 06.06.2018 um 14:08 schrieb Gabriel C:
> 2018-06-06 13:33 GMT+02:00 Christian König <christian.koenig@amd.com>:
>> Am 06.06.2018 um 13:28 schrieb Gabriel C:
>>> 2018-04-11 7:02 GMT+02:00 Gabriel C <nix.or.die@gmail.com>:
>>>>> 2018-04-11 6:00 GMT+02:00 Gabriel C <nix.or.die@gmail.com>:
>>>>> 2018-04-09 11:42 GMT+02:00 Christian König
>>>>> <ckoenig.leichtzumerken@gmail.com>:
>>>>>> Am 07.04.2018 um 00:00 schrieb Jean-Marc Valin:
>>>> ...
>>>>> I can help testing code for 4.17/++ if you wish but that is *different*
>>>>> storry.
>>>>>
>>>> Quick tested an 4.16.0-11490-gb284d4d5a678 , amdgpu and radeon driver
>>>> are broken now in this one.
>>>>
>>>> radeon tells:
>>>>
>>>> ...
>>>>
>>>> [    6.337838] [drm] PCIE GART of 2048M enabled (table at
>>>> 0x00000000001D6000).
>>>> [    6.338210] radeon 0000:21:00.0: (-12) create WB bo failed
>>>> [    6.338214] radeon 0000:21:00.0: disabling GPU acceleration
>>>>
>>>> ...
>>>>
>>> I have the same Issue now on final 4.17.
>>
>> Actually Michel came up with a fix for the performance regression which is
>> now backported to older kernels as well.
>>
>> So the original issue of this mail thread should be fixed by now.
> Ok , will test as soon I get the GPU to work :))
>
>>> Also I played with BIOS options also which does not fix anything but
>>> changes the error message.
>>>
>>> IOMMU && SR-IOV disabled the error changes to this :
>>>
>>> [    7.092044] [drm:r600_ring_test [radeon]] *ERROR* radeon: ring 0
>>> test failed (scratch(0x850C)=0xCAFEDEAD)
>>> [    7.092059] radeon 0000:21:00.0: disabling GPU acceleration
>>>
>>>
>>> While I could workaround SWIOTLB bugs in 4.15 and 4.16 , 4.17 seems to
>>> kill the GPU with no way
>>> for me to make it work ( at least I could not find any workaround by now )
>>
>> That actually sounds like something completely different. Can you provide a
>> full dmesg of radeon and/or amdgpu?
> Sure here from boot with IOMMU/SR-IOV ON/OFF in BIOS :
>
> http://ftp.frugalware.org/pub/other/people/crazy/radeon/dmesg-iommu-sr-iov-off.txt
> http://ftp.frugalware.org/pub/other/people/crazy/radeon/dmesg-iommu-sr-iov-on.txt
>
> Also nothing else changed in that setup just testing kernel 4.17.

That has nothing TODO with the driver nor the original bug you reported. 
The problem is that SME is active and that is currently not supported at 
all with a that hardware.

Try to disable SME either in the BIOS or on the kernel command line.

Regards,
Christian.

>
> I can force the GPU to use amdgpu if you wish and post dmesg's too.
> Just let me know