Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp758630imm; Wed, 6 Jun 2018 05:39:54 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLEs39DEouL6e3zpnHaM0z3XEtu4Ogo2oGU+jHili66cllFtp2b/EhBpvPZhap3rgOwt/lf X-Received: by 2002:a17:902:369:: with SMTP id 96-v6mr3120015pld.64.1528288794199; Wed, 06 Jun 2018 05:39:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528288794; cv=none; d=google.com; s=arc-20160816; b=E/Q3RLnJIKymFoBSsTV8GExkkUq25kuANWjYE7861z2RVdVTVFEULuPV6bg9WM6bFK PDa8anH5VHEwXnTl92lDbqSY0suRY1MipdqZoAmOgpk3Yv6YgdSKENfn1ncYhsKDuR2P Okpx/Hcm8aV10LEvLrDsYFGAAiwkeKeqIzUFQR1tOyHbzSpllQT+qxmvOToOyiaAVZlF PBWEbp1xshvV9JYoQjbBgUC+/v84elBbwnV81aeSigOaB7ucFGnbQhVUQKYnmT/uyOgB McbpmvCds24cA6SwpzSTfFMos9m+u0YARMHFH/7UYpZbFVO59pqDJQ1H6YJBnDNK28L1 +Z2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date:arc-authentication-results; bh=1DYwVj3BuWve+qQwh3JVqQQnyVo3jO6gthWh8csBDSg=; b=E2uR4cszduFwhiSASQEQh3WgeE0RTd9rsWS4ysTM2LxJohLGyseK1avfDk8yQtOv9T 7UbjffPO2/os+4DNt25hhPPO0kR/5DHc8K3HKaJUkq4pl3hpxxl1QLtUCaC2FvWib2Il +1iys4Iobecx6D+MOvwqtvpaH/+RUSHwukq6mOlIJ8013RsgOuixxyd3WasE8a1EqLFB 0Yrhngm7DhRSgeAtflZ07BISfyEU/QQG4ueBjBt0o+lZlP1KdfaW/sdY/O/HCiMzfsQC WN47rUL2ezNCcLmTs9ekjAQMw4Dio+8iR8VVZuKdjTZdXKdD9lg+huKISjuzgsmPFjAD 8iVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2-v6si50307768pfg.75.2018.06.06.05.39.39; Wed, 06 Jun 2018 05:39:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051AbeFFMjN (ORCPT + 99 others); Wed, 6 Jun 2018 08:39:13 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:14557 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751851AbeFFMjM (ORCPT ); Wed, 6 Jun 2018 08:39:12 -0400 X-IronPort-AV: E=Sophos;i="5.49,483,1520895600"; d="scan'208";a="267844207" Received: from 115-178-117-63.flets.shareline.jp (HELO [10.5.3.74]) ([115.178.117.63]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 14:39:09 +0200 Date: Wed, 6 Jun 2018 21:39:05 +0900 (JST) From: Julia Lawall X-X-Sender: jll@hadrien To: perex@perex.cz, tiwai@suse.com cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: unnecessary test? Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init contains: set_field(&ctl->spoctl, SPOCTL_OS << (idx*8), ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */ Could the second argument just be 2? It's true that the preceeding call contains conf >> ..., but in a more useful way, so perhaps it could be useful for uniformity? thanks, julia