Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp762043imm; Wed, 6 Jun 2018 05:43:06 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLJ5mQOF71K1qCLs/+n01spsLIPXnzToCUTleY1OdsOgY29fz3Gvz0CYg1P+L0hnO2HQ3As X-Received: by 2002:a65:4b82:: with SMTP id t2-v6mr2407170pgq.175.1528288986222; Wed, 06 Jun 2018 05:43:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528288986; cv=none; d=google.com; s=arc-20160816; b=mldWeMdneEom2ZGfEbFdbB4422zeJxDzuCBC8w7SeETD88gGwIf8Qk/R88YOVSmeTz D4gE+t7sa2gMBgiPjwag1M4ffhYlc4owcGRPvsfZAaZFaW7C0y9LQI3OtKinWE2lHOt2 M1/z9cUl/iwdjRHeYmad8ljtcLLVb0N9CiE9FAr8FcAaNVRbqXf73+EDMKHYPIXfmLeC 43xRE0P8IPmSqulRR4/x5OQVShlrgxN8+N91St4Mo4CyKsla8LS48qMLVBZtit2XH/y9 t7JGr3I+zq5hTaTVrE03Zl9ImNjvjaYNDctMWoop5d9oE9LSQE+SSOCm/aXmnYnYyHck iqNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :subject:cc:to:from:date:arc-authentication-results; bh=Hvjq+QSQKjXfaQx42aEu7sv028+4p/FiQxFkaJm4pQk=; b=nNfp0kfVeXb6l3Tn9332c49rPNKtE3robgNmZAxwe881X18lKSHliKEiRYcTijJekH rRWznUQZFOTT01SWHtPPm2H9DaJlpOteQGnv4rLplMgvHBKoIsrLWGBg2Z/DyapxLnRb GswWjXXjsZQVASTYrTk4YQRsSHO0//KqKbUPw1+TtEXNg1mV8OTaJPG2Ykwke02hfFV/ 3cBiaEqx6LrUAzk7N7TCW/aMrxJKH1jPXKsvnjT35ngiczrPfFDdjkDa7lkjNtJ0YG4j U4BduPF1nBikHXgbDvdZNYrxGBiC1HUQQow4VHRBx6AE5fWt+loxMWzIMjuDjT/EORhx lSBA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u76-v6si28565199pfj.58.2018.06.06.05.42.51; Wed, 06 Jun 2018 05:43:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752403AbeFFMmC (ORCPT + 99 others); Wed, 6 Jun 2018 08:42:02 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:10878 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbeFFMmA (ORCPT ); Wed, 6 Jun 2018 08:42:00 -0400 X-IronPort-AV: E=Sophos;i="5.49,483,1520895600"; d="scan'208";a="267844644" Received: from 115-178-117-63.flets.shareline.jp (HELO [10.5.3.74]) ([115.178.117.63]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Jun 2018 14:41:56 +0200 Date: Wed, 6 Jun 2018 21:41:53 +0900 (JST) From: Julia Lawall X-X-Sender: jll@hadrien To: mchehab@kernel.org, hans.verkuil@cisco.com cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: unnecessary tests? Message-ID: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In the file drivers/media/tuners/mxl5005s.c, the function MXL_BlockInit contains: status += MXL_ControlWrite(fe, RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1); status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0); Could the second arguments just be 1 and 0, respectively? It's true that the preceeding call contains state->Mode, but in a more useful way, so perhaps it could be useful for uniformity? thanks, julia