Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 6 Jun 2018 14:41:57 +0200 (CEST)
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Masatake YAMATO <yamato@redhat.com>
cc:     x86@kernel.org, linux-kernel@vger.kernel.org, joro@8bytes.org
Subject: Re: [PATCH] x86/iommu: Fix a typo in a macro parameter
In-Reply-To: <alpine.DEB.2.21.1806061409150.1579@nanos.tec.linutronix.de>
Message-ID: <alpine.DEB.2.21.1806061440000.1579@nanos.tec.linutronix.de>
References: <20180606051026.29535-1-yamato@redhat.com> <alpine.DEB.2.21.1806061235330.1579@nanos.tec.linutronix.de> <20180606.201529.867663362891798169.yamato@redhat.com> <alpine.DEB.2.21.1806061409150.1579@nanos.tec.linutronix.de>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 6 Jun 2018, Thomas Gleixner wrote:
> On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> > On Wed, 6 Jun 2018 12:37:34 +0200 (CEST), Thomas Gleixner <tglx@linutronix.de> wrote:
> > > On Wed, 6 Jun 2018, Masatake YAMATO wrote:
> > > 
> > > Can you please explain why 0 is the wrong value.
> > 
> > I don't know such constants, 0 and 1.
> > 
> > What I change is just the name of macro parameter as 
> > 
> >      s/detect/_detect/
> 
> OOps. Misread the patch. Sorry.

But the fix is pretty pointless. IOMMU_INIT_POST_FINISH() is completely
unused and should just be removed.

Thanks,

	tglx