Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 06 Jun 2018 15:09:45 +0200
Message-ID: <s5h1sdknjs6.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Julia Lawall <julia.lawall@lip6.fr>
Cc:     perex@perex.cz, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: Re: unnecessary test?
In-Reply-To: <alpine.DEB.2.20.1806062206070.4659@hadrien>
References: <alpine.DEB.2.20.1806062135430.4445@hadrien>
        <s5h4lignk0q.wl-tiwai@suse.de>
        <alpine.DEB.2.20.1806062206070.4659@hadrien>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 06 Jun 2018 15:06:28 +0200,
Julia Lawall wrote:
> 
> 
> 
> On Wed, 6 Jun 2018, Takashi Iwai wrote:
> 
> > On Wed, 06 Jun 2018 14:39:05 +0200,
> > Julia Lawall wrote:
> > >
> > > In the file sound/pci/ctxfi/cthw20k1.c, the function daio_mgr_dao_init
> > > contains:
> > >
> > > set_field(&ctl->spoctl, SPOCTL_OS << (idx*8),
> > >           ((conf >> 3) & 0x1) ? 2 : 2); /* Raw */
> > >
> > > Could the second argument just be 2?  It's true that the preceeding call
> > > contains conf >> ..., but in a more useful way, so perhaps it could be
> > > useful for uniformity?
> >
> > I guess this is a typo of "2 : 0".  The code seems toggling the
> > control bit depending on the S/PDIF passthru mode.  It might be
> > reversed, but I bet 1 for non-audio from a common sense.
> >
> > Ditto for cthw20k1.c.  This one is likely 1, not 2, though.
> 
> OK, should I send a patch?  I have no way to test it.

Me neither :)

Feel free to submit the patch.  The SPDIF output seems very rarely
used on these devices (otherwise people must have noticed it), so the
chance to break anything must be small.


thanks,

Takashi