Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1222457imm; Wed, 6 Jun 2018 12:23:15 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJyzq5LgQuEAtCQ3B8Rtcz5RRRVTXcrwj0pFFwX5GNDsIWS2b4xuCW7djUS8KopS/odhkZc X-Received: by 2002:a17:902:9a98:: with SMTP id w24-v6mr4662868plp.9.1528312995803; Wed, 06 Jun 2018 12:23:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528312995; cv=none; d=google.com; s=arc-20160816; b=nWRJNojTMcQylvUuif3X8HREZVhPU4ObbDrhOTWG3e70PUUJ/mB4LTGCNvdNfTzQlj 5DjaDk26cjVxox3fZILEM2qIjBpZaTBzh83n5qiwmq6ZnfaUn+VbQAdYhEfEOn3pLJ7P jqQwWwCadP2svf2cotKCDzMQ2Z3ZJeqX9tZU2xKGRWT1tKTfhEnLayDFB/nfd9EpQOdT sllItaDF3SUT9xf8eq3/N5G6UlsQ7frFe/CuOvTNAAKWpn8/cHz7Y3FA+PVPVwUzBbzC wQx/14lwguCiLsrE1fesjxEug42j6utksp14QguNkkeE6rMYRmiC4x9Mp0N4y13MEbku Z6Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :arc-authentication-results; bh=aDNWcfN9PWt8+sulY/NJ5f7LuZr/SMHmUxEztoR+5TA=; b=WYZs3qmjNsTTSvZr1wD1oF1zxhyJFXAnElT6ehFHxX9EA8C9DB1J3ihzkab4ZtpKSo C6GW93bCsbRWpPYg9VZu935jwvyONYEIKndKooJ9HUT87EFUO480OBfN6o0ywe21G8KE xQiwHfQvjdMXOaV0tMxr91v1ChQZvjHn/IrqXGmif/4z/GQmyiliYUGAINiFO+f/7N5A +NK5Z/YCXUCQmqIifxVzR5ShwwrRuhVXZyfrJriIVpTLBMCm8Id7D1/BKvzaGFcCMgDw XkzqdVfSetICHHUqv9bKAcu0b4w3MPu8afTqVKm/4ghYyfzf4tCbMRRcNL1U5RHK2pu+ Pdsw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g67-v6si2291146plb.73.2018.06.06.12.23.00; Wed, 06 Jun 2018 12:23:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752672AbeFFS0j (ORCPT + 99 others); Wed, 6 Jun 2018 14:26:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:35170 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751714AbeFFS0h (ORCPT ); Wed, 6 Jun 2018 14:26:37 -0400 Received: from vmware.local.home (unknown [12.245.46.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 231602086E; Wed, 6 Jun 2018 18:26:30 +0000 (UTC) Date: Wed, 6 Jun 2018 14:26:22 -0400 From: Steven Rostedt To: Johan Hovold Cc: Viresh Kumar , kbuild test robot , linux-arch@vger.kernel.org, michal.lkml@markovi.net, linux-kernel@vger.kernel.org, arnd@arndb.de, yamada.masahiro@socionext.com, lgirdwood@gmail.com, broonie@kernel.org, rdunlap@infradead.org, x86@kernel.org, linux@armlinux.org.uk, changbin.du@intel.com, linux-sparse@vger.kernel.org, mingo@redhat.com, kbuild-all@01.org, akpm@linux-foundation.org, changbin.du@gmail.com, tglx@linutronix.de, linux-kbuild@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 2/4] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations Message-ID: <20180606142622.2338abf6@vmware.local.home> In-Reply-To: <20180606142600.GN13775@localhost> References: <1528186420-6615-3-git-send-email-changbin.du@intel.com> <201806060501.btF3aJMZ%fengguang.wu@intel.com> <20180606095714.1d3c2def@vmware.local.home> <20180606142600.GN13775@localhost> X-Mailer: Claws Mail 3.15.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 6 Jun 2018 16:26:00 +0200 Johan Hovold wrote: > Looks like the greybus code above is working as intended by checking for > unterminated string after the strncpy, even if this does now triggers > the truncation warning. Ah, yes I now see that. Thanks for pointing it out. But perhaps it should also add the "- 1" to the strncpy() so that gcc doesn't think it's a mistake. -- Steve