Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2231740imm; Thu, 7 Jun 2018 07:26:14 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIi0vTxOPeLnumYYkyx/3LO/q/QvLzYgnurN5A2k0beBxuJH9WctYPsj9LejfST2lLU89wm X-Received: by 2002:a17:902:64cf:: with SMTP id y15-v6mr2334213pli.53.1528381574688; Thu, 07 Jun 2018 07:26:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528381574; cv=none; d=google.com; s=arc-20160816; b=cjZmEXb3dUPjVyMrElLpUw2GPxjFntI1On6GaeGgFRcAXjoZvdSDy+DQGEsG4J3aHX h5DcnSpZg+9358F3xjXM37OPe48hvkKjcTM/j+C7FrB2qUEf/879k900i8y6RiM3yMnZ fsnfxkhPpGZWC4qRFW+cREd5YnKZDkJEcyYU69u+C/i094AEbggdMJ/ULdQvYROEZjAV oi74YWTDGnT4JpXMcMCaVxrQfc/3vE4+x42xsM5ebkuGQsgPxRizKbJot5DMKMbdXX+5 F0rp7TxL2wMjf+azjoU/xdRCsHE2qrQcyK9H6yM4tZtU69V7/FirOpYBOkPZpkOrqF/G umeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=s974rpAnqHREkOFaJ/dvYr1fqYjnRooEGKtOSzxER60=; b=tb0JVXt/bv/41C3a/Cq9MpKSnz5Z7FiG9xjFwsrlSKtuE52ggOFx4HPPxfyJoP4j3c TJPNkmemKqkr3qHricOK1jPX8nV/l8O1FtPY9zFpvtv7b7qaSCpd+v3Zc76kcIjSA0CX kaCBc2G7vtBbRRdiZ9Jo0SMyw4OQIjcJuOjk9HTRuhivyPJSJK3d4q2yUpExIShOz3jN hw0o7heNvBGY+1j005HbZCISYdepvnBRD15A1GWIsugVF8ATKFF6TjC67oDF7vhEasbl 5gWzbXXA5o9c9j6Iw5uXXbGeoWvhXaAuSHqpWjpa1a+bP1Uds+CSmRp+eupp/N0gqgnt +fUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k79-v6si2691252pfb.34.2018.06.07.07.26.00; Thu, 07 Jun 2018 07:26:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933398AbeFGOV7 (ORCPT + 99 others); Thu, 7 Jun 2018 10:21:59 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:39438 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933074AbeFGOJK (ORCPT ); Thu, 7 Jun 2018 10:09:10 -0400 Received: from [148.252.241.226] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fQvbA-0005dI-M2; Thu, 07 Jun 2018 15:09:08 +0100 Received: from ben by deadeye with local (Exim 4.91) (envelope-from ) id 1fQvb7-00032e-3D; Thu, 07 Jun 2018 15:09:05 +0100 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Takashi Iwai" , "Lassi Ylikojola" Date: Thu, 07 Jun 2018 15:05:21 +0100 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 225/410] ALSA: usb-audio: add implicit fb quirk for Behringer UFX1204 In-Reply-To: X-SA-Exim-Connect-IP: 148.252.241.226 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.57-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Lassi Ylikojola commit 5e35dc0338d85ccebacf3f77eca1e5dea73155e8 upstream. Add quirk to ensure a sync endpoint is properly configured. This patch is a fix for same symptoms on Behringer UFX1204 as patch from Albertto Aquirre on Dec 8 2016 for Axe-Fx II. Signed-off-by: Lassi Ylikojola Signed-off-by: Takashi Iwai Signed-off-by: Ben Hutchings --- sound/usb/pcm.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/sound/usb/pcm.c +++ b/sound/usb/pcm.c @@ -348,6 +348,15 @@ static int set_sync_ep_implicit_fb_quirk alts = &iface->altsetting[1]; goto add_sync_ep; + case USB_ID(0x1397, 0x0002): + ep = 0x81; + iface = usb_ifnum_to_if(dev, 1); + + if (!iface || iface->num_altsetting == 0) + return -EINVAL; + + alts = &iface->altsetting[1]; + goto add_sync_ep; } if (attr == USB_ENDPOINT_SYNC_ASYNC && altsd->bInterfaceClass == USB_CLASS_VENDOR_SPEC &&