Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2312862imm; Thu, 7 Jun 2018 08:36:47 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLgi5yC9FbLEH3gfX8NI21REMNjsRktYfoFT8VtcDAsfUiPHVI2605mOy/O25cwO97Ccvxt X-Received: by 2002:a65:4607:: with SMTP id v7-v6mr1993519pgq.31.1528385807289; Thu, 07 Jun 2018 08:36:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528385807; cv=none; d=google.com; s=arc-20160816; b=NfKe0R29qsxljlla6GstBgA6mlPh1rJum76Ml+fLwU6j9wUhDMZWRS/Ww8IJcN6oa4 OQylzXRLfGWDKEaFY894tD7+Uah/hSpE3i/KAI/TSEbIZg7Rc/swoUJNvtXPxP7WOah+ FSHdSf0fmVEXio1unrEzxwarh8zKaTChtan3VC36ykvmqy7LvMMpEGNIx+g23Z26aJJ6 l862AYKuxTmOsy5U0QDoKdNnFpQ5np+CtuVudAyDWEwCxVr29HTBqRf5OTX7IYXHAWwq j+9/Wd5ORi8f/mw/J7U03xUbcSnqJTZZy056mX+4QnklBSjwbRBj5KwGkI6BiaxSIdkp KHMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=tH+6I7PJmD9CQZ/JBJu1zCJEOyXBjyyExvClY4AZD14=; b=kVPzXuWdL/lgmwsiuC3KlBLA10ywXtl5lsECuDJxia3o8R6UBj8QQS1XeG+tjqa263 qspxnx4imKeSmqxf5/eloRuQwMdpcaMJ8M/PzuQhM4FUlDMFz7mZUYEYlq8j6BxT5YPx 6PADf8kh99q0rkBz9mf1/kBJWdDVO+yE2dJ4Dx6GMTj3w7qKhzCrYZm1rpFQFAnqkHLx G30FWc5n0iw4VaBOQ59eZvK7t2h7sgB5HbRETwQND/VAD6FIDVClVoKsqD3pg79ZLs5C 7DDU2O+mzkRfUA1IkrMdWH21eR8es0Cupil1TrSL7T6q2xU4+DBxs1VLfrHTxXyOFQMJ Qx5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p9-v6si52148234pls.460.2018.06.07.08.36.32; Thu, 07 Jun 2018 08:36:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933822AbeFGOmi (ORCPT + 99 others); Thu, 7 Jun 2018 10:42:38 -0400 Received: from mga17.intel.com ([192.55.52.151]:61237 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933716AbeFGOmb (ORCPT ); Thu, 7 Jun 2018 10:42:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2018 07:42:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,486,1520924400"; d="scan'208";a="235505947" Received: from 2b52.sc.intel.com ([143.183.136.51]) by fmsmga006.fm.intel.com with ESMTP; 07 Jun 2018 07:42:30 -0700 From: Yu-cheng Yu To: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , "H.J. Lu" , Vedvyas Shanbhogue , "Ravi V. Shankar" , Dave Hansen , Andy Lutomirski , Jonathan Corbet , Oleg Nesterov , Arnd Bergmann , Mike Kravetz Cc: Yu-cheng Yu Subject: [PATCH 4/7] x86/cet: add arcp_prctl functions for indirect branch tracking Date: Thu, 7 Jun 2018 07:38:52 -0700 Message-Id: <20180607143855.3681-5-yu-cheng.yu@intel.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180607143855.3681-1-yu-cheng.yu@intel.com> References: <20180607143855.3681-1-yu-cheng.yu@intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Signed-off-by: H.J. Lu Signed-off-by: Yu-cheng Yu --- arch/x86/include/asm/cet.h | 1 + arch/x86/include/uapi/asm/prctl.h | 1 + arch/x86/kernel/cet_prctl.c | 54 ++++++++++++++++++++++++++++++++++++--- arch/x86/kernel/elf.c | 12 ++++++--- arch/x86/kernel/process.c | 1 + 5 files changed, 62 insertions(+), 7 deletions(-) diff --git a/arch/x86/include/asm/cet.h b/arch/x86/include/asm/cet.h index d07bdeb27db4..5b71a2b44eb1 100644 --- a/arch/x86/include/asm/cet.h +++ b/arch/x86/include/asm/cet.h @@ -19,6 +19,7 @@ struct cet_stat { unsigned int ibt_enabled:1; unsigned int locked:1; unsigned int exec_shstk:2; + unsigned int exec_ibt:2; }; #ifdef CONFIG_X86_INTEL_CET diff --git a/arch/x86/include/uapi/asm/prctl.h b/arch/x86/include/uapi/asm/prctl.h index f9965403b655..fef476d2d2f6 100644 --- a/arch/x86/include/uapi/asm/prctl.h +++ b/arch/x86/include/uapi/asm/prctl.h @@ -20,6 +20,7 @@ #define ARCH_CET_EXEC 0x3004 #define ARCH_CET_ALLOC_SHSTK 0x3005 #define ARCH_CET_PUSH_SHSTK 0x3006 +#define ARCH_CET_LEGACY_BITMAP 0x3007 /* * Settings for ARCH_CET_EXEC diff --git a/arch/x86/kernel/cet_prctl.c b/arch/x86/kernel/cet_prctl.c index 326996e2ea80..948f7ba98dc2 100644 --- a/arch/x86/kernel/cet_prctl.c +++ b/arch/x86/kernel/cet_prctl.c @@ -19,6 +19,7 @@ * ARCH_CET_EXEC: set default features for exec() * ARCH_CET_ALLOC_SHSTK: allocate shadow stack * ARCH_CET_PUSH_SHSTK: put a return address on shadow stack + * ARCH_CET_LEGACY_BITMAP: allocate legacy bitmap */ static int handle_get_status(unsigned long arg2) @@ -28,8 +29,12 @@ static int handle_get_status(unsigned long arg2) if (current->thread.cet.shstk_enabled) features |= GNU_PROPERTY_X86_FEATURE_1_SHSTK; + if (current->thread.cet.ibt_enabled) + features |= GNU_PROPERTY_X86_FEATURE_1_IBT; if (current->thread.cet.exec_shstk == CET_EXEC_ALWAYS_ON) cet_exec |= GNU_PROPERTY_X86_FEATURE_1_SHSTK; + if (current->thread.cet.exec_ibt == CET_EXEC_ALWAYS_ON) + cet_exec |= GNU_PROPERTY_X86_FEATURE_1_IBT; shstk_size = current->thread.cet.exec_shstk_size; if (in_compat_syscall()) { @@ -94,9 +99,18 @@ static int handle_set_exec(unsigned long arg2) return -EPERM; } + if (features & GNU_PROPERTY_X86_FEATURE_1_IBT) { + if (!cpu_feature_enabled(X86_FEATURE_IBT)) + return -EINVAL; + if ((current->thread.cet.exec_ibt == CET_EXEC_ALWAYS_ON) && + (cet_exec != CET_EXEC_ALWAYS_ON)) + return -EPERM; + } + if (features & GNU_PROPERTY_X86_FEATURE_1_SHSTK) current->thread.cet.exec_shstk = cet_exec; - + if (features & GNU_PROPERTY_X86_FEATURE_1_IBT) + current->thread.cet.exec_ibt = cet_exec; current->thread.cet.exec_shstk_size = shstk_size; return 0; } @@ -167,9 +181,36 @@ static int handle_alloc_shstk(unsigned long arg2) return 0; } +static int handle_bitmap(unsigned long arg2) +{ + unsigned long addr, size; + + if (current->thread.cet.ibt_enabled) { + if (!current->thread.cet.ibt_bitmap_addr) + cet_setup_ibt_bitmap(); + addr = current->thread.cet.ibt_bitmap_addr; + size = current->thread.cet.ibt_bitmap_size; + } else { + addr = 0; + size = 0; + } + + if (in_compat_syscall()) { + if (put_user(addr, (unsigned int __user *)arg2) || + put_user(size, (unsigned int __user *)arg2 + 1)) + return -EFAULT; + } else { + if (put_user(addr, (unsigned long __user *)arg2) || + put_user(size, (unsigned long __user *)arg2 + 1)) + return -EFAULT; + } + return 0; +} + int prctl_cet(int option, unsigned long arg2) { - if (!cpu_feature_enabled(X86_FEATURE_SHSTK)) + if (!cpu_feature_enabled(X86_FEATURE_SHSTK) && + !cpu_feature_enabled(X86_FEATURE_IBT)) return -EINVAL; switch (option) { @@ -181,7 +222,8 @@ int prctl_cet(int option, unsigned long arg2) return -EPERM; if (arg2 & GNU_PROPERTY_X86_FEATURE_1_SHSTK) cet_disable_free_shstk(current); - + if (arg2 & GNU_PROPERTY_X86_FEATURE_1_IBT) + cet_disable_ibt(); return 0; case ARCH_CET_LOCK: @@ -197,6 +239,12 @@ int prctl_cet(int option, unsigned long arg2) case ARCH_CET_PUSH_SHSTK: return handle_push_shstk(arg2); + /* + * Allocate legacy bitmap and return address & size to user. + */ + case ARCH_CET_LEGACY_BITMAP: + return handle_bitmap(arg2); + default: return -EINVAL; } diff --git a/arch/x86/kernel/elf.c b/arch/x86/kernel/elf.c index a3995c8c2fc2..c2a89f3c7186 100644 --- a/arch/x86/kernel/elf.c +++ b/arch/x86/kernel/elf.c @@ -230,10 +230,14 @@ int arch_setup_features(void *ehdr_p, void *phdr_p, } if (cpu_feature_enabled(X86_FEATURE_IBT)) { - if (ibt) { - err = cet_setup_ibt(); - if (err < 0) - goto out; + int exec = current->thread.cet.exec_ibt; + + if (exec != CET_EXEC_ALWAYS_OFF) { + if (ibt || (exec == CET_EXEC_ALWAYS_ON)) { + err = cet_setup_ibt(); + if (err < 0) + goto out; + } } } diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 9bec164e7958..c69576b4abd1 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -801,6 +801,7 @@ long do_arch_prctl_common(struct task_struct *task, int option, case ARCH_CET_EXEC: case ARCH_CET_ALLOC_SHSTK: case ARCH_CET_PUSH_SHSTK: + case ARCH_CET_LEGACY_BITMAP: return prctl_cet(option, cpuid_enabled); } -- 2.15.1