Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2367097imm; Thu, 7 Jun 2018 09:26:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIjKidH5AWBtA0YRs83CWEi6o2Weg39OhRQOpgYcjOVbDjosu7UsONX19BdhcyPA3xya/If X-Received: by 2002:a62:9804:: with SMTP id q4-v6mr2402862pfd.65.1528388793187; Thu, 07 Jun 2018 09:26:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528388793; cv=none; d=google.com; s=arc-20160816; b=YnvpsvXCQHJ/uH2z9rcwu6LmKMxM28yfwqUW87BlbdeQTad6wkc3uCUb2UOmqNCzJR uo3qPrDE+73FP5fuxXxJfQ/mbpdgWiQuTgoaXtJMW+MdOShl6d+F2pPXzdczyc82NjZ/ WUCmsLwTfF2xdtgl14P+oM8CDwXKQ7nvVuz3xq4195QKi4Au3DtaSBZrAtcXBFcMNKQf Akh8P8FhhinFUpCgb1CV7GSknhDlzP+wZvmhtAFIvRPJgjQUz/fPec8oFn2SI7x71GER H608sd1d/gqCvt/pZ9Ant1zyUZovDdNxmi9PEeIPw7PDxiyPMWSRngOcjNUf3nTN4S2a 6MIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=LK5JiWA/S7zN3MYon6qw81gIE832QR6M1EnwXRTCtIQ=; b=VIK2xtmcjRwHoU7ymohJid+QPCr3xcztC/URNkEUfRsr093RvNRW+JVnPG8OHZUjqo 6AqM8jFWNw+Ez3SfZetB6oJIEnUlfERXFfw2isZcKmrp+6jiqAMiygU1BI32O61EwCwe qyMhcsvmapnj106+oMTLS61lYUBgVrEelngpzI0WIsX2H7ea7goxmra12p0eJSOB9qq8 IzrS6s2QC7M4KINUupIq01BCd6W4ecmIUPFjxDj4Bq11dV9f/Tq0OmogCBekjTzrsQfA BN4kWvtEb4s5lJDUsWiTfnFtMMqWC4EUhhZtY8hrs8i1YlkTltyHZp2TvSvGgX5H3vXe ayDg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23-v6si31331405pfe.318.2018.06.07.09.26.18; Thu, 07 Jun 2018 09:26:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932615AbeFGNUa (ORCPT + 99 others); Thu, 7 Jun 2018 09:20:30 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:40310 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932568AbeFGNU2 (ORCPT ); Thu, 7 Jun 2018 09:20:28 -0400 Received: from fsav403.sakura.ne.jp (fsav403.sakura.ne.jp [133.242.250.102]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id w57DJFOt091278; Thu, 7 Jun 2018 22:19:15 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav403.sakura.ne.jp (F-Secure/fsigk_smtp/530/fsav403.sakura.ne.jp); Thu, 07 Jun 2018 22:19:15 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/530/fsav403.sakura.ne.jp) Received: from [192.168.1.8] (softbank126074194044.bbtec.net [126.74.194.44]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id w57DJ8oq091222 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Jun 2018 22:19:14 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: INFO: task hung in blk_queue_enter To: Ming Lei , Ming Lei Cc: Jens Axboe , Bart Van Assche , Dmitry Vyukov , Linux Kernel Mailing List , linux-block , Johannes Thumshirn , alan.christopher.jenkins@gmail.com, syzbot+c4f9cebf9d651f6e54de@syzkaller.appspotmail.com, "Martin K. Petersen" , Dan Williams , Christoph Hellwig , Oleksandr Natalenko , martin@lichtvoll.de, Hannes Reinecke , syzkaller-bugs@googlegroups.com, Ross Zwisler , Keith Busch , "open list:EXT4 FILE SYSTEM" References: <25708e84-6f35-04c3-a2e4-6854f0ed9e78@I-love.SAKURA.ne.jp> <201806050027.w550RfJl010157@www262.sakura.ne.jp> <20180605004128.GA28826@ming.t460p> From: Tetsuo Handa Message-ID: <927ef9f9-4f4d-185e-b86f-10bd18fa92d4@i-love.sakura.ne.jp> Date: Thu, 7 Jun 2018 22:19:06 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2018/06/07 12:29, Ming Lei wrote: >> The vfs_fsync() isn't necessary in loop_update_dio() since both >> generic_file_write_iter() and generic_file_read_iter() can handle >> buffered io vs dio well. >> >> I will send one patch to remove the vfs_sync() later. > > Hi Tetsuo, > > The issue might be fixed by removing this vfs_sync(), but I'd like to > understand the idea behind since vfs_sync() shouldn't have caused > any IO to this loop queue. > > I also tried to do the test via the following c syzbot, but can't reproduce > it yet after running it for several hours. > > https://syzkaller.appspot.com/x/repro.c?id=4727023951937536 > > Could you share us how you reproduce it? I just reported that syzbot started hitting vfs_sync() case. I haven't succeeded reproducing vfs_sync() case in my environment. But in general, I modify "any reproducer provided by syzbot that loops forever" to call exit() if open() etc. failed, for continuing the loop unlikely helps after hitting "Too many open files" error. res = syscall(__NR_memfd_create, 0x200002c0, 0); if (res != -1) r[1] = res; + else + exit(1); Thus, I restart the reproducer in a loop from shell rather than keep running for hours. while :; do echo -n .; ./a.out; done