Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2469158imm; Thu, 7 Jun 2018 11:06:14 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKzztCOctkMjnFP06nsHPthzsMp3VIYttZu+MEB5r0SWrea4ByLkxV+ZcJmHMA9qpEOoG6I X-Received: by 2002:a62:9385:: with SMTP id r5-v6mr2726586pfk.59.1528394774636; Thu, 07 Jun 2018 11:06:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528394774; cv=none; d=google.com; s=arc-20160816; b=ah/imqsRhtNEzc2ulzHPf2Qxccy8pE+g/vVbLwMVBqDM/3nxF6bzp3qNNGmHWPG+4X oLlMvcQbas7vBC0YnSPW6jPY7YXD1PDsVFx5TO8gK5CjFOoFQqCgztKEbrlsOH+eEMsP uP2/p6Li4hdMpLPN6ngmsvUaau/op4NBnJJaRiBLCMNLZ+AIwfgmcd85+jpp4YKcpbjt tb8nV9Yoh+UB/cuWLPyn5LbFo+AhtiF759TmJt+MDHyt/xLruXKwGKXVzY0WlfytZ1Hi bFA0heC3uqRZt1CTFKhvG7vQEzNvn/2Qym349rhx9UbmtYeGyCgWo9o0id9jLHGWBe2B WyJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:subject:message-id:date:cc:to :from:mime-version:content-transfer-encoding:content-disposition :arc-authentication-results; bh=Oysv6SdOYgZuEw0sHh5M+2pzLt0U7npIAVYJzEbFHKo=; b=JvtBYYFX1xW7LeuIsLxf0Jt4FaslOeGGl7GP3Y93dBGvTH78JiNh2q4CJ/JATaLBuF lhKdUVpQ5tzQIk+78Cv1tAOJzewv45zGHBlNX6giuZetrNm1yItUV2AAA++y7PWqH9/X UqVgqnmnDTjQqhug/fQwqgpJVwULCtIeOpdjcbOvhMovSvMeEzD1uZpYsQoDCzRZwAha HIQpVglDKNuAl8URktP9sEp2Vd6zOcSvAsD66lSSEc8AURMharAX4Ks43PaMMbLbnvKp +++F/E3mnMr2T5BT7+33gUO9Gs4vIewPMDdXWAqUhs6cxz3SkaN8wdDTdpJwDiO+l50K rvNg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3-v6si52752365pld.309.2018.06.07.11.06.00; Thu, 07 Jun 2018 11:06:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935595AbeFGO7B (ORCPT + 99 others); Thu, 7 Jun 2018 10:59:01 -0400 Received: from shadbolt.e.decadent.org.uk ([88.96.1.126]:41235 "EHLO shadbolt.e.decadent.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935471AbeFGO65 (ORCPT ); Thu, 7 Jun 2018 10:58:57 -0400 Received: from [148.252.241.226] (helo=deadeye) by shadbolt.decadent.org.uk with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1fQvbs-0005Zm-N7; Thu, 07 Jun 2018 15:09:52 +0100 Received: from ben by deadeye with local (Exim 4.91) (envelope-from ) id 1fQvb1-0002pb-Hl; Thu, 07 Jun 2018 15:08:59 +0100 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 From: Ben Hutchings To: linux-kernel@vger.kernel.org, stable@vger.kernel.org CC: akpm@linux-foundation.org, "Theodore Ts'o" , "Zhouyi Zhou" Date: Thu, 07 Jun 2018 15:05:21 +0100 Message-ID: X-Mailer: LinuxStableQueue (scripts by bwh) Subject: [PATCH 3.16 104/410] ext4: save error to disk in __ext4_grp_locked_error() In-Reply-To: X-SA-Exim-Connect-IP: 148.252.241.226 X-SA-Exim-Mail-From: ben@decadent.org.uk X-SA-Exim-Scanned: No (on shadbolt.decadent.org.uk); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.16.57-rc1 review patch. If anyone has any objections, please let me know. ------------------ From: Zhouyi Zhou commit 06f29cc81f0350261f59643a505010531130eea0 upstream. In the function __ext4_grp_locked_error(), __save_error_info() is called to save error info in super block block, but does not sync that information to disk to info the subsequence fsck after reboot. This patch writes the error information to disk. After this patch, I think there is no obvious EXT4 error handle branches which leads to "Remounting filesystem read-only" will leave the disk partition miss the subsequence fsck. Signed-off-by: Zhouyi Zhou Signed-off-by: Theodore Ts'o Signed-off-by: Ben Hutchings --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -678,6 +678,7 @@ __acquires(bitlock) } ext4_unlock_group(sb, grp); + ext4_commit_super(sb, 1); ext4_handle_error(sb); /* * We only get here in the ERRORS_RO case; relocking the group