Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Jun 2018 09:33:40 -0700
From:   Jakub Kicinski <jakub.kicinski@netronome.com>
To:     Kees Cook <keescook@chromium.org>
Cc:     Quentin Monnet <quentin.monnet@netronome.com>,
        Daniel Borkmann <daniel@iogearbox.net>,
        Network Development <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: nfp: bpf: perf event output helpers support
Message-ID: <20180607093340.1742a5d1@cakuba.netronome.com>
In-Reply-To: <CAGXu5jJq774LZY1xUCKxG3Z4MkJ_JBJP7veB5gUCy4meb_PtSA@mail.gmail.com>
References: <CAGXu5jJq774LZY1xUCKxG3Z4MkJ_JBJP7veB5gUCy4meb_PtSA@mail.gmail.com>
Organization: Netronome Systems, Ltd.
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 6 Jun 2018 22:15:04 -0700, Kees Cook wrote:
> > +       rcu_read_lock();
> > +       if (!rhashtable_lookup_fast(&bpf->maps_neutral, &map,
> > +                                   nfp_bpf_maps_neutral_params)) {
> > +               rcu_read_unlock();
> > +               pr_warn("perf event: dest map pointer %px not recognized, dropping event\n",
> > +                       map);  
> 
> Please don't use %px on kernel pointers unless you absolutely have
> to[1]. It seems like this value wouldn't be actionable here, so likely
> it's best to just remove its use entirely.

We're using kernel pointer as an opaque handle when communicating with
the device.  We need the actual value to correlate things.  Maybe I used
the %px slightly out of spite there, because I forgot %p is now useless
and wasted half an hour on debugging an endian issue :S

This message can only really trigger when root loads a specific BPF map
onto the device and FW is buggy.  Can I fix it in -next?  I'm making
changes to this part of the code anyway.