Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2519772imm; Thu, 7 Jun 2018 12:02:33 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJFlcyTVzwqPBkWLLk/0TssXYVdCl5HWcgD1mwajomTdpGLeSpOq8lqPf6SrwN3Rui0CLKc X-Received: by 2002:a17:902:ab8b:: with SMTP id f11-v6mr3171813plr.372.1528398153713; Thu, 07 Jun 2018 12:02:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528398153; cv=none; d=google.com; s=arc-20160816; b=rHINMcoqpN2NcKxvTJ/bP3+PT1uvqR9b14nvNEUwE0BHELPrxh2MQTDJsayDBvDfFO N59lu5VGhneY+NSG9WEB2Fcjv0yR+wGP3QxoNLwhiu5/kml/KatCGwPpCyxMRtn8up1F f+AN9OUk/T1bu1LT44lacghTbnLsyJ9TFyCMxSdVvLRtCRVNqrRACk9sbq2bNPXfmAVE 6/7g0qz9PTNgA+NPZZE5sfoEgPjtO6BFrpRoqQufK+9m2QxmSFVDkB/6kdEQPoq43sou RHi2uKml0qI+YW1JOt3DKdd8340dlt2JLmQsZHjT+2SlGW42yfci8FH4K/2xeEAhXpQ0 1OKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=TOVnWm57yoIbB9pxlLYDIvtDjEclImBSZPE9JW+WBcU=; b=OEx+viaKdkXH+ebNmHiWNfMaWUmn6RWts0l7oIAXvfnHEtKJpdC9RSOeVljcpqshwl xu3SAzq47wZhusNQQTDj9tpPiGtbzb98pifo6zDZf5lZteQ3F83dD4K5ZgggY83SXxMh 1/QNKH26Q+lxX7WQ2IO4b9AG3Q6BUdg20Q17PaTvarYZYtblgBs2wwYhwazN3nK5O0z4 lynRsKuF2C2e8VSbqh/eiu8+mjdV4jamkccLSLSBiW2wmtLrfDCTOpykbaOYFrCehBJ/ pHoKqQhkawkH1hCAeSUJbFj1T0iqckjA78he0fZgtdwX4DmgW3b8+k+6C52qFPTqiTIR mRpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wqQu698V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o16-v6si17496754pgd.12.2018.06.07.12.02.16; Thu, 07 Jun 2018 12:02:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=wqQu698V; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933416AbeFGQnW (ORCPT + 99 others); Thu, 7 Jun 2018 12:43:22 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56954 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932523AbeFGQnV (ORCPT ); Thu, 7 Jun 2018 12:43:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=TOVnWm57yoIbB9pxlLYDIvtDjEclImBSZPE9JW+WBcU=; b=wqQu698VmCAQSJUSQ/1Rme1eJ9tYeRWuXXRHUiIpk3dew/lFWl8Qni0anCSaJkLYQ/ays2htURuXT1rWYgNeipOJFBCSGCD+nKyqtvJxwvT1LwBibYShgCAz6CbiTBeQW+Iz40Ppc3Igy/9pPYwkpSCZIyYuVGWh3ZLCJ0jHjzs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fQy0E-0001bL-GT; Thu, 07 Jun 2018 18:43:10 +0200 Date: Thu, 7 Jun 2018 18:43:10 +0200 From: Andrew Lunn To: Brandon Maier Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com, kristopher.cory@rockwellcollins.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] net: phy: xgmiitorgmii: Check read_status results Message-ID: <20180607164310.GB25513@lunn.ch> References: <20180607155348.149665-1-brandon.maier@rockwellcollins.com> <20180607155348.149665-3-brandon.maier@rockwellcollins.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180607155348.149665-3-brandon.maier@rockwellcollins.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 07, 2018 at 10:53:48AM -0500, Brandon Maier wrote: > We're ignoring the result of the attached phy device's read_status(). > Return it so we can detect errors. > > Signed-off-by: Brandon Maier Reviewed-by: Andrew Lunn Andrew