Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2520809imm; Thu, 7 Jun 2018 12:03:21 -0700 (PDT) X-Google-Smtp-Source: ADUXVKIuExZgiweAYocL1DM+fhNceCgPhJDcXDmgzS3NrEWtaFj8q1PyUcXWTGFiEOatNCm0ekj6 X-Received: by 2002:a62:a30e:: with SMTP id s14-v6mr2915688pfe.168.1528398201056; Thu, 07 Jun 2018 12:03:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528398201; cv=none; d=google.com; s=arc-20160816; b=yTgghq/l1JWvjc2rdJIrmeKGjubiABLsKlhrMik9/E5wwfDbvVoGb3ys/wFb79nmGk 4kglsP8IjKwKRKiiQxEcuqcEFWOy5sdYtc2V3XhCPJ02uSNo+3UCL3hbyPc23cXOvZzW E20R9/9gZ1LBF/oY2Kc8coWbLlOQCwq6wnhSVA9OWl/PSxtPvtJFoJY8Q0UBt1A+r2OX THjYJeft/e7VZhsOcD1HqxnEtP2oKyFP0M4UweOHG16bmNV7O4T2XRKdLhOXEDnMv6QV wZmhNlExe/45q/TyPTTllEiRpNAyU7H3hicCwf+7F53kA9VxYvrBfyBoQCNoNZb1+Xw7 tgoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=TLlkhZw+XWxGNeMnXy/Gi+jy3pYmYwWbVwRtmgHi6YM=; b=CETl8iEkJsQC9ay8qHuYdl3aYTCnAF8PQZNY6E1wsif4MJ+N+IEM16/Lfd3Sxqurhc SDMYKayDeS/QbAWuKJ3LK34/uzWYGjznIXlI/TMRkWOYnT+0hgGzSiQEOlVVPlXIx18+ idjfID5C4O0hBITUtYBPDteJhgDx49lQtKUDBQhYeK8KbrvJRGRVHWN4aNNY1ca9n/H9 nyo2Qemo2zosVE7/+dV1pm9lG9uhXO2cLMQvN0MR3B1M73Qdjr6uT38SvcMHdX7yK5gE lCusDV2oFGbDMHnsRufMWpYhglRGwtr1tj3tDGJQ5QYE2EQV/fAYxVNyv4fz18uYT+zW Na+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EuSeYG7i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a3-v6si32139526pll.412.2018.06.07.12.03.06; Thu, 07 Jun 2018 12:03:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lunn.ch header.s=20171124 header.b=EuSeYG7i; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933994AbeFGQyL (ORCPT + 99 others); Thu, 7 Jun 2018 12:54:11 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:56976 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933743AbeFGQyI (ORCPT ); Thu, 7 Jun 2018 12:54:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=TLlkhZw+XWxGNeMnXy/Gi+jy3pYmYwWbVwRtmgHi6YM=; b=EuSeYG7inf7A1ax0C3JzggnZ/6l8vqAqvcWE0sMIXhX3Xz94KrcUHNyMM22QnBetHMT+DmpsrMpEIp3k6UrfWS6y8dcPdHLnoRl9Ra4QOGOIx6A6OUm+hglr92gO4djOt30pwim6VY+Mgak/fg+HkWc/7K+rpAA2xvkkH4zkA1E=; Received: from andrew by vps0.lunn.ch with local (Exim 4.84_2) (envelope-from ) id 1fQyAi-0001hD-Jg; Thu, 07 Jun 2018 18:54:00 +0200 Date: Thu, 7 Jun 2018 18:54:00 +0200 From: Andrew Lunn To: Brandon Maier Cc: netdev@vger.kernel.org, f.fainelli@gmail.com, davem@davemloft.net, michal.simek@xilinx.com, clayton.shotwell@rockwellcollins.com, kristopher.cory@rockwellcollins.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] net: phy: Check phy_driver ready before accessing Message-ID: <20180607165400.GE25513@lunn.ch> References: <20180607155348.149665-1-brandon.maier@rockwellcollins.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180607155348.149665-1-brandon.maier@rockwellcollins.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 07, 2018 at 10:53:46AM -0500, Brandon Maier wrote: > Since a phy_device is added to the global mdio_bus list during > phy_device_register(), but a phy_device's phy_driver doesn't get > attached until phy_probe(). It's possible of_phy_find_device() in > xgmiitorgmii will return a valid phy with a NULL phy_driver. Leading to > a NULL pointer access during the memcpy(). Hi Brandon FYI: net-next is closed at the moment. Please resubmit these in two weeks time. Andrew