Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp2529711imm;
        Thu, 7 Jun 2018 12:11:36 -0700 (PDT)
X-Google-Smtp-Source: ADUXVKJKVS4ouXzickUH/StMS8M9g4e6wvb56uK3cNEwVAC0YHwG/Ip0rQvuYdScuzxbIms8Ps0b
X-Received: by 2002:a17:902:6686:: with SMTP id e6-v6mr3254517plk.35.1528398696297;
        Thu, 07 Jun 2018 12:11:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1528398696; cv=none;
        d=google.com; s=arc-20160816;
        b=e92P6ybJPFeVroNRW88ubhY0nIj+vjqoQsJLXDCpaFeD+TVdDkXm3SBAdEGC/3unXg
         GLxMwrX3LoI/ttvDvQkeUKvVH3tr43VuAZyDkbcQSrW6N18uPo0gmtvXiwuO0sT+5/V9
         UG9XrFadtWbdTAVCc2o78/x2c/UlVXkuqpfr+2de/91DHByYXU/n32ZLL3XSwJ38iJaj
         3gZR7eS/vJfav3MDWYbfrBie5evv5rfnshx9YXpdClWztQ1vqh8evDBl0to7rmrsmd9S
         BVzwBT2uFXDTtUDHfoXkxcw6756jYejMfaYC2D8t1xGZmhxVdx7xCNqzg/uZZbqSOfeh
         GiMQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature
         :arc-authentication-results;
        bh=hX3733VGSY4FFzFLHD+C9KpJSaq6Zz0EijhtW1HSiYY=;
        b=mXXvOKc0k0fOGJj+RVCQwfahKa0HMkD73CEboDd6KQc0aoERxU4cKZuS235mftNfRj
         J1mrP3vvqCpN7BEkF44Uln/21QhlRoVBrbInwxlkL70gpY+6SsdZGsDjX8SDfLK29fdO
         xglLCaDkMuQgw4E6bE6Z6csbzmKeDr9PW9likL/1OjwoqPp+g7SJdRvnyC1DHQcYJz1W
         8xjEpd1xf3PdhiQuuMJtM9H52z7ln7XwlhWDLyUT/JW5tHIgwNnsV8SrUCzyCIGj/Q0Z
         yMcz+lfrga7rNLVekTfPSoMBkPynxcLNzYusVOTp66U1rSMnmvamsdEkAZEYvKsurH8k
         jkww==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Zb1bPCaj;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o3-v6si54500064pld.50.2018.06.07.12.11.22;
        Thu, 07 Jun 2018 12:11:36 -0700 (PDT)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=Zb1bPCaj;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932474AbeFGSu1 (ORCPT <rfc822;patchstalker@gmail.com>
        + 99 others); Thu, 7 Jun 2018 14:50:27 -0400
Received: from mail.kernel.org ([198.145.29.99]:37130 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932428AbeFGSuY (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Jun 2018 14:50:24 -0400
Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41])
        (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 2EF07208B1
        for <linux-kernel@vger.kernel.org>; Thu,  7 Jun 2018 18:50:24 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1528397424;
        bh=DSpF0YzzhmUXYwyh9RmNB6WdmHLyUNES3xduCMDylXE=;
        h=References:In-Reply-To:From:Date:Subject:To:Cc:From;
        b=Zb1bPCajgPlDODF+UxSkNAJtIiUe6rIrhyLaDhNsnnjSTLmoF/bttDfHb9zEgxI0Y
         HBZXs/INMU/E2sUyOrNPpcsdTzSWNO/QAxdPPfczq4stKjebXK8YclNJjX7fFGQl6n
         MchJBMmPcC7ih/6CnLcEQttGiBnw2VXBIliKvL+w=
Received: by mail-wm0-f41.google.com with SMTP id e16-v6so19781282wmd.0
        for <linux-kernel@vger.kernel.org>; Thu, 07 Jun 2018 11:50:24 -0700 (PDT)
X-Gm-Message-State: APt69E30F9j1wLWtS8tCyuTkWvrMxBx4eRizFM6fQ6GOJ/o4smEnUJLE
        8BgjC9c63aOw8LvX+JzEVzthw6ynrB0fRPciWpZG3A==
X-Received: by 2002:a1c:34c9:: with SMTP id b192-v6mr2536456wma.21.1528397422410;
 Thu, 07 Jun 2018 11:50:22 -0700 (PDT)
MIME-Version: 1.0
References: <20180607143807.3611-1-yu-cheng.yu@intel.com> <20180607143807.3611-11-yu-cheng.yu@intel.com>
In-Reply-To: <20180607143807.3611-11-yu-cheng.yu@intel.com>
From:   Andy Lutomirski <luto@kernel.org>
Date:   Thu, 7 Jun 2018 11:50:10 -0700
X-Gmail-Original-Message-ID: <CALCETrXTyXYCDJxbCA+cbzZirmMKRQq8XSS4+Lyeo_QMywdxFw@mail.gmail.com>
Message-ID: <CALCETrXTyXYCDJxbCA+cbzZirmMKRQq8XSS4+Lyeo_QMywdxFw@mail.gmail.com>
Subject: Re: [PATCH 10/10] mm: Prevent munmap and remap_file_pages of shadow stack
To:     Yu-cheng Yu <yu-cheng.yu@intel.com>
Cc:     LKML <linux-kernel@vger.kernel.org>, linux-doc@vger.kernel.org,
        Linux-MM <linux-mm@kvack.org>,
        linux-arch <linux-arch@vger.kernel.org>, X86 ML <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H. J. Lu" <hjl.tools@gmail.com>,
        "Shanbhogue, Vedvyas" <vedvyas.shanbhogue@intel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
        mike.kravetz@oracle.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 7, 2018 at 7:41 AM Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:

blocking remap_file_pages() seems reasonable.  I'm not sure what's
wrong with munmap().