Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 7 Jun 2018 15:53:09 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@kernel.org>
Cc:     Peter Zijlstra <a.p.zijlstra@chello.nl>,
        lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        David Ahern <dsahern@gmail.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Stephane Eranian <eranian@google.com>,
        Milian Wolff <milian.wolff@kdab.com>,
        Andi Kleen <andi@firstfloor.org>,
        Frederic Weisbecker <frederic@kernel.org>
Subject: Re: [PATCH 02/10] perf tools: Fix error index for pmu event parser
Message-ID: <20180607185309.GA17292@kernel.org>
References: <20180606221513.11302-1-jolsa@kernel.org>
 <20180606221513.11302-3-jolsa@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180606221513.11302-3-jolsa@kernel.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Jun 07, 2018 at 12:15:05AM +0200, Jiri Olsa escreveu:
> For events we provide specific error message we need to set
> error column index, PMU parser is missing that, adding it.
> 
> Before:
>   $ perf stat -e cycles,krava/cycles/ kill
>   event syntax error: 'cycles,krava/cycles/'
>                        \___ Cannot find PMU `krava'. Missing kernel support?
> 
> After:
>   $ perf stat -e cycles,krava/cycles/ kill
>   event syntax error: 'cycles,krava/cycles/'
>                               \___ Cannot find PMU `krava'. Missing kernel support?

Thanks, tested and applied.

- Arnaldo