Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: sparse warnings in overflow.h
To:     Kees Cook <keescook@chromium.org>, Miroslav Benes <mbenes@suse.cz>
Cc:     LKML <linux-kernel@vger.kernel.org>
References: <alpine.LSU.2.21.1806071258310.7958@pobox.suse.cz>
 <CAGXu5j+XFR7BtYPU6G4CeLFREWevN+GC1FPX1hPAYA1LRBM9Bg@mail.gmail.com>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
Message-ID: <4d2aaa98-1655-3ab8-8ce8-bf4b9c7d2dbc@rasmusvillemoes.dk>
Date:   Thu, 7 Jun 2018 21:25:09 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <CAGXu5j+XFR7BtYPU6G4CeLFREWevN+GC1FPX1hPAYA1LRBM9Bg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2018-06-07 20:35, Kees Cook wrote:
> On Thu, Jun 7, 2018 at 4:01 AM, Miroslav Benes <mbenes@suse.cz> wrote:
>>
>> Hi Kees,
>>
>> sparse (make C=1) gives me this warnings today...
>>
>> ./include/linux/overflow.h:254:13: error: undefined identifier '__builtin_mul_overflow'
>> ./include/linux/overflow.h:254:13: error: incorrect type in conditional
>> ./include/linux/overflow.h:254:13:    got void
>> ./include/linux/overflow.h:256:13: error: undefined identifier '__builtin_add_overflow'
>> ./include/linux/overflow.h:256:13: error: incorrect type in conditional
>> ./include/linux/overflow.h:256:13:    got void
>>
>> This hunk obviously fixes it, but I'm really not sure if it is a proper
>> fix.
>>
>> diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
>> index f1a7492a5cc8..15e55b89e952 100644
>> --- a/include/linux/compiler-gcc.h
>> +++ b/include/linux/compiler-gcc.h
>> @@ -344,6 +344,6 @@
>>   */
>>  #define uninitialized_var(x) x = x
>>
>> -#if GCC_VERSION >= 50100
>> +#if GCC_VERSION >= 50100 && !defined(__CHECKER__)
>>  #define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
>>  #endif
>>
>> Any idea?
> 
> Hi! Yeah, that's probably the correct approach. If the checker doesn't
> have it, the builtins need to be disabled. :)

IIRC, the problem is that sparse pretends to be the gcc sparse itself
was built with, which is obviously entirely unrelated to the C dialect
that that particular sparse version groks. Sigh. Ack to the fix above.

Rasmus