Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp313564imm; Thu, 7 Jun 2018 19:25:46 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKHWfpNwpfyvZNc28Yr3DyqQvu0dvzQx1kh/cR6G9WZUgf+/CIfg4iDB3eZHrz0N/OPTnkO X-Received: by 2002:a17:902:3081:: with SMTP id v1-v6mr4598668plb.266.1528424746247; Thu, 07 Jun 2018 19:25:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528424746; cv=none; d=google.com; s=arc-20160816; b=ssR6c27zAqomAdW2SVMcy0uCtspzaZahGUM95sXiKUHT7EKNJW/S51XM/NGZD5voL5 T78zzsowU0FlXPNleRzUZpbwwVhSg5PM8JzMj+d8ayZS1WlqpxX9ceekI2JomVTekDiL U+R2/1RblVE8I4k349wtKvWDZYPOh9Slpu+2BNCAHhvaadOLTwykjqq+pcauc8IcbJVb 9tSnZeG6lWi4DRUWj+YGwpLzJPKqmeGZi3jzLzT7b9GLLA4+h9InJNKsAEa9oj5/VL6D HR7+EeGh9XLwo/Kr+T8co5HvyU0KPojsZdI4gOmLALtXr3e5o+Hs3PZZCEODiHAn7pGN XZcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:subject:from:message-id:cc:to :arc-authentication-results; bh=Nl+VW5LRkDVhGWai9LIEFQdIBZsmRb/i9Xh/groMKLk=; b=ih/pnzAene8NkwS7j1+RJonPjc1Br0Uimrxgu6jLOVw0RVHyjpezxrMxAFGUEM1Eiu MB6Cvid+9G9Cg/jVydfp8oOeeXiqhPe1LcVPcdhb9MNBKm4jFcKWLZD3Z+TeJRW4X9Av HgrREVO+CoZijgdWdhX9//U0CyX131zgiK683JP9qio+6pS13FcNFHcbNUm5JQ0+3Ggw mWw5EsxoURdhP1czamPWdpxoesDSFbAyBPw9Baa1fuvpYx0bhLsj9FdlIDLiy0KzbwWI teeSAYGFmotCYfQSrvtAulZ5B3We1xWTG5uAN/HKR5IFZ2flLHKcbZcU3MNQBil3qBhK bwSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 142-v6si27471267pga.694.2018.06.07.19.25.23; Thu, 07 Jun 2018 19:25:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752712AbeFHCYc (ORCPT + 99 others); Thu, 7 Jun 2018 22:24:32 -0400 Received: from kvm5.telegraphics.com.au ([98.124.60.144]:58488 "EHLO kvm5.telegraphics.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752341AbeFHCY3 (ORCPT ); Thu, 7 Jun 2018 22:24:29 -0400 Received: by kvm5.telegraphics.com.au (Postfix, from userid 502) id 553FA29E59; Thu, 7 Jun 2018 22:24:28 -0400 (EDT) To: Benjamin Herrenschmidt Cc: Michael Schmitz , , , Message-Id: From: Finn Thain Subject: [PATCH v2 00/12] macintosh: Resolve various PMU driver problems Date: Thu, 7 Jun 2018 22:24:28 -0400 (EDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series of patches has the following aims. 1) Eliminate duplicated code. Linux presently has two drivers for the 68HC05-based PMU devices found in Macs: via-pmu and via-pmu68k. There's no value in having separate PMU drivers for each architecture. 2) Avoid further work on via-pmu68k that's not needed for via-pmu. 3) Fix some bugs in the via-pmu driver. 4) Enable the /dev/pmu and /proc/pmu/* userspace APIs on m68k Macs by adopting via-pmu. 5) Improve stability on early 100-series PowerBooks by loading no PMU driver at all. Neither via-pmu nor via-pmu68k supports the early M50753-based PMU device found in these models. 6) Eliminate duplicated RTC accessors for PMU and Cuda. Presently these can be found under both arch/m68k and arch/powerpc. 7) Assist the out-of-tree NuBus PowerMac port to support PMU designs shared with the m68k Mac port (e.g. PowerBooks 190 and 5300). This patch series has been regression tested on various PowerBooks (190, 520, 3400, Pismo G3) and PowerMacs (Beige G3, G5). These patches did not affect userland utilities. (Note that there is a userland- visible change to the contents of /proc/pmu/interrupts.) Changed since v1: 1) Added blank lines after 'break' statements in patch 10. 2) Improved patch description for patch 3. 3) Added reviewed-by tags. 4) Split patch 8 to make code review easier. Finn Thain (12): macintosh/via-pmu: Fix section mismatch warning macintosh/via-pmu: Add missing mmio accessors macintosh/via-pmu: Don't clear shift register interrupt flag twice macintosh/via-pmu: Enhance state machine with new 'uninitialized' state macintosh/via-pmu: Replace via pointer with via1 and via2 pointers macintosh/via-pmu: Add support for m68k PowerBooks macintosh/via-pmu: Make CONFIG_PPC_PMAC Kconfig deps explicit macintosh/via-pmu68k: Don't load driver on unsupported hardware macintosh/via-pmu: Replace via-pmu68k driver with via-pmu driver macintosh: Use common code to access RTC macintosh/via-pmu: Clean up interrupt statistics macintosh/via-pmu: Disambiguate interrupt statistics arch/m68k/configs/mac_defconfig | 2 +- arch/m68k/configs/multi_defconfig | 2 +- arch/m68k/mac/config.c | 2 +- arch/m68k/mac/misc.c | 118 +---- arch/powerpc/platforms/powermac/time.c | 74 +-- drivers/macintosh/Kconfig | 19 +- drivers/macintosh/Makefile | 1 - drivers/macintosh/adb.c | 2 +- drivers/macintosh/via-cuda.c | 34 ++ drivers/macintosh/via-pmu.c | 378 ++++++++++----- drivers/macintosh/via-pmu68k.c | 850 --------------------------------- include/linux/cuda.h | 3 + include/linux/pmu.h | 3 + include/uapi/linux/pmu.h | 2 - 14 files changed, 311 insertions(+), 1179 deletions(-) delete mode 100644 drivers/macintosh/via-pmu68k.c -- 2.16.4