Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp545905imm; Fri, 8 Jun 2018 00:54:23 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKq9o6r4/G01QjSpiU2rdclQC/cJIDPGgRw1Ig6mximnXvhOUIxgNOFRvzQwzEd3KUI92pa X-Received: by 2002:a65:6356:: with SMTP id p22-v6mr4377366pgv.20.1528444463271; Fri, 08 Jun 2018 00:54:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528444463; cv=none; d=google.com; s=arc-20160816; b=Pu4arQoXRH2cjsTLfAH1F35SxXfWo37xHvktuuYebgY2vCMYGV4FiEaXIPkXkYLn5T /MyxS5avptwY2d9jwJKWFLfh0hReZ3vqr5/7RDa0XwOiSqiCRhGUnqF/IMzaYeJnv2Yp XU+o1arCF4BB9w6UmOVFUKl3qMcAzyi6jHz9Am1M0fNssjNbRpsPOqBx8qS99dOAFTrq 9Z4h/WVFXH2cuFdwI/pO7A8cHrBfw/BppvHSnV0DsIVzloSKcvSVfhAuvTMSbvRf6PuR Enj3WgVa/gOLa1Rcr/UEYzuZ0ahn5ULgqVjXCGnPmfEfwf6M3AJILUUlLVMKdZNKMhab rR4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=hz2emXW2q76gwJrqkM27vFWOcSLcJLvZg3qaq2uqvjg=; b=jwWFM+bfiKvaS5Po8GzU/xsnUBWMRe5AmNR+JXnYriheyZ6oQz+BNuXI3zoNd2v0rY 9aa9+VSXjgYUEVzgRcl8evrGqLICc5JdUT+vxbQ/w9+/aVVeocQPSyQ5QANbzuZ7Vy3H PPtA51tDl7z/TibEdS0BKByvQI6rRdR2nVN3P3frYVs4jyRaQ+F5qHL2UI9raTC35Bys NhUNYFmzGsRRnhaHtI4IlIb/nZpSE/aXCdJEFiCpAfk9pdXXwugNvL5bIJFhkjcUz4bL EW9cq8NBh/SsNb3vjyv6KtYMMwji8uz0ATvAM7X/TC6atcATotfSeU4Ypz7l5fMLVn9D JLKQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ckEFXQXx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a24-v6si31206645pls.129.2018.06.08.00.54.09; Fri, 08 Jun 2018 00:54:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=ckEFXQXx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752857AbeFHHxi (ORCPT + 99 others); Fri, 8 Jun 2018 03:53:38 -0400 Received: from mail-pl0-f65.google.com ([209.85.160.65]:33585 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752814AbeFHHxe (ORCPT ); Fri, 8 Jun 2018 03:53:34 -0400 Received: by mail-pl0-f65.google.com with SMTP id n10-v6so7823951plp.0 for ; Fri, 08 Jun 2018 00:53:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=hz2emXW2q76gwJrqkM27vFWOcSLcJLvZg3qaq2uqvjg=; b=ckEFXQXxgwSCAGlG5ptYJyHKNUNgkUnx7q8W8VCSj0fifh3O6ZEeqZZkSYYrLs6me2 BSyJRSR6JVytt/CMlbuWFw42pc2Xt0JeoxMpBAgfcUqlV/9btRLR18r+Tb2NZcMqpdLo 9p6ITqoqYbfG2QX1OPm1O4ktp/Z+2GP1Lt5HSgTzHnip9jOgCSbuni3S6U8maWk53zO2 9H8zghUYHNACYd9puREZ/6v165DHsASxnXeTT9UENHQYKS/VFKsJUSGCWecnQ2z5UhBC fqzMS3QXxYDIk/j/o6KE5VjmcIwZU9+3Pvqa5Son6okenapng1J9zfR+wEbKWrNef32T a4Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=hz2emXW2q76gwJrqkM27vFWOcSLcJLvZg3qaq2uqvjg=; b=sQdyxfUxKjI/g4jp8ae5zikeCRmw5UWz6K83TzoYRKCnQwUryu8dfIpK+DzY/UAb0i +xMNBmD2Az2yFkKw9ABSruaUm/VsVZHS6vKtPLhDUqJ5LdENhXzSKJKFP9qJk9hxRs3U Lcjeq8V5UaX/uBfehM8R3QObiYHXQlptwrt90LStXgxdLBDYzoeCPNOB8/JE1sP0YsnC v4p4I7PSjBEQQQ0DvqdDVP/SCvP9VJa9M7ejkkeKDATzeAH6qysLFW8y/FRd2gGjtk3W JvJKQAYnmprqBxTOaPJWVL7tAeSIdLOF8Y98NJZtqXYFDz9heh9CpphHO3NNgedVBNA5 2j4g== X-Gm-Message-State: APt69E1fKhKcSsnZwLXas1fHrtJ1jvpVSd5GJMPu8Sh/VooXpb3d4wCN 3NX37QRc0J/qb9bUOHNxS/Nn8tyU48ZVrh/ub79wUIfJBPs= X-Received: by 2002:a17:902:7d09:: with SMTP id z9-v6mr5419248pll.233.1528444413527; Fri, 08 Jun 2018 00:53:33 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a17:90a:d42:0:0:0:0 with HTTP; Fri, 8 Jun 2018 00:53:12 -0700 (PDT) In-Reply-To: <1519734229.2699.6.camel@redhat.com> References: <001a114fa99028d2a10565e33df4@google.com> <1519734229.2699.6.camel@redhat.com> From: Dmitry Vyukov Date: Fri, 8 Jun 2018 09:53:12 +0200 Message-ID: Subject: Re: WARNING in smc_unhash_sk To: Davide Caratti Cc: syzbot , David Miller , LKML , linux-s390@vger.kernel.org, netdev , syzkaller-bugs , ubraun@linux.vnet.ibm.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 27, 2018 at 1:23 PM, Davide Caratti wrote: > On Fri, 2018-02-23 at 07:59 -0800, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> af3e79d29555b97dd096e2f8e36a0f50213808a8 (Tue Feb 20 18:05:02 2018 +0000) >> Merge tag 'leds_for-4.16-rc3' of >> git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds >> >> So far this crash happened 27 times on >> https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/master, >> net-next, upstream. >> C reproducer is attached. >> syzkaller reproducer is attached. >> Raw console output is attached. >> compiler: gcc (GCC) 7.1.1 20170620 >> .config is attached. >> >> IMPORTANT: if you fix the bug, please add the following tag to the commit: >> Reported-by: syzbot+3a0748c8f2f210c0ef9b@syzkaller.appspotmail.com >> It will help syzbot understand when the bug is fixed. See footer for >> details. >> If you forward the report, please keep this part and the footer. >> >> WARNING: CPU: 1 PID: 9921 at ./include/net/sock.h:638 sk_del_node_init >> include/net/sock.h:638 [inline] >> WARNING: CPU: 1 PID: 9921 at ./include/net/sock.h:638 >> smc_unhash_sk+0x335/0x450 net/smc/af_smc.c:90 >> Kernel panic - not syncing: panic_on_warn set ... >> >> CPU: 1 PID: 9921 Comm: syzkaller089677 Not tainted 4.16.0-rc2+ #324 >> Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS >> Google 01/01/2011 >> Call Trace: >> __dump_stack lib/dump_stack.c:17 [inline] >> dump_stack+0x194/0x24d lib/dump_stack.c:53 >> panic+0x1e4/0x41c kernel/panic.c:183 >> __warn+0x1dc/0x200 kernel/panic.c:547 >> report_bug+0x211/0x2d0 lib/bug.c:184 >> fixup_bug.part.11+0x37/0x80 arch/x86/kernel/traps.c:178 >> fixup_bug arch/x86/kernel/traps.c:247 [inline] >> do_error_trap+0x2d7/0x3e0 arch/x86/kernel/traps.c:296 >> do_invalid_op+0x1b/0x20 arch/x86/kernel/traps.c:315 >> invalid_op+0x58/0x80 arch/x86/entry/entry_64.S:957 >> RIP: 0010:sk_del_node_init include/net/sock.h:638 [inline] >> RIP: 0010:smc_unhash_sk+0x335/0x450 net/smc/af_smc.c:90 >> RSP: 0018:ffff8801b639f198 EFLAGS: 00010293 >> RAX: ffff8801b684a340 RBX: 1ffff10036c73e37 RCX: ffffffff85a3f1f5 >> RDX: 0000000000000000 RSI: dffffc0000000000 RDI: 1ffff10036c73e3b >> RBP: ffff8801b639f280 R08: dffffc0000000000 R09: 0000000000000004 >> R10: ffff8801b639f050 R11: 0000000000000004 R12: ffff8801b639f258 >> R13: ffffffff87669b40 R14: ffff8801c08d57c0 R15: 1ffff10036c73e3b >> smc_release+0x321/0x580 net/smc/af_smc.c:148 >> sock_release+0x8d/0x1e0 net/socket.c:595 >> sock_close+0x16/0x20 net/socket.c:1149 >> __fput+0x327/0x7e0 fs/file_table.c:209 >> ____fput+0x15/0x20 fs/file_table.c:243 >> task_work_run+0x199/0x270 kernel/task_work.c:113 >> exit_task_work include/linux/task_work.h:22 [inline] >> do_exit+0x9bb/0x1ad0 kernel/exit.c:865 >> do_group_exit+0x149/0x400 kernel/exit.c:968 >> get_signal+0x73a/0x16d0 kernel/signal.c:2469 >> do_signal+0x90/0x1e90 arch/x86/kernel/signal.c:809 >> exit_to_usermode_loop+0x258/0x2f0 arch/x86/entry/common.c:162 >> prepare_exit_to_usermode arch/x86/entry/common.c:196 [inline] >> syscall_return_slowpath arch/x86/entry/common.c:265 [inline] >> do_syscall_64+0x6e5/0x940 arch/x86/entry/common.c:292 >> entry_SYSCALL_64_after_hwframe+0x42/0xb7 >> RIP: 0033:0x44cad9 >> RSP: 002b:00007fbf24687ce8 EFLAGS: 00000246 ORIG_RAX: 0000000000000007 >> RAX: 0000000000000001 RBX: 0000000000700024 RCX: 000000000044cad9 >> RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000020000080 >> RBP: 0000000000700020 R08: 0000000000000000 R09: 0000000000000000 >> R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 >> R13: 000000000080ef3f R14: 00007fbf246889c0 R15: 0000000000000005 >> Dumping ftrace buffer: >> (ftrace buffer empty) >> Kernel Offset: disabled >> Rebooting in 86400 seconds.. >> > > #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master Hi Davide, Any progress on this? This is syzbot top crasher at the moment with 86000+ machines crashed: https://syzkaller.appspot.com/bug?id=004b0f7b61d4901cbfecfc33de7996e8cbe0a278