Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Jun 2018 14:05:46 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Janani Sankara Babu <jananis37@gmail.com>
Cc:     gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        keescook@chromium.org, johannes.berg@intel.com,
        linux-kernel@vger.kernel.org, Rene.Hickersberger@gmx.at,
        davem@davemloft.net
Subject: Re: [PATCH 2/4] Staging:rtl8192e Fix Comparison to False is error
 prone
Message-ID: <20180608110546.bv4hcgpeppvkxipv@mwanda>
References: <1528432436-9652-1-git-send-email-jananis37@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1528432436-9652-1-git-send-email-jananis37@gmail.com>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 08, 2018 at 12:33:56AM -0400, Janani Sankara Babu wrote:
> This patch removes comparison to False(ie. bool) in the code
> 
> Signed-off-by: Janani Sankara Babu <jananis37@gmail.com>
> ---
>  drivers/staging/rtl8192e/rtl819x_BAProc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtl819x_BAProc.c b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> index 3c7ba33..ccd898a 100644
> --- a/drivers/staging/rtl8192e/rtl819x_BAProc.c
> +++ b/drivers/staging/rtl8192e/rtl819x_BAProc.c
> @@ -258,7 +258,7 @@ int rtllib_rx_ADDBAReq(struct rtllib_device *ieee, struct sk_buff *skb)
> 
>  	RT_TRACE(COMP_DBG, "====>rx ADDBAREQ from : %pM\n", dst);
>  	if (ieee->current_network.qos_data.active == 0  ||

Is .active the number of active or is it a boolean?  If it's boolean
then it should be changed to !ieee->current_network.qos_data.active
as well.

Keep your eyes open for stuff like this when you're doing checkpatch
fixes.

> -	    (ieee->pHTInfo->bCurrentHTSupport == false) ||
> +	    !(ieee->pHTInfo->bCurrentHTSupport) ||

Remove the parenthesis.

Same throughout.

regards,
dan carpenter