Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Jun 2018 14:01:29 +0100
From:   John Whitmore <arigead@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     John Whitmore <johnfwhitmore@gmail.com>,
        linux-kernel@vger.kernel.org, kstewart@linuxfoundation.org,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        colin.king@canonical.com, tglx@linutronix.de
Subject: Re: [PATCH v6 8/8] staging: rtl8192e: remove unnecessary parentheses
 - Coding Style
Message-ID: <20180608130127.koojqozbasmef2gd@linux-08lc>
References: <20180606114003.22654-1-johnfwhitmore@gmail.com>
 <20180606114003.22654-9-johnfwhitmore@gmail.com>
 <20180608121851.o7m3iihg2ibbgmxh@mwanda>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180608121851.o7m3iihg2ibbgmxh@mwanda>
User-Agent: NeoMutt/20170912 (1.9.0)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jun 08, 2018 at 03:18:51PM +0300, Dan Carpenter wrote:
> On Wed, Jun 06, 2018 at 12:40:03PM +0100, John Whitmore wrote:
> > @@ -1072,10 +1072,10 @@ void HTInitializeHTInfo(struct ieee80211_device *ieee)
> >  	pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >  
> >  	// Initialize all of the parameters related to 11n
> > -	memset((void *)(&(pHTInfo->SelfHTCap)), 0, sizeof(pHTInfo->SelfHTCap));
> > -	memset((void *)(&(pHTInfo->SelfHTInfo)), 0, sizeof(pHTInfo->SelfHTInfo));
> > -	memset((void *)(&(pHTInfo->PeerHTCapBuf)), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > -	memset((void *)(&(pHTInfo->PeerHTInfoBuf)), 0, sizeof(pHTInfo->PeerHTInfoBuf));
> > +	memset((void *)(&pHTInfo->SelfHTCap), 0, sizeof(pHTInfo->SelfHTCap));
> > +	memset((void *)(&pHTInfo->SelfHTInfo), 0, sizeof(pHTInfo->SelfHTInfo));
> > +	memset((void *)(&pHTInfo->PeerHTCapBuf), 0, sizeof(pHTInfo->PeerHTCapBuf));
> > +	memset((void *)(&pHTInfo->PeerHTInfoBuf), 0, sizeof(pHTInfo->PeerHTInfoBuf));
> 
> You should write these like so:
> 
> 	memset(&pHTInfo->PeerHTInfoBuf, 0, sizeof(pHTInfo->PeerHTInfoBuf));
> 
> The first 7 patches look fine, but can you resend this last one?
> 
> regards,
> dan carpenter
> 

I can certainly try. I've bumped it to v7 so here goes...

John