Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp966411imm; Fri, 8 Jun 2018 08:00:16 -0700 (PDT) X-Google-Smtp-Source: ADUXVKKlaMTSmxUu07fJg2lA+nC8LyKVZhDuYtqODzhZXqSOuJIMKXR6t2qlmuiRZYD/Y1ScOGe/ X-Received: by 2002:a65:4287:: with SMTP id j7-v6mr5658251pgp.144.1528470016521; Fri, 08 Jun 2018 08:00:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528470016; cv=none; d=google.com; s=arc-20160816; b=JPxhaWZQv9jmv/JXwzc8qbR4T4Bw0emmyTXTBcShvld/uWc9K86MjKFwPGTXH52TZH 2FCRpCKkMyczzmiJGT48u+jvCeIx1rViYCTij6pMBwLrZr58Aj0TBQLwWsZlbxOWNHgW 9Xft87KNktpXHUf6KY8CUQu9nl/ICsXrStIXLxqhEVzztHI9vcMUJow0u32O7YXT5vYr +Bl9jVA5g17aTHynxKaaMT0MjDX+OMDaD38ZMPskGW37qkooYPxzCRlTG3uH2JVXsvbC Obvu7s5VOzjMSkyk5SEMDZBURKai6sVOm/Sl8Cc+SZSsdb/i3dWkqBSMLVrK2AZhXFUD N/bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=AGJjJZ2+Hs8FXyumS8rYvRW6Buw7xqks/UdQpkivjBE=; b=wFr5Y4HiLhRSnEWSd1mfPAWpQ8ntTSa/gaQoijx4J0DqGqS9wMpchYpD6yv2mZ9Znr z7+Cb1sjE+CNLNY//jTTsMgVSA5GwhLu4X6eQrf4hrg0R29dIEiW+sDC/FA23fhzAwGz mW6FezfY9H293WQQkxZAD6Qm075CDPhwUjIaAIyVg207rCoebJI2RptblbJFGW5WLBDn Dk6eWDPstMObQHHmHznpCfpGIs74ek2RA9knCfh1Y9LJqd0jWzg2TCvq/fduvr9GbpSg BhVIYbj5ok7HnUHgAK9ihnMPr42VZBhWJO8TpveyeOx1O0LwgDZuAZkJfugQGOqkT67I wwQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5-v6si11834365pgs.15.2018.06.08.08.00.02; Fri, 08 Jun 2018 08:00:16 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbeFHO7a (ORCPT + 99 others); Fri, 8 Jun 2018 10:59:30 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:44180 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbeFHO72 (ORCPT ); Fri, 8 Jun 2018 10:59:28 -0400 Received: from localhost (unknown [172.58.216.148]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id A5D20133E8163; Fri, 8 Jun 2018 07:59:27 -0700 (PDT) Date: Fri, 08 Jun 2018 10:59:26 -0400 (EDT) Message-Id: <20180608.105926.600207780816212953.davem@davemloft.net> To: clabbe@baylibre.com Cc: alexandre.torgue@st.com, peppe.cavallaro@st.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-sunxi@googlegroups.com Subject: Re: [PATCH] net: stmmac: fix build failure due to missing COMMON_CLK dependency From: David Miller In-Reply-To: <1528310722-11512-1-git-send-email-clabbe@baylibre.com> References: <1528310722-11512-1-git-send-email-clabbe@baylibre.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 08 Jun 2018 07:59:28 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Corentin Labbe Date: Wed, 6 Jun 2018 18:45:22 +0000 > This patch fix the build failure on m68k; > drivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.o: In function `ipq806x_gmac_probe': > dwmac-ipq806x.c:(.text+0xda): undefined reference to `clk_set_rate' > drivers/net/ethernet/stmicro/stmmac/dwmac-rk.o: In function `rk_gmac_probe': > dwmac-rk.c:(.text+0x1e58): undefined reference to `clk_set_rate' > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.o: In function `stid127_fix_retime_src': > dwmac-sti.c:(.text+0xd8): undefined reference to `clk_set_rate' > dwmac-sti.c:(.text+0x114): undefined reference to `clk_set_rate' > drivers/net/ethernet/stmicro/stmmac/dwmac-sti.o:dwmac-sti.c:(.text+0x12c): more undefined references to `clk_set_rate' follow > Lots of stmmac platform drivers need COMMON_CLK in their Kconfig depends. > > Signed-off-by: Corentin Labbe Applied.