Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 8 Jun 2018 11:19:56 -0700
From:   Benson Leung <bleung@google.com>
To:     Arnd Bergmann <arnd@arndb.de>,
        Gwendal Grignou <gwendal@chromium.org>
Cc:     Lee Jones <lee.jones@linaro.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Benson Leung <bleung@chromium.org>,
        Gwendal Grignou <gwendal@chromium.org>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: cros_ec: remove unused __remove function
Message-ID: <20180608181956.GA110395@decatoncale.mtv.corp.google.com>
References: <20180608144834.3003465-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="VS++wcV0S1rZb1Fb"
Content-Disposition: inline
In-Reply-To: <20180608144834.3003465-1-arnd@arndb.de>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--VS++wcV0S1rZb1Fb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable


On Fri, Jun 08, 2018 at 04:48:06PM +0200, Arnd Bergmann wrote:
> This function is no longer called, so we get a harmless
> warning until it is removed as well:
>=20
> drivers/mfd/cros_ec_dev.c:265:13: error: '__remove' defined but not used =
[-Werror=3Dunused-function]
>=20
> Fixes: 3aa2177e4787 ("mfd: cros_ec: Use devm_kzalloc for private data")

Gwendal, in PATCH v2 of https://patchwork.kernel.org/patch/10439449/
you mentioned that you readded the __remove to avoid a warning when built
as a module. Can you explain what's going on?

Benson

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--VS++wcV0S1rZb1Fb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE6gYDF28Li+nEiKLaHwn1ewov5lgFAlsayMwACgkQHwn1ewov
5lhSoQ/+P+/xLWQgcMugSg+mU0KLOBdsgfYbfVVA3ya03Ymj0bfBQT4JxTbN2a82
WG14YCsDSiU+3KPDyGo9OAWTEZ4mkqaJtnxRtRjpVz/HgYnD8QfuEm0PpfVoJglJ
3yE7ClFt/g8DrxlMY5i0Lpl4/ZZVa1D8hkTcvUvdeTENItI17OnH27CWn2mVN3BU
F6XASvbTipNWGjebP4W9lYEOyU0vn9G0Jt+lUTXGJLPZfdArXR+0O1ziO0wN1JD7
FJDi6Fd9BZx1bIy9qqpK9kY1tSp57ZGzCCWFDDSZPhfXvG4QX0iWny6AhYbkS2SN
ztI3i4LiYYnKJOWEZWKHO1wO4+v2omFURzHcyKzi/p48mF46ikxLhLRl/K4ps731
GtMSM85apguL2WCygovgCI55Dlq50I2t3ma1lDESR6bCpSARhkvMvNnEu+djh6bb
4HNu1fr4bGfqSVT/UHwEQmvgns9oGB6CyRz8NhHFGRf/y2Bje7CPQPotepBqXAh/
1UG+ENgVMoLOfA4VeF/ZTLxiBcGWthlaG5lpeKi8mH7qqWBowg+A5BOnSbCd0a6Y
XtrFISZxATK28PL7dKGt+0n0xkj94LyByuZL6dI0C+6cCqYT+MolRfXu4WWj3Qt3
eCYbcp8mi3zI1VHtvvhIhiJ5/aWaWCbV4+bd4bxBX6FohLngwuk=
=ft7/
-----END PGP SIGNATURE-----

--VS++wcV0S1rZb1Fb--