Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1209018imm; Fri, 8 Jun 2018 11:53:08 -0700 (PDT) X-Google-Smtp-Source: ADUXVKLulqqyTYKFomwIUNJ89G21ZNId/GrnQbMoSwwHKT8GQRwq2dfY4d5HUjWdSl/iD59lD+zW X-Received: by 2002:a17:902:9a4c:: with SMTP id x12-v6mr7652584plv.213.1528483988434; Fri, 08 Jun 2018 11:53:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528483988; cv=none; d=google.com; s=arc-20160816; b=vN8ZTZWS270W02gZjkP5Vee3OjnSv47lXhlbofk0sgLOrm5HRbateP24clndUzUh1Z BH6qLYZjUFM6Y/prJ+D2L42a+8e9Qhd3uvhIHDUXoPPjFt2aNGJFxuPIEifpHDQKFYcf xfYp8mYrzV75nxpoY6oAA8cDhUtE1Ke2bSFLZknQllz/gvmutQFV2o6XS1lGGPLyPZX7 blPPSwzNIoX5Zl2Ia9LKD8YuS8Nrtz2TBiiX176OqkqwP+iWka0i9u/oMT1dm66VjgHl LxIVisFKLIKbSVKxmlA5n6RITYyGzfeh1dDctyJCajMR6KA5H5AQW2jWjMM0W3pOw9NY W+Jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=DtgC3n878RzHsFM1uT7Al7ob2l7RMrxY6Kg2MNZnbvY=; b=F/93RX7dzID3YeVlX9quV83b911SmcA2Ps0C/4MiFkW9tKGs7+jA05Y4hZ/EApupyT Sxo9gRa+IKbhjCoKZ7R8UCUsafPxzA+0OH5x+lc8U/rjcQff6nMeZvDNj00znTCZPeEG 0iv1RldqfTkqF1asy5yJhqHxqCwrcWrTHcxASn4c5Xguj1lmgNlfczfr8oFXHdy2yC14 vnxLvLQKczXzrT8ylvRmUWdS6pp/0Gg5PvJfD64/0qX1+J1JMxgVDyTFVLoD2yUlTuWY 5aEqKGGN1Wc5cxLz+TtmEGPDsTwkDfYH/q9BiGx0vmj31T9S+SwoF9bRycDHk2Y7WkzS lZ6Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m32-v6si56939861pld.438.2018.06.08.11.52.54; Fri, 08 Jun 2018 11:53:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752458AbeFHSvp (ORCPT + 99 others); Fri, 8 Jun 2018 14:51:45 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:53810 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752753AbeFHSuV (ORCPT ); Fri, 8 Jun 2018 14:50:21 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.87 #1 (Red Hat Linux)) id 1fRMSq-0006Nz-8U; Fri, 08 Jun 2018 18:50:20 +0000 From: Al Viro To: Linus Torvalds Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/13] __gfs2_lookup(), nfs_finish_open() and fuse_create_open() don't need 'opened' Date: Fri, 8 Jun 2018 19:50:14 +0100 Message-Id: <20180608185019.24472-8-viro@ZenIV.linux.org.uk> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20180608185019.24472-1-viro@ZenIV.linux.org.uk> References: <20180608184842.GD30522@ZenIV.linux.org.uk> <20180608185019.24472-1-viro@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Al Viro Signed-off-by: Al Viro --- fs/fuse/dir.c | 4 ++-- fs/gfs2/inode.c | 7 +++---- fs/nfs/dir.c | 5 ++--- 3 files changed, 7 insertions(+), 9 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index 18952cd38772..ae40501d39c9 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -399,7 +399,7 @@ static struct dentry *fuse_lookup(struct inode *dir, struct dentry *entry, */ static int fuse_create_open(struct inode *dir, struct dentry *entry, struct file *file, unsigned flags, - umode_t mode, int *opened) + umode_t mode) { int err; struct inode *inode; @@ -513,7 +513,7 @@ static int fuse_atomic_open(struct inode *dir, struct dentry *entry, if (fc->no_create) goto mknod; - err = fuse_create_open(dir, entry, file, flags, mode, opened); + err = fuse_create_open(dir, entry, file, flags, mode); if (err == -ENOSYS) { fc->no_create = 1; goto mknod; diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 7bb236b99598..198e07d5ecdd 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -830,14 +830,13 @@ static int gfs2_create(struct inode *dir, struct dentry *dentry, * @dir: The directory inode * @dentry: The dentry of the new inode * @file: File to be opened - * @opened: atomic_open flags * * * Returns: errno */ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry, - struct file *file, int *opened) + struct file *file) { struct inode *inode; struct dentry *d; @@ -879,7 +878,7 @@ static struct dentry *__gfs2_lookup(struct inode *dir, struct dentry *dentry, static struct dentry *gfs2_lookup(struct inode *dir, struct dentry *dentry, unsigned flags) { - return __gfs2_lookup(dir, dentry, NULL, NULL); + return __gfs2_lookup(dir, dentry, NULL); } /** @@ -1244,7 +1243,7 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, if (!d_in_lookup(dentry)) goto skip_lookup; - d = __gfs2_lookup(dir, dentry, file, opened); + d = __gfs2_lookup(dir, dentry, file); if (IS_ERR(d)) return PTR_ERR(d); if (d != NULL) diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index 5b8f1d32d6b8..43dc1c66873d 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1418,8 +1418,7 @@ static int do_open(struct inode *inode, struct file *filp) static int nfs_finish_open(struct nfs_open_context *ctx, struct dentry *dentry, - struct file *file, unsigned open_flags, - int *opened) + struct file *file, unsigned open_flags) { int err; @@ -1530,7 +1529,7 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry, goto out; } - err = nfs_finish_open(ctx, ctx->dentry, file, open_flags, opened); + err = nfs_finish_open(ctx, ctx->dentry, file, open_flags); trace_nfs_atomic_open_exit(dir, ctx, open_flags, err); put_nfs_open_context(ctx); out: -- 2.11.0