Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1276890imm; Fri, 8 Jun 2018 13:07:36 -0700 (PDT) X-Google-Smtp-Source: ADUXVKITPEDtyNFF3N3YkVG3KOEreCEr3do7XOOADpEmoLh7AXL0UoMv+MZfajpAcvYapKFyAWZs X-Received: by 2002:a62:a0c:: with SMTP id s12-v6mr7456890pfi.33.1528488456119; Fri, 08 Jun 2018 13:07:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528488456; cv=none; d=google.com; s=arc-20160816; b=jDGxL53qhLEvpsm5hgrCW1kNMCyB3D9jKuAThXjOEUHWpoG7vj7vzCVi1TMCWclE3k P8n4FtTyTGfA5s+XaZFOp2hKitZjaH1BgPrBVLurHzCihEfufW6S6ep7xIGz5kzp3fe7 yHID5hKRszoIuAQy32aCS+7ZovigJR2qJLOIwpOtAxsha+ntMgiqZRL1Az3eMgryNRBR wgatosRsoeG8xJUFvMCPGhQf/2xVHVseEX8cZguiLiQlyciKe47RnkHwhEQzlJDjoFRO cj8ZghrrZ9erxfQBOi8DQhfn8tH/SDd3zT/spzqBERyFzW42RTMajFAFU/xuBSvml+Gs Z8AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature:arc-authentication-results; bh=6AxYqO74cBFRCeMxgGxjSkNMSczcIeA4tGAIjWBJo8g=; b=hqp5xv3KkwEvAwvimOhUVRNfgfO4tRMzc65reQCk6BywPSwD7HLygA4PkEoBodDKz4 blXZE3zFWmJwq7xwq7bVlqaK4eoXt3ZAwdk5EwgoJ790oxRqdtKNoC+OcLDCiJ09lExG ZGtHE58hpxTU1zxri/acdiCFSOskIS8QO0KGzZa+LxtrU+rbs67je7mewV61TRDNNuoq j4gF2wRBNN63zsQisehWfN4PNtV+FlivDsatGSgFbavN6jhKyBtmMhHyrKC35H0jFu9h bNGtyzo3L7uh2QMEutqUuf/Pu2xnAv0WmsUq3gAlml09p7A7Q0qK8xRX9T+RIFQmXJ03 7LgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VJ0HS1Ia; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e10-v6si7596473pga.8.2018.06.08.13.07.22; Fri, 08 Jun 2018 13:07:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=VJ0HS1Ia; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932183AbeFHUFj (ORCPT + 99 others); Fri, 8 Jun 2018 16:05:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:49128 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146AbeFHUFg (ORCPT ); Fri, 8 Jun 2018 16:05:36 -0400 Received: from localhost (unknown [150.199.191.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DE80B20874; Fri, 8 Jun 2018 20:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1528488336; bh=o7Bjuhz6mlNkxN04uXXq9urmSNLANHw+KAxxiniKvq4=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=VJ0HS1IacLWM5jULpW2KuuVLWJwYX3VVW5bR7GdCEThFMM/VGhwU2cu8T/fZ7m088 /w7sfGVyIBVvagsUCfDT9RqpghXkKqxLP65Xy/SOwViovbhUKYXcQO6PGIQwPXMEyg stLUr3R3ADyCOOpjdY8UqW08EHZlbOjlcqeG0tMI= Subject: [PATCH v1 08/13] PCI/AER: Move pcie_aer_get_firmware_first() to portdrv.h From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: Keith Busch , Borislav Petkov , Oza Pawandeep , linux-kernel@vger.kernel.org Date: Fri, 08 Jun 2018 15:05:35 -0500 Message-ID: <152848833510.11888.13834530632280301120.stgit@bhelgaas-glaptop.roam.corp.google.com> In-Reply-To: <152848785553.11888.12243539903985770441.stgit@bhelgaas-glaptop.roam.corp.google.com> References: <152848785553.11888.12243539903985770441.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: StGit/0.18 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bjorn Helgaas Move pcie_aer_get_firmware_first() to portdrv.h, where it can be more easily shared between AER and DPC. Then DPC no longer needs to include aer/aerdrv.h. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/pci/pcie/aer/aerdrv.h | 10 ---------- drivers/pci/pcie/dpc.c | 1 - drivers/pci/pcie/portdrv.h | 11 +++++++++++ 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/pci/pcie/aer/aerdrv.h b/drivers/pci/pcie/aer/aerdrv.h index f4fc71119cf2..b0c4aaa79d9c 100644 --- a/drivers/pci/pcie/aer/aerdrv.h +++ b/drivers/pci/pcie/aer/aerdrv.h @@ -78,14 +78,4 @@ struct aer_rpc { irqreturn_t aer_irq(int irq, void *context); -#ifdef CONFIG_ACPI_APEI -int pcie_aer_get_firmware_first(struct pci_dev *pci_dev); -#else -static inline int pcie_aer_get_firmware_first(struct pci_dev *pci_dev) -{ - if (pci_dev->__aer_firmware_first_valid) - return pci_dev->__aer_firmware_first; - return 0; -} -#endif #endif /* _AERDRV_H_ */ diff --git a/drivers/pci/pcie/dpc.c b/drivers/pci/pcie/dpc.c index d6436681c535..921ed979109d 100644 --- a/drivers/pci/pcie/dpc.c +++ b/drivers/pci/pcie/dpc.c @@ -13,7 +13,6 @@ #include "portdrv.h" #include "../pci.h" -#include "aer/aerdrv.h" struct dpc_dev { struct pcie_device *dev; diff --git a/drivers/pci/pcie/portdrv.h b/drivers/pci/pcie/portdrv.h index 2bb5db7b53e6..6a261dc7cd4c 100644 --- a/drivers/pci/pcie/portdrv.h +++ b/drivers/pci/pcie/portdrv.h @@ -110,6 +110,17 @@ static inline bool pcie_pme_no_msi(void) { return false; } static inline void pcie_pme_interrupt_enable(struct pci_dev *dev, bool en) {} #endif /* !CONFIG_PCIE_PME */ +#ifdef CONFIG_ACPI_APEI +int pcie_aer_get_firmware_first(struct pci_dev *pci_dev); +#else +static inline int pcie_aer_get_firmware_first(struct pci_dev *pci_dev) +{ + if (pci_dev->__aer_firmware_first_valid) + return pci_dev->__aer_firmware_first; + return 0; +} +#endif + struct pcie_port_service_driver *pcie_port_find_service(struct pci_dev *dev, u32 service); struct device *pcie_port_find_device(struct pci_dev *dev, u32 service);