Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1288024imm; Fri, 8 Jun 2018 13:20:57 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJkjEOnYGx7xbz25PRCLoIQKSmaioYaVrNMU/DM8DAe7+LaZ47eoc/J0Lc813Z4kUc3Kdsg X-Received: by 2002:a62:a09c:: with SMTP id p28-v6mr7506786pfl.9.1528489257268; Fri, 08 Jun 2018 13:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528489257; cv=none; d=google.com; s=arc-20160816; b=hoMzQIBJhLRyHuYPzCY3X+O9aHb10TqMPNVRKdkluRwOLlFLVYhYm8viurESBrF39m DU2xSnSfKeFR9i9HpsQfgEg6M4V6WJyFkyzf0ko8s9dU25vyccarvljxe+Qj9P23QAS5 NDg+mO2yMeKyOB0ImT7xn+uFId6uQwGsQ102fxGADHGsuXM7reuMPPTkUmVgDnMHtzYU lPc2eeWiAon1vqeI+5FHvPTayibL2MdOubGKsNyBy0aj3QoD6n7KE681g1pa9vED90Zs vRF/jxltcPnRSa7BoEEhLWpJPD1UknR0Q0I2F4SBdIVmAvzmomsvVdMoUsLq9TImzB5X tY7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=HGP1ZXUCUVirfKp1XeG2OY5jBjQbV5EVLTReQ5x51EU=; b=dZxbN5iJiCffwRNOdSX+9SHug55qId2GWw6RIWyjb3RS6QzhgurWcX/2ZcDZAdpftZ qrSv90EbTeMrpSZZvawEAdHE2SABm1tAC/f9pd8qqgQrw7/1y18Vqyc/nIv44N4jnDiG 44Q7e3dQjPCwJeoiqF9Qm8EtLt2hKiJ09mLXwB0qOhMJ5TXqbyyd5HwPZYhPWY8s7tjU 51BqfoDNdJIUZeDhMpaFah53DXRyaCK6m8u5snzATtWDmgGnseO4hLwXudEAmQzGihyV 61OgxFAWsnA5EJpm/lEwWZoF5mX1RBTNIJexqtXZnuHCwMmUvFRngBY9uN1V4djoBxxY Ai5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17-v6si30498924pgb.465.2018.06.08.13.20.42; Fri, 08 Jun 2018 13:20:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753093AbeFHUUS (ORCPT + 99 others); Fri, 8 Jun 2018 16:20:18 -0400 Received: from mga09.intel.com ([134.134.136.24]:51243 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752739AbeFHUUQ (ORCPT ); Fri, 8 Jun 2018 16:20:16 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2018 13:20:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,491,1520924400"; d="scan'208";a="206502569" Received: from unknown (HELO localhost.localdomain) ([10.232.112.44]) by orsmga004.jf.intel.com with ESMTP; 08 Jun 2018 13:20:15 -0700 Date: Fri, 8 Jun 2018 14:23:03 -0600 From: Keith Busch To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Borislav Petkov , Oza Pawandeep , linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v1 00/13] PCI/AER: Squash into one file Message-ID: <20180608202303.GB24554@localhost.localdomain> References: <152848785553.11888.12243539903985770441.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152848785553.11888.12243539903985770441.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 08, 2018 at 03:04:45PM -0500, Bjorn Helgaas wrote: > The AER code is scattered across several files and buried a little too deep > in the hierarchy, which makes it a bit of a hassle to browse. Consolidate > it all in a single file (plus the optional aer_inject module) and move it > up one level to drivers/pci/pcie/aer.c. > > This is all pure code moves; no functional changes intended. Thanks for doing this. I got a head start on reviewing when I saw this merged to your tree earlier today, and the driver is much more pleasant to read than before! Reviewed-by: Keith Busch