Received: by 2002:ac0:a5b6:0:0:0:0:0 with SMTP id m51-v6csp1360596imm; Fri, 8 Jun 2018 14:53:56 -0700 (PDT) X-Google-Smtp-Source: ADUXVKJE4Hfh2uGVkIMYvuppguSvaCdNyftTbWGe9DRcZvJ5A7mC3dRK0jMpGh0mq3Wkf2k3sFe5 X-Received: by 2002:a17:902:9307:: with SMTP id bc7-v6mr8276638plb.292.1528494836282; Fri, 08 Jun 2018 14:53:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1528494836; cv=none; d=google.com; s=arc-20160816; b=OEUBv5TsB/W6g8DJpgFUzNTvCpVK0URLI+ApcNPAx/bW014PvYcbL+4Y9otTAfcWO0 kBLl9FCM7h+vrmh3rYiN84pXBla+OOSWIeVoS7O2ogEyV66tAQKEZD9r8+Cp4dG2gC2u vmMDBEB2aac6YQqbJtH7XCAbTIZ03I3hQF0i+KjKHuD7Xb/Z5nkYHEqlK5BrGJ2bpAs7 Y+xBCFBBJHPyxvVd4ZnrFr2EjcYNoCvrItTwB6znO6iEs0YyK8vt/Bn0Aj6AHteBRDNl cr4oSK2BQna23UmfAP09SrcdUgzrgPEBsTp2WAD0GTbdIeWCDJoCEQQNRPwiT4u/u1Jq bpxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Y6142mVd0abv1jK06mUQOg9XsfcQixp6+m7adQfTtpc=; b=0KKyTFADmQAo4pOjv4vgLHVM9FfrKCcmdxxgmnG8/ZZxqTIanuZ2tO9qcvcQNnvAeK Bs4FkMT4IZtLjta+jt5Mf3YHaOrElyO/27nPB4vnZW0lnBLeWm9HjxYGhxlQANJp44g0 rZ166UTUMA/oYzK80Gz43lkbzLB6vKbJsK2IKaZpSQBDf/ALt0pgO09IiLDdPQHc1kUc 0Khoz26GMIYCHJlHGu2XHlJdYScuyJ/j51uFOJmZF7SCqd0Q3kmR6t0c+6jWoefERZeF QfOXrHhUXUgUobongdaSFT4/j8DzjXV08kiOmtUw46jHmlq5bDbi6xKxaHmOiB9bGEyY R8xQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JcNAN4dd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v61-v6si57490115plb.499.2018.06.08.14.53.41; Fri, 08 Jun 2018 14:53:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=JcNAN4dd; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247AbeFHVxB (ORCPT + 99 others); Fri, 8 Jun 2018 17:53:01 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35708 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbeFHVxA (ORCPT ); Fri, 8 Jun 2018 17:53:00 -0400 Received: by mail-wm0-f65.google.com with SMTP id j15-v6so6150548wme.0 for ; Fri, 08 Jun 2018 14:52:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Y6142mVd0abv1jK06mUQOg9XsfcQixp6+m7adQfTtpc=; b=JcNAN4ddPnpZMbKTLBtPsAVsRHOOrvXZzqE5tFPrCrqT2YRxZhvQq6QrGy+J/OlMO+ UVr7BiNMiTGsPxHCfO3r57chtAEZjI88DC1PcRGu2EA3WJ+Fb8Vz8O4U8OEuexBP5bJ5 0Lh6sqJM+1e7T+FLv7tMUEbyoC0BJKi8NMwV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Y6142mVd0abv1jK06mUQOg9XsfcQixp6+m7adQfTtpc=; b=OVgy7sCEitKlcXQEIiYDfM+gh7H0yde6PonHrzj9NuuO5nnGPLrTLneGm3NpfcwV57 eCM7+egjpTI3/SQH4CFEYbZ4J5qO7IWGavcoxQgpAG24ey80tHQKOElO52NjydeoHDkC Q3XDLFn5gDybn7axFwVqd0u94uI9x8XJupIGDteq63qkLmDoolfZZ9FF+Feo06zdA74P 574+uMCcQyFPt+I71LZE95hkQuGEK2vxawRpSzumBy0XMV4zq2whXla1IAygh6/QjuG1 jr0afbye1imvpUbl6znBRQa0H/H6DlCDX51S/KZOLBx7jMx+GqNR31XT88k9iYpS0kXE 8zXg== X-Gm-Message-State: APt69E05j5n53WgwAI+TBrBbqn8d4Fkfje2/pUcPZVQzUe1UB+fzTehq RZURXqGl6P38YlyQseEqgXIg6yO2BEiqSsXC6QWZsg== X-Received: by 2002:a50:ec19:: with SMTP id g25-v6mr8697530edr.242.1528494778697; Fri, 08 Jun 2018 14:52:58 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a50:a48a:0:0:0:0:0 with HTTP; Fri, 8 Jun 2018 14:52:58 -0700 (PDT) In-Reply-To: <20180608214946.GI30587@xps15> References: <1528235011-30691-1-git-send-email-suzuki.poulose@arm.com> <1528235011-30691-11-git-send-email-suzuki.poulose@arm.com> <20180608214946.GI30587@xps15> From: Mathieu Poirier Date: Fri, 8 Jun 2018 15:52:58 -0600 Message-ID: Subject: Re: [PATCH 10/20] dts: juno: Update coresight bindings for hw port To: Suzuki K Poulose Cc: linux-arm-kernel , Rob Herring , Frank Rowand , Mark Rutland , Sudeep Holla , arm@kernel.org, Linux Kernel Mailing List , Matt Sealey , John Horley , Charles Garcia-Tobin , coresight@lists.linaro.org, devicetree@vger.kernel.org, Mike Leach , Liviu Dudau Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8 June 2018 at 15:49, Mathieu Poirier wrote: > On Tue, Jun 05, 2018 at 10:43:21PM +0100, Suzuki K Poulose wrote: >> Switch to updated coresight bindings for hw ports. >> >> Cc: Sudeep Holla >> Cc: Liviu Dudau >> Cc: Mathieu Poirier >> Signed-off-by: Suzuki K Poulose >> --- >> Changes since V1: >> - Add support Juno for r1 & r2. >> --- > > Reviewed-by: Mathieu Poirier Sudeep please hold on before applying this as there is more work to be done on this set. > >> arch/arm64/boot/dts/arm/juno-base.dtsi | 82 ++++++++++++++++++++++--------- >> arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi | 26 +++++++--- >> arch/arm64/boot/dts/arm/juno.dts | 5 +- >> 3 files changed, 81 insertions(+), 32 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/arm/juno-base.dtsi b/arch/arm64/boot/dts/arm/juno-base.dtsi >> index eb749c5..33b41ba 100644 >> --- a/arch/arm64/boot/dts/arm/juno-base.dtsi >> +++ b/arch/arm64/boot/dts/arm/juno-base.dtsi >> @@ -122,15 +122,18 @@ >> port@0 { >> reg = <0>; >> etf0_in_port: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&main_funnel_out_port>; >> + coresight,hwid = <0>; >> }; >> }; >> >> /* output port */ >> port@1 { >> - reg = <0>; >> + reg = <1>; >> etf0_out_port: endpoint { >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -145,8 +148,9 @@ >> power-domains = <&scpi_devpd 0>; >> port { >> tpiu_in_port: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&replicator_out_port0>; >> + coresight,hwid = <0>; >> }; >> }; >> }; >> @@ -168,23 +172,27 @@ >> reg = <0>; >> main_funnel_out_port: endpoint { >> remote-endpoint = <&etf0_in_port>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> >> /* input ports */ >> port@1 { >> - reg = <0>; >> + reg = <1>; >> main_funnel_in_port0: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster0_funnel_out_port>; >> + coresight,hwid = <0>; >> }; >> }; >> >> port@2 { >> - reg = <1>; >> + reg = <2>; >> main_funnel_in_port1: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster1_funnel_out_port>; >> + coresight,hwid = <1>; >> }; >> }; >> }; >> @@ -200,8 +208,9 @@ >> power-domains = <&scpi_devpd 0>; >> port { >> etr_in_port: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&replicator_out_port1>; >> + coresight,hwid = <0>; >> }; >> }; >> }; >> @@ -217,6 +226,8 @@ >> power-domains = <&scpi_devpd 0>; >> port { >> stm_out_port: endpoint { >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -240,6 +251,8 @@ >> port { >> cluster0_etm0_out_port: endpoint { >> remote-endpoint = <&cluster0_funnel_in_port0>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -259,22 +272,26 @@ >> reg = <0>; >> cluster0_funnel_out_port: endpoint { >> remote-endpoint = <&main_funnel_in_port0>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> >> port@1 { >> - reg = <0>; >> + reg = <1>; >> cluster0_funnel_in_port0: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster0_etm0_out_port>; >> + coresight,hwid = <0>; >> }; >> }; >> >> port@2 { >> - reg = <1>; >> + reg = <2>; >> cluster0_funnel_in_port1: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster0_etm1_out_port>; >> + coresight,hwid = <1>; >> }; >> }; >> }; >> @@ -299,6 +316,8 @@ >> port { >> cluster0_etm1_out_port: endpoint { >> remote-endpoint = <&cluster0_funnel_in_port1>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -322,6 +341,8 @@ >> port { >> cluster1_etm0_out_port: endpoint { >> remote-endpoint = <&cluster1_funnel_in_port0>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -341,36 +362,42 @@ >> reg = <0>; >> cluster1_funnel_out_port: endpoint { >> remote-endpoint = <&main_funnel_in_port1>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> >> port@1 { >> - reg = <0>; >> + reg = <1>; >> cluster1_funnel_in_port0: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster1_etm0_out_port>; >> + coresight,hwid = <0>; >> }; >> }; >> >> port@2 { >> - reg = <1>; >> + reg = <2>; >> cluster1_funnel_in_port1: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster1_etm1_out_port>; >> + coresight,hwid = <1>; >> }; >> }; >> port@3 { >> - reg = <2>; >> + reg = <3>; >> cluster1_funnel_in_port2: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster1_etm2_out_port>; >> + coresight,hwid = <2>; >> }; >> }; >> port@4 { >> - reg = <3>; >> + reg = <4>; >> cluster1_funnel_in_port3: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&cluster1_etm3_out_port>; >> + coresight,hwid = <3>; >> }; >> }; >> }; >> @@ -395,6 +422,8 @@ >> port { >> cluster1_etm1_out_port: endpoint { >> remote-endpoint = <&cluster1_funnel_in_port1>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -418,6 +447,8 @@ >> port { >> cluster1_etm2_out_port: endpoint { >> remote-endpoint = <&cluster1_funnel_in_port2>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -441,6 +472,8 @@ >> port { >> cluster1_etm3_out_port: endpoint { >> remote-endpoint = <&cluster1_funnel_in_port3>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> }; >> @@ -462,6 +495,8 @@ >> reg = <0>; >> replicator_out_port0: endpoint { >> remote-endpoint = <&tpiu_in_port>; >> + coresight,hwid = <0>; >> + direction = <1>; >> }; >> }; >> >> @@ -469,14 +504,17 @@ >> reg = <1>; >> replicator_out_port1: endpoint { >> remote-endpoint = <&etr_in_port>; >> + coresight,hwid = <1>; >> + direction = <1>; >> }; >> }; >> >> /* replicator input port */ >> port@2 { >> - reg = <0>; >> + reg = <2>; >> replicator_in_port0: endpoint { >> - slave-mode; >> + direction = <0>; >> + coresight,hwid = <0>; >> }; >> }; >> }; >> diff --git a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi >> index 0c43fb3..146a5d9 100644 >> --- a/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi >> +++ b/arch/arm64/boot/dts/arm/juno-cs-r1r2.dtsi >> @@ -15,15 +15,18 @@ >> port@0 { >> reg = <0>; >> csys1_funnel_out_port: endpoint { >> + coresight,hwid = <0>; >> + direction = <1>; >> remote-endpoint = <&etf1_in_port>; >> }; >> }; >> >> /* input port */ >> port@1 { >> - reg = <0>; >> + reg = <1>; >> csys1_funnel_in_port0: endpoint { >> - slave-mode; >> + coresight,hwid = <0>; >> + direction = <0>; >> }; >> }; >> >> @@ -45,15 +48,18 @@ >> port@0 { >> reg = <0>; >> etf1_in_port: endpoint { >> - slave-mode; >> + direction = <0>; >> + coresight,hwid = <0>; >> remote-endpoint = <&csys1_funnel_out_port>; >> }; >> }; >> >> /* output port */ >> port@1 { >> - reg = <0>; >> + reg = <1>; >> etf1_out_port: endpoint { >> + coresight,hwid = <0>; >> + direction = <1>; >> remote-endpoint = <&csys2_funnel_in_port1>; >> }; >> }; >> @@ -75,23 +81,27 @@ >> port@0 { >> reg = <0>; >> csys2_funnel_out_port: endpoint { >> + coresight,hwid = <0>; >> + direction = <1>; >> remote-endpoint = <&replicator_in_port0>; >> }; >> }; >> >> /* input ports */ >> port@1 { >> - reg = <0>; >> + reg = <1>; >> csys2_funnel_in_port0: endpoint { >> - slave-mode; >> + direction = <0>; >> + coresight,hwid = <0>; >> remote-endpoint = <&etf0_out_port>; >> }; >> }; >> >> port@2 { >> - reg = <1>; >> + reg = <2>; >> csys2_funnel_in_port1: endpoint { >> - slave-mode; >> + direction = <0>; >> + coresight,hwid = <1>; >> remote-endpoint = <&etf1_out_port>; >> }; >> }; >> diff --git a/arch/arm64/boot/dts/arm/juno.dts b/arch/arm64/boot/dts/arm/juno.dts >> index c9236c4..27b8036 100644 >> --- a/arch/arm64/boot/dts/arm/juno.dts >> +++ b/arch/arm64/boot/dts/arm/juno.dts >> @@ -260,10 +260,11 @@ >> &main_funnel { >> ports { >> port@3 { >> - reg = <2>; >> + reg = <3>; >> main_funnel_in_port2: endpoint { >> - slave-mode; >> + direction = <0>; >> remote-endpoint = <&stm_out_port>; >> + coresight,hwid = <2>; >> }; >> }; >> }; >> -- >> 2.7.4 >>